aaron.ballman added a comment. In D131213#3702707 <https://reviews.llvm.org/D131213#3702707>, @iana wrote:
> In D131213#3702699 <https://reviews.llvm.org/D131213#3702699>, @ddcc wrote: > >> I missed line 19, yeah that makes sense. @iana is that ok with you? > > Ah, I didn't see that either. Can we just lose the `defined` on line 26 then? > It's redundant and little confusing. I'm fine dropping it (ever so slightly less work for the preprocessor to do in this file), but I don't see what the confusion is with checking whether `__cplusplus` is defined before testing its value, so I'm also fine with leaving it as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131213/new/ https://reviews.llvm.org/D131213 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
