vitalybuka added a subscriber: smd. vitalybuka added inline comments. Herald added a subscriber: Enna1. Herald added a project: All.
================ Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { + stack->trace++; + stack->size--; ---------------- maybe we should pop everything up to "pc" to avoid issues with nested calls? For most users hwasan frames are not very useful. However if you work on sanitizer, some frames can be a useful info. So I don't mind we just relax test cases to accommodate this nesting. cc @smd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103562/new/ https://reviews.llvm.org/D103562 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits