[PATCH] D130600: [clang][dataflow] Handle return statements

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:208 Environment Env(*this); + Env.ReturnLoc = Env.getStorageLocation(*Call, SkipPast::Reference); Let's add a FIXME to support

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler created this revision. ckandeler added reviewers: sammccall, nridge. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cl

[PATCH] D131170: [clang][dataflow] Analyze method bodies

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:217 +const Expr *Arg = MethodCall->getImplicitObjectArgument(); +Env.ThisPointeeLoc = Env.getStorageLocation(*Arg, SkipPast::Reference); + } samestep wrote

[PATCH] D131178: [clang][dataflow][NFC] Convert mutable vector references to ArrayRef

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `tra

[PATCH] D131177: [clang][dataflow][NFC] Resize vector directly with ctor

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repo

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

kito-cheng added a comment. Just realized the problem is trying to fixed the default value of `-mabi=`, currently `clang -target riscv32-elf -march=rv64gc -mabi=lp64d`/`riscv32-elf-clang -march=rv64gc -mabi=lp64d` is work, and match the behavior of GCC did, `riscv32-elf-gcc -march=rv64gc -mabi=

[PATCH] D124751: [HLSL] Support -E option for HLSL.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. One very nitpick-y comment, otherwise LGTM. Comment at: clang/lib/Sema/SemaDecl.cpp:9841 +if (!NewFD->isInvalidDecl() && +// Skip operator overload which not identi

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

tstellar added a comment. In D129973#3699055 , @kadircet wrote: > Reverted in df48e3fbcc8be1f4c04bd97517d12e662f54de75 > , > @tstellar it needs to be cherry-picked into release branch

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar added a comment. @Ericson2314 Your version of these patches removed a few more things than mine (which seems better to me), do you want to just split your patch and commit the parts separately? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

tstellar added a comment. @pengfei You can commit this directly to the release/15.x branch whenever you are ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131172/new/ https://reviews.llvm.org/D131172

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

thakis added a comment. Looks like this might break tests on windows: http://45.33.8.238/win/63804/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130808/new/ https://revi

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

cjdb added a subscriber: Naghasan. cjdb added a comment. In D131084#3699223 , @aaron.ballman wrote: > In D131084#3697678 , @cjdb wrote: > >> It seems I got confused and conflated the two this morning. >> >> In D1

[PATCH] D131170: [clang][dataflow] Analyze method bodies

ymandel accepted this revision. ymandel added a comment. Nice!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131170/new/ https://reviews.llvm.org/D131170 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

ASDenysPetrov added a comment. In D131006#3699017 , @martong wrote: > Awesome! Thank you! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1512-1516 +if (IsFirst) { + IsFirst = false; + RS

[clang] 0eb7d86 - Revert "[InstrProf] Add new format for -fprofile-list="

Author: Nico Weber Date: 2022-08-04T13:04:59-04:00 New Revision: 0eb7d86f5873ce897894339a3cc5bc69ca507bee URL: https://github.com/llvm/llvm-project/commit/0eb7d86f5873ce897894339a3cc5bc69ca507bee DIFF: https://github.com/llvm/llvm-project/commit/0eb7d86f5873ce897894339a3cc5bc69ca507bee.diff LO

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

thakis added a comment. Reverted in 0eb7d86f5873ce897894339a3cc5bc69ca507bee for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130808/new/ https://reviews.llvm.org/D130808 ___ cfe-commits mailing li

[PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. In D130689#3696186 , @thieta wrote: > @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it > can be built with CXX_STANDARD=17 and OSX_DEPLOYMENT_TARGET=10.11. Thanks! We took this opportunity to bump our

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

phosek updated this revision to Diff 450039. phosek marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130226/new/ https://reviews.llvm.org/D130226 Files: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp clang-tools

[clang] 5659908 - [clang][dataflow][NFC] Resize vector directly with ctor

Author: Eric Li Date: 2022-08-04T13:12:37-04:00 New Revision: 5659908f4c6d32d3f7d1ebbe014fbd9419cdfb9c URL: https://github.com/llvm/llvm-project/commit/5659908f4c6d32d3f7d1ebbe014fbd9419cdfb9c DIFF: https://github.com/llvm/llvm-project/commit/5659908f4c6d32d3f7d1ebbe014fbd9419cdfb9c.diff LOG:

[clang] 18034ae - [clang][dataflow][NFC] Convert mutable vector references to ArrayRef

Author: Eric Li Date: 2022-08-04T13:12:37-04:00 New Revision: 18034aee63eeac673496a88d9e90c8dd73d15927 URL: https://github.com/llvm/llvm-project/commit/18034aee63eeac673496a88d9e90c8dd73d15927 DIFF: https://github.com/llvm/llvm-project/commit/18034aee63eeac673496a88d9e90c8dd73d15927.diff LOG:

[PATCH] D131177: [clang][dataflow][NFC] Resize vector directly with ctor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5659908f4c6d: [clang][dataflow][NFC] Resize vector directly with ctor (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131057: [Sema] -Wformat: support C23 format specifier %b %B

MaskRay updated this revision to Diff 450046. MaskRay marked an inline comment as done. MaskRay added a comment. Thanks for quick reviews! Updated ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131057/new/ https://reviews.llvm.org/D

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

melver updated this revision to Diff 450043. melver added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130888/new/ https://reviews.llvm.org/D130888 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Bas

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

abrachet accepted this revision. abrachet added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:195 + $ clang-doc --executor=all-TUs compile_commands.json + )"; + Is it intentional that the rest of this help message also has two s

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added a comment. In D130123#3698399 , @Ariel-Burton wrote: > Just to make sure that we're on the same page, you'd like to see a test that > confirms that clang is rejecting the `template void f(T __ptr32 > a)` example, and possibly one that check

[clang] 88501dc - [Sema] -Wformat: support C23 format specifier %b %B

Author: Fangrui Song Date: 2022-08-04T10:26:31-07:00 New Revision: 88501dc74911b00186298fe1fffe8dfb1f09b1c1 URL: https://github.com/llvm/llvm-project/commit/88501dc74911b00186298fe1fffe8dfb1f09b1c1 DIFF: https://github.com/llvm/llvm-project/commit/88501dc74911b00186298fe1fffe8dfb1f09b1c1.diff

[PATCH] D131057: [Sema] -Wformat: support C23 format specifier %b %B

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88501dc74911: [Sema] -Wformat: support C23 format specifier %b %B (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis added a comment. In D130808#3700074 , @thakis wrote: > Reverted in 0eb7d86f5873ce897894339a3cc5bc69ca507bee > for now. Thanks for reverting. I'm looking into it. Repository:

[PATCH] D131057: [Sema] -Wformat: support C23 format specifier %b %B

enh added a comment. In D131057#3697392 , @MaskRay wrote: > In D131057#3697095 , @dim wrote: > >>> GCC 12 -Wformat -pedantic emits a warning: >>> >>> warning: ISO C17 does not support the ‘%b’ gnu_printf format

[clang] 8c30f4a - [AArch64] Always allow the __bf16 type

Author: David Green Date: 2022-08-04T18:35:27+01:00 New Revision: 8c30f4a5ab3e8dc4a75669d497723f9a2d8d39c8 URL: https://github.com/llvm/llvm-project/commit/8c30f4a5ab3e8dc4a75669d497723f9a2d8d39c8 DIFF: https://github.com/llvm/llvm-project/commit/8c30f4a5ab3e8dc4a75669d497723f9a2d8d39c8.diff L

[PATCH] D130973: [AArch64] Always allow the __bf16 type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c30f4a5ab3e: [AArch64] Always allow the __bf16 type (authored by dmgreen). Herald added a project: clang. Herald added a subscriber: cfe-commits. R

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

phosek updated this revision to Diff 450055. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130226/new/ https://reviews.llvm.org/D130226 Files: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp clang-tools

[PATCH] D131183: AMDGPU/clang: Remove dead code

arsenm created this revision. arsenm added reviewers: yaxunl, sameerds, saiislam, JonChesterfield, RKSimon. Herald added subscribers: kosarev, t-tye, tpr, dstuttard, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The order has to b

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep updated this revision to Diff 450058. samestep added a comment. Add Stanislav's suggested comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 Files: clang/include/clang/Analysis/FlowSensit

[clang] 0eaecbb - [clang][dataflow] Handle return statements

Author: Sam Estep Date: 2022-08-04T17:42:19Z New Revision: 0eaecbbc231883b43d3ac761b276d9f505c89c27 URL: https://github.com/llvm/llvm-project/commit/0eaecbbc231883b43d3ac761b276d9f505c89c27 DIFF: https://github.com/llvm/llvm-project/commit/0eaecbbc231883b43d3ac761b276d9f505c89c27.diff LOG: [cl

[PATCH] D130600: [clang][dataflow] Handle return statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0eaecbbc2318: [clang][dataflow] Handle return statements (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] ea50901 - [clang-doc] Default to Standalone executor and improve documentation

Author: Petr Hosek Date: 2022-08-04T17:43:16Z New Revision: ea50901aa9e58fe3750df3e38471e65b027317fc URL: https://github.com/llvm/llvm-project/commit/ea50901aa9e58fe3750df3e38471e65b027317fc DIFF: https://github.com/llvm/llvm-project/commit/ea50901aa9e58fe3750df3e38471e65b027317fc.diff LOG: [c

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea50901aa9e5: [clang-doc] Default to Standalone executor and improve documentation (authored by phosek). Repository: rG LLVM Github Monorepo CHAN

[clang] 8611a77 - [clang][dataflow] Analyze method bodies

Author: Sam Estep Date: 2022-08-04T17:45:47Z New Revision: 8611a77ee7ee342f5925cba2fa6df023596af9d9 URL: https://github.com/llvm/llvm-project/commit/8611a77ee7ee342f5925cba2fa6df023596af9d9 DIFF: https://github.com/llvm/llvm-project/commit/8611a77ee7ee342f5925cba2fa6df023596af9d9.diff LOG: [cl

[PATCH] D131170: [clang][dataflow] Analyze method bodies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8611a77ee7ee: [clang][dataflow] Analyze method bodies (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D131178: [clang][dataflow][NFC] Convert mutable vector references to ArrayRef

li.zhe.hua closed this revision. li.zhe.hua added a comment. Bah, I think I screwed up `arc` at some point. This was committed as 18034aee63eeac673496a88d9e90c8dd73d15927 . Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131039: [clang][dataflow] Add cache of `ControlFlowContext`s for function decls.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:38 + + // DEPRECATED. Use overload above. static llvm::Expected build(const Decl *D, Stmt *S, xazax.hun wrote:

[clang] 010f329 - [RISCV][Clang] Support policy function for all vector segment load.

Author: Zakk Chen Date: 2022-08-04T17:47:24Z New Revision: 010f329803c84e43ec15ffaff7b6e26b032cbcc6 URL: https://github.com/llvm/llvm-project/commit/010f329803c84e43ec15ffaff7b6e26b032cbcc6 DIFF: https://github.com/llvm/llvm-project/commit/010f329803c84e43ec15ffaff7b6e26b032cbcc6.diff LOG: [RI

[PATCH] D126750: [RISCV][Clang] Support policy function for all vector segment load.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG010f329803c8: [RISCV][Clang] Support policy function for all vector segment load. (authored by khchen). Changed prior to commit: https://reviews.l

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 updated this revision to Diff 450069. yurai007 marked an inline comment as done. yurai007 added a comment. Rebase to last SmallVector NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130268/new/ https://reviews.llvm.org/D130268 Files:

[PATCH] D131143: [Clang] Interaction of FP pragmas and function template instantiation

efriedma added a comment. > In the case is explicit instantiation there is apparent connection > between a point in source code and instantiated function. It can > support interaction of pragmas that act in that point. For example, in > the code: > > #pragma STDC FENV_ROUND FE_DOWNWARD > templ

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 450072. royjacobson added a comment. Rebase on main and re-target LLVM16 in cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/Release

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

smeenai added a comment. https://godbolt.org/z/axhbj3MPE is a simpler repro in Godbolt with Boost 1.79 (the latest version). I agree that it'll be tricky to manage expectations if we downgrade to a warning, but I also suspect that the first time many people will run into this new error is when

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

aeubanks added a comment. in the commit message In addition, capturing an anonymous union member, a bitfield, or a structured binding thereof now has a better diagnostic. "better diagnostic" implies there was already a diagnostic, but we're seeing new errors pop up. is this just a not pre

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added a comment. In D122768#3700451 , @aeubanks wrote: > in the commit message > > In addition, capturing an anonymous union member, > a bitfield, or a structured binding thereof now has a > better diagnostic. > > "better diagnostic" implie

[PATCH] D130907: [Clang] Use pragma FENV_ROUND to reset rounding mode settings.

efriedma added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:398 +// If dynamic rounding mode is specified in absence of FENV_ACCESS, treat it +// as setting default rounding mode. +FpPragmaStack.CurrentValue.clearConstRoundingModeOverride(); -

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

martong added inline comments. Comment at: clang/test/Analysis/range-inferring-from-disequality-map.cpp:50-51 +if(x != tmp1 && x != tmp2) + // TODO: This condition should be infeasible. + // Thus, the branch should be unreachable. + clang_analyzer_value(x

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450093. ckissane added a comment. - remove compression kind || && overload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Se

[PATCH] D131183: AMDGPU/clang: Remove dead code

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. The scope arg to the builtin is a string. I doubt non-constant scope arg will ever get supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131183/new/ https://rev

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. All right! Last call - I am going fix the spelling error and merge this tomorrow EU time unless someone objects. Thanks for all reviews so far! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rjmccall, efriedma, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Clang currently crashes when lowering a consteval list initialization

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1404 + // default value here and reset the type only as needed. + QualType RetType = Inner->getType(); if (auto *Call = dyn_cast(Inner)) Is there any possibility to have an as

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1404 + // default value here and reset the type only as needed. + QualType RetType = Inner->getType(); if (auto *Call = dyn_cast(Inner)) erichkeane wrote: > Is there any po

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

fhahn added a comment. In D122768#3700486 , @cor3ntin wrote: > In D122768#3700451 , @aeubanks > wrote: > >> in the commit message >> >> In addition, capturing an anonymous union member, >> a bitfield, or a st

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1404 + // default value here and reset the type only as needed. + QualType RetType = Inner->getType(); if (auto *Call = dyn_cast(Inner)) aaron.ballman wrote: > erichkeane wrot

[PATCH] D131195: [InstrProf][attempt 2] Add new format for -fprofile-list=

ellis created this revision. Herald added a project: All. ellis added reviewers: phosek, davidxl, thakis. ellis published this revision for review. ellis added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/test/CodeGen/p

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

efriedma added a comment. Instead of trying to dig through subexpressions of the ConstantExpr to try to infer the type we need, can we just compute it directly? QualType RetType = CE->getType(); if (CE->isGLValue()) RetType = CGM.getContext().getLValueReferenceType(RetType); Repository

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

denis-fatkulin updated this revision to Diff 450111. denis-fatkulin added a comment. clangd unit test fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131091/new/ https://reviews.llvm.org/D131091 Files: clang-tools-extra/clangd/unittests/XRef

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 450115. python3kgae added a comment. Cleanup comments and fix test after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files: clang/include/clang/Basi

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

aeubanks added a comment. In D122768#3700486 , @cor3ntin wrote: > In D122768#3700451 , @aeubanks > wrote: > >> in the commit message >> >> In addition, capturing an anonymous union member, >> a bitfield, or a

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added a comment. In D122768#3700738 , @aeubanks wrote: > In D122768#3700486 , @cor3ntin > wrote: > >> In D122768#3700451 , @aeubanks >> wrote: >> >>> in the com

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a regression introduced in 127bf44 Rep

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

beanz created this revision. beanz added reviewers: aaron.ballman, bogner, jcranmer-intel, python3kgae, pow2clk. Herald added subscribers: Anastasia, arphaman. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Semantic parameters aren't passed as

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/semantics/GroupIndex-codegen.hlsl:4 +[numthreads(1,1,1)] +void main(unsigned GI : SV_GroupIndex) { +} Does this change plan to support cases where SV_GroupIndex is inside a struct? If yes, we n

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y added a comment. > A part of my endgame is to see notes be incorporated into their parents, but > that's a long way off methinks. Regarding this, the current best approach the spec provides is using the "locationRelationShip"

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/lambda-expressions.cpp:680 + auto l = [&]() { + a; // expected-error{{cannot capture a bit-field by reference}} + b; This still should be accepted -- `a` is an `const int &`

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

cor3ntin updated this revision to Diff 450138. cor3ntin added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Better approach: revert the whole thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131202/new/ htt

[PATCH] D130516: [llvm] compression classes

ckissane added a comment. @dblaikie @MaskRay I would like it if you could all take another look. In response to @dblaikie 's comments about implementation weight I have greatly simplified the implementation, including removing extra capitalized function overloads (Compress, Decompress), and rem

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

nridge added a comment. Sorry, I'm travelling and probably won't be able to respond promptly, but my first thought here is that this doesn't seem as well motivated as `usedAsMutableReference`, since taking a pointer to an object involves using explicit syntax (`&obj`) that taking a reference do

[clang] a1a71b7 - [Clang] Fix capture of values initialized by bitfields

Author: Corentin Jabot Date: 2022-08-04T23:58:47+02:00 New Revision: a1a71b7dc97b35133425a31ede90c40529f1be9e URL: https://github.com/llvm/llvm-project/commit/a1a71b7dc97b35133425a31ede90c40529f1be9e DIFF: https://github.com/llvm/llvm-project/commit/a1a71b7dc97b35133425a31ede90c40529f1be9e.diff

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a71b7dc97b: [Clang] Fix capture of values initialized by bitfiel

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added a comment. I landed https://github.com/llvm/llvm-project/commit/a1a71b7dc97b35133425a31ede90c40529f1be9e - which reverts entierely the bitfields related changes. It should fix the build issue you are encountering. There are still pre-existing issues with the capture of bit fields

[PATCH] D130510: Missing tautological compare warnings due to unary operators

rtrieu added a comment. void foo(long x) { if ((x & 1) == 1L) return; // bad always false warning here static_assert(sizeof(int) < sizeof(long), "long is bigger than int"); static_assert((long(15) & 1) == 1L, "proof that condition can be true"); } I found this false positive case

[PATCH] D131155: [clang] Expand array expressions if the filler expression's filler is element dependent

arichardson added inline comments. Comment at: clang/test/SemaCXX/constexpr-array-init.cpp:3 + + +/// expected-no-diagnostics Nit: It might be helpful to add a comment to this test explaining what it's testing. This makes it easier to diagnose tests failures (e.

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

jyknight added a comment. I've filed a bug against Boost MPL, https://github.com/boostorg/mpl/issues/69 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/ https://reviews.llvm.org/D130058 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450153. Ariel-Burton added a comment. Added C++ tests for __ptr32. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files: clang/test/Sema/MicrosoftExtensions.c

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450157. Ariel-Burton added a comment. Recover original changes, and commit with new C++ __ptr32 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files: cl

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

ddcc created this revision. ddcc added reviewers: aaron.ballman, iana. Herald added a project: All. ddcc requested review of this revision. Herald added a project: clang. Undefined macros evaluate to zero, so when checking for a smaller value, we need to include the case when the macro is undefine

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added a comment. In D130123#3700174 , @rnk wrote: > In D130123#3698399 , @Ariel-Burton > wrote: > >> Just to make sure that we're on the same page, you'd like to see a test >> that confirms that cl

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

iana accepted this revision. iana added a comment. This revision is now accepted and ready to land. That was the only one I saw from D130800 , can someone double check me though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk accepted this revision. rnk added a comment. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] 33171df - Revert "[clang][Darwin] Always set the default C++ Standard Library to libc++"

Author: Leonard Chan Date: 2022-08-04T22:56:32Z New Revision: 33171df9cc7f6560dea7b0b162ab51ff97417468 URL: https://github.com/llvm/llvm-project/commit/33171df9cc7f6560dea7b0b162ab51ff97417468 DIFF: https://github.com/llvm/llvm-project/commit/33171df9cc7f6560dea7b0b162ab51ff97417468.diff LOG:

[PATCH] D124435: [X86] Always extend the integer parameters in callee

jyknight added a comment. In D124435#3697259 , @rjmccall wrote: > I know what you're saying, but I don't think it matches any model of how > programmers use command line flags. You're imagining that a programmer sits > down and considers all of their f

[clang] c5b36ab - AMDGPU/clang: Remove dead code

Author: Matt Arsenault Date: 2022-08-04T19:02:56-04:00 New Revision: c5b36ab1d6a667554bf369c34e51d02add039d16 URL: https://github.com/llvm/llvm-project/commit/c5b36ab1d6a667554bf369c34e51d02add039d16 DIFF: https://github.com/llvm/llvm-project/commit/c5b36ab1d6a667554bf369c34e51d02add039d16.diff

[PATCH] D131183: AMDGPU/clang: Remove dead code

arsenm closed this revision. arsenm added a comment. c5b36ab1d6a667554bf369c34e51d02add039d16 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131183/new/ https://reviews.llvm.org/D131183 __

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 created this revision. Herald added subscribers: pmatos, wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. Repository: rG LLV

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 added a comment. Work in progress -- still needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450169. ckissane edited the summary of this revision. ckissane added a comment. - fix some nits in Compression.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 File

[PATCH] D130667: feat: use compression class for: clang ast serial zstd option + prof data compression variants + zstd elf + ztsd objcopy support

ckissane updated this revision to Diff 450172. ckissane added a comment. - Merge branch 'ckissane.compression-class' of github.com:ckissane/llvm-project into ckissane.compression-class - Merge remote-tracking branch 'origin/ckissane.compression-class-simple' into ckissane.compression-class - Mer

[PATCH] D130667: feat: use compression class for: clang ast serial zstd option + prof data compression variants + zstd elf + ztsd objcopy support

ckissane updated this revision to Diff 450174. ckissane added a comment. - Merge remote-tracking branch 'origin/ckissane.compression-class-simple' into ckissane.compression-class - remove erroneous declation of operator StringRef() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450176. ckissane added a comment. - move if into switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Serialization.cpp c

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 450182. python3kgae marked an inline comment as done. python3kgae added a comment. Rename ResBinding and addResourceAnnotation to BufferResBinding and addBufferResourceAnnotation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 8a27a2f - [HLSL] Support -E option for HLSL.

Author: Xiang Li Date: 2022-08-04T16:54:19-07:00 New Revision: 8a27a2f89f83c55d352c001b3b308c35900cbdfc URL: https://github.com/llvm/llvm-project/commit/8a27a2f89f83c55d352c001b3b308c35900cbdfc DIFF: https://github.com/llvm/llvm-project/commit/8a27a2f89f83c55d352c001b3b308c35900cbdfc.diff LOG:

[PATCH] D124751: [HLSL] Support -E option for HLSL.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a27a2f89f83: [HLSL] Support -E option for HLSL. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.o

[clang] 73b62f8 - Fix parsing of comma fold-expressions as the operand of a C-style cast.

Author: Richard Smith Date: 2022-08-04T17:08:08-07:00 New Revision: 73b62f813550b602f189afc3a60b0b39ae89f16d URL: https://github.com/llvm/llvm-project/commit/73b62f813550b602f189afc3a60b0b39ae89f16d DIFF: https://github.com/llvm/llvm-project/commit/73b62f813550b602f189afc3a60b0b39ae89f16d.diff

<    1   2   3   >