efriedma added inline comments.
================ Comment at: clang/lib/Sema/SemaStmt.cpp:398 + // If dynamic rounding mode is specified in absence of FENV_ACCESS, treat it + // as setting default rounding mode. + FpPragmaStack.CurrentValue.clearConstRoundingModeOverride(); ---------------- I'm not really happy with the way this is written... like I mentioned in the other patch, keep the state transitions simple, and put the logic into the code that computes the derived properties. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130907/new/ https://reviews.llvm.org/D130907 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
