erichkeane added inline comments.
================ Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1404 + // default value here and reset the type only as needed. + QualType RetType = Inner->getType(); if (auto *Call = dyn_cast<CallExpr>(Inner)) ---------------- aaron.ballman wrote: > erichkeane wrote: > > Is there any possibility to have an assert somewhere to catch when this > > ISN'T the type we need to see later? It would be nice to figure out what > > other cases we're missing below. > Not that I've found yet, but if someone has ideas, I'm definitely open to > them because I worry about that as well. I had originally tried just > asserting that the value was valid, but a *bunch* of code calls this where > the `RetType` doesn't matter and was tripping up that assertion. Hrmph... ok. I was hoping that if we 'messed up' the return type here, AND it was useful later, it would be 'caught' by a later assert. Or was something like that (Like in the `CXXFunctionalCastExpr` case?) already asserting in a callee? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131194/new/ https://reviews.llvm.org/D131194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
