[PATCH] D130871: [C++20] [Modules] Handle initializer for Header Units

ChuanqiXu created this revision. ChuanqiXu added a reviewer: iains. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously when we add module initializer,

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

rmaz added a comment. In D130710#3688338 , @akyrtzi wrote: > In D130710#3685436 , @benlangmuir > wrote: > >> Is the functionality provided by `ORIGINAL_PCH_DIR` still useful for making >> it possible to move a P

[clang] ef9df0d - [ARM] Simplify ArchGuard predicates in arm_neon.h.

Author: David Green Date: 2022-08-01T08:20:23+01:00 New Revision: ef9df0dc000c2c294398ab6fe13533d967dc29cd URL: https://github.com/llvm/llvm-project/commit/ef9df0dc000c2c294398ab6fe13533d967dc29cd DIFF: https://github.com/llvm/llvm-project/commit/ef9df0dc000c2c294398ab6fe13533d967dc29cd.diff L

[PATCH] D130871: [C++20] [Modules] Handle initializer for Header Units

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2524-2525 for (Decl *D : getContext().getModuleInitializers(GMF)) { - assert(D->getKind() == Decl::Var && "GMF initializer decl is not a var?"); + if (isa(D)) +continue; +

[clang] 2bb7c54 - [Clang] Remove unused parameter. NFC

Author: Serge Pavlov Date: 2022-08-01T14:53:13+07:00 New Revision: 2bb7c54621f31a957302a4deb3d25b752acb07bd URL: https://github.com/llvm/llvm-project/commit/2bb7c54621f31a957302a4deb3d25b752acb07bd DIFF: https://github.com/llvm/llvm-project/commit/2bb7c54621f31a957302a4deb3d25b752acb07bd.diff

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3689157 , @thakis wrote: > Is it expected and intentional that this increases the mac deployment target > to 10.12? I wasn't aware of that - but I think it's expected since the check in RWMutex checks for the C++ stan

[clang] 834a878 - [C++2b] [Modules] Handle HaveModules with C++2b

Author: Chuanqi Xu Date: 2022-08-01T16:06:34+08:00 New Revision: 834a878367f549c58313200ce2c3a0da1a29d842 URL: https://github.com/llvm/llvm-project/commit/834a878367f549c58313200ce2c3a0da1a29d842 DIFF: https://github.com/llvm/llvm-project/commit/834a878367f549c58313200ce2c3a0da1a29d842.diff LO

[PATCH] D130689: [LLVM] Update C++ standard to 17

nikic added a comment. In D130689#3690258 , @thieta wrote: > In D130689#3689157 , @thakis wrote: > >> Is it expected and intentional that this increases the mac deployment target >> to 10.12? > > I wasn't aware o

[PATCH] D130863: [clangd] Make git ignore index directories

kadircet added a comment. I am not sure if clangd is the right tool the create those `.gitignore` files, e.g. what if the project's VCS isn't git? I believe the right thing to do is for projects that want to make use of such tools to ignore the relevant directory explicitly (e.g. `.cache). Re

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3690274 , @nikic wrote: > Given > https://github.com/llvm/llvm-project/blob/2bb7c54621f31a957302a4deb3d25b752acb07bd/llvm/include/llvm/Support/RWMutex.h#L22-L27, > it seems like this is supposed to be supported. This i

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

kadircet added a comment. sorry this has slipped through. since we're going to backport it, let's make it minimal and always point to in-progress release notes (so sorry for reverting back to original version of the patch). i think having clangd point to versioned docs would be much nicer, but

[clang] 892e6e2 - [clang] Update Clang version from 15 to 16 in scan-build.1.

Author: Frederic Cambus Date: 2022-08-01T10:34:55+02:00 New Revision: 892e6e2200d90e1b3140dc7feda6f46318688441 URL: https://github.com/llvm/llvm-project/commit/892e6e2200d90e1b3140dc7feda6f46318688441 DIFF: https://github.com/llvm/llvm-project/commit/892e6e2200d90e1b3140dc7feda6f46318688441.dif

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

phosek accepted this revision. phosek added a comment. LGTM we should consider removing `llvm-config` from other subprojects as a follow up cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130735/new/ https://reviews.llvm.org/D130735 __

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

kadircet added a comment. > Is my invocation correct or is this case handled by clangd and not clang? yeah your invocation is correct. this is because clang's printer does a prefix based filtering (while clangd does a fuzzy match) https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/Co

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

melver created this revision. Herald added a subscriber: ormris. Herald added a project: All. melver requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Introduces the frontend flag -fexperimental-sanitize-metadata=, which enables Sanit

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 448965. carlosgalvezp added a comment. - Display type information in the diagnostic. - Rebase onto latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. @njames93 I've updated the patch with extra type information, let me know if you think it's good enough! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 __

[PATCH] D130889: [llvm] Introduce a pass plugin registry and loader

viroulep created this revision. viroulep added reviewers: w2yehia, mehdi_amini, pcc. Herald added subscribers: ormris, steven_wu, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: MaskRay. Herald added a project: All. viroulep requested review of this revision. Herald added subscrib

[clang] d90b7bf - Add support for lowering simd if clause to LLVM IR

Author: Dominik Adamski Date: 2022-08-01T04:43:32-05:00 New Revision: d90b7bf2c53d0315a13a81904862929252bb6824 URL: https://github.com/llvm/llvm-project/commit/d90b7bf2c53d0315a13a81904862929252bb6824 DIFF: https://github.com/llvm/llvm-project/commit/d90b7bf2c53d0315a13a81904862929252bb6824.dif

[PATCH] D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. domada marked an inline comment as done. Closed by commit rGd90b7bf2c53d: Add support for lowering simd if clause to LLVM IR (authored by domada). Herald added a projec

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

kadircet added a comment. I agree with Sam on this one, especially on big files it just floods and hides non-stylistic diagnostics (you even hit max diagnostics exceeded errors). I believe unless someone takes the extra mile to fix all the value types in LLVM to be const-correct, this is harmfu

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 448977. Purva-Chaudhari added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/test/I

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

asb added a comment. I don't feel very qualified on the current state of strict FP, but I've left a couple of minor comments inline. I'm happy to trust your knowledge the state of strictfp and the patch looks good to me otherwise. Comment at: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

whisperity accepted this revision. whisperity added a comment. Alright, I think we should have this in and let C++17 things to be future work. Please see the inline comment, but otherwise this should be good enough. Can always improve in a future version. 😉 LLVM 15 has branched off, so this sho

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

aaron.ballman added a comment. In D54943#3687827 , @JonasToth wrote: > In D54943#3681527 , @sammccall wrote: > >> This check is enabled by default in LLVM (`Checks: misc-*` in >> `llvm-project/.clang-tidy`) >> >> T

[PATCH] D130826: [clang-tools-extra] Fixed a number of typos

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130826/new/ https://reviews.llvm.org/D130826 __

[PATCH] D130826: [clang-tools-extra] Fixed a number of typos

kadircet added a comment. also LMK if I should land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130826/new/ https://reviews.llvm.org/D130826 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D130701: [clang-tidy] Rename a local cmake variables to match the new tool name. NFC.

mstorsjo added a comment. Ping @sammccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130701/new/ https://reviews.llvm.org/D130701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

iliya-diyachkov added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130766/new/ https://reviews.llvm.org/D130766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For c++ static constexpr m = 10; static_assert(m == 11); the output is befo

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16656 && !isa(InnerCond)) { + Diag(StaticAssertLoc, diag::err_static_assert_requirement_failed) Oops, this needs to go. Repository: rG LLVM Github M

[PATCH] D130826: [clang-tools-extra] Fixed a number of typos

GabrielRavier added a comment. Well I'm pretty sure I don't have commit rights to LLVM and it seems landing means to push the revision onto main, so that would be nice, yes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130826/new/ https://reviews.

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:555 if (BuiltPreamble) { -vlog("Built preamble of size {0} for file {1} version {2} in {3} seconds", +log("Built preamble of size {0} for file {1} version {2} in {3} seconds", Bui

[clang-tools-extra] 6b2fed3 - [clangd] Upgrade vlog() to log() for preamble build stats

Author: Adam Czachorowski Date: 2022-08-01T15:08:21+02:00 New Revision: 6b2fed3ab4193cfb50c4e60fb4cd19c7e6b3603f URL: https://github.com/llvm/llvm-project/commit/6b2fed3ab4193cfb50c4e60fb4cd19c7e6b3603f DIFF: https://github.com/llvm/llvm-project/commit/6b2fed3ab4193cfb50c4e60fb4cd19c7e6b3603f.d

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b2fed3ab419: [clangd] Upgrade vlog() to log() for preamble build stats (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13540 ED->getValueRange(Max, Min); +--Max; I don't think this is the correct answer. Even though the other use of this seems to 'work', `getValueRange` is still retu

[PATCH] D130863: [clangd] Make git ignore index directories

sums added a comment. In D130863#3690275 , @kadircet wrote: > I am not sure if clangd is the right tool the create those `.gitignore` > files, e.g. what if the project's VCS isn't git? I believe the right thing to > do is for projects that want to make

[clang-tools-extra] 0ed2bd9 - [clang-tools-extra] Fixed a number of typos

Author: Gabriel Ravier Date: 2022-08-01T15:32:25+02:00 New Revision: 0ed2bd9311fd54f0b414549b96a2cd4036ef0945 URL: https://github.com/llvm/llvm-project/commit/0ed2bd9311fd54f0b414549b96a2cd4036ef0945 DIFF: https://github.com/llvm/llvm-project/commit/0ed2bd9311fd54f0b414549b96a2cd4036ef0945.diff

[PATCH] D130826: [clang-tools-extra] Fixed a number of typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ed2bd9311fd: [clang-tools-extra] Fixed a number of typos (authored by GabrielRavier, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D130864: [NFC] Introduce ASTContext::isInSameModule()

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6217 + // If one is not module, they must not be in the same module. + if (!X != !Y) +return false; Please find another way to write this... this is about the most jarring way to co

[clang] b978fa2 - OffloadBundler.cpp - fix Wdocumentation warnings. NFC.

Author: Simon Pilgrim Date: 2022-08-01T15:24:47+01:00 New Revision: b978fa2844391bd9c12eb9b9b002daebf51bf1ca URL: https://github.com/llvm/llvm-project/commit/b978fa2844391bd9c12eb9b9b002daebf51bf1ca DIFF: https://github.com/llvm/llvm-project/commit/b978fa2844391bd9c12eb9b9b002daebf51bf1ca.diff

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

beanz updated this revision to Diff 449014. beanz added a comment. Updates based on PR feedback. Thanks @aaron.ballman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130019/new/ https://reviews.llvm.org/D130019 Files: clang/lib/CodeGen/CGDeclCXX

[clang-tools-extra] cb5d0b4 - AST.h - fix Wdocumentation warnings. NFC.

Author: Simon Pilgrim Date: 2022-08-01T15:38:06+01:00 New Revision: cb5d0b41baf2f137f377a8d03481d6a5574a31ec URL: https://github.com/llvm/llvm-project/commit/cb5d0b41baf2f137f377a8d03481d6a5574a31ec DIFF: https://github.com/llvm/llvm-project/commit/cb5d0b41baf2f137f377a8d03481d6a5574a31ec.diff

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

aaron.ballman added a comment. Thanks for working on this! I think the same is true for `SourceManager::isInFileID()` as well, right? (Or any other place that calls `getSLocEntry()` and doesn't check whether the entry is invalid, which also seems to happen a fair amount in SourceManager.cpp.)

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added a comment. That sounds reasonable to me, I confirmed that MSVC really only lets you apply these attributes directly to pointer types and to typedefs. Can you add a test for the other most common type sugar node, the template parameter? It looks like this: template void f(T __ptr

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

Ericson2314 added a comment. Should I wait for anyone else / do something like announcing this on discourse? It looks like the only other use case is libclc, which sadly only supports the old way so we will need to do another deprecation cycle I'd think for it. Repository: rG LLVM Github Mon

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

reames added a comment. I'm not fluent on strict FP, so let me summarize my understanding. This is mostly so you can easily correct me if one my assumptions is wrong. - Under strict FP, clang will emit constrained fp intrinsics instead of normal floating point ops. - To my knowledge, clang wil

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

martong added a comment. In D130372#3683275 , @ASDenysPetrov wrote: > Now I'm working on the next patch and you'll see a motivation soon. Thanks for the update! Looks good, but I am still waiting with my formal approve to understand the motivation.

[PATCH] D130907: [Clang] Use pragma FENV_ROUND to reset rounding mode settings.

sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, kpn. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Now starting from the first use of `pragma FENV_ROUND` rounding mode becomes user-defined and there is

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc created this revision. Herald added a project: All. inclyc edited the summary of this revision. inclyc updated this revision to Diff 449023. inclyc added a comment. inclyc added reviewers: mizvekov, rsmith, aaron.ballman. inclyc added a project: clang. inclyc added a subscriber: clang. incly

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added inline comments. Comment at: clang/test/Sema/format-strings-scanf.c:235 scanf(0 ? "%s" : "%d", i); // no warning - scanf(1 ? "%s" : "%d", i); // expected-warning{{format specifies type 'char *'}} + scanf(1 ? "%s" : "%d", i); // expected-warning{{format specifie

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 449033. dgoldman added a comment. Fix broken test and swap to AST.tuPath() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper added a comment. In D130311#3691029 , @reames wrote: > I'm not fluent on strict FP, so let me summarize my understanding. This is > mostly so you can easily correct me if one my assumptions is wrong. > > - Under strict FP, clang will emit c

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130019/new/ https://reviews.llvm.org/D130019

[clang] 5dbb92d - [HLSL] CodeGen HLSL Resource annotations

Author: Chris Bieneman Date: 2022-08-01T11:19:43-05:00 New Revision: 5dbb92d8cdf751d5960225e874c27d19597fa65e URL: https://github.com/llvm/llvm-project/commit/5dbb92d8cdf751d5960225e874c27d19597fa65e DIFF: https://github.com/llvm/llvm-project/commit/5dbb92d8cdf751d5960225e874c27d19597fa65e.diff

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dbb92d8cdf7: [HLSL] CodeGen HLSL Resource annotations (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added a comment. Hi all, I just wanted to check in on this again and see if any more feedback or progress could be made. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 _

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 449046. njames93 added a comment. Revert to first version, just so we can sort out the 15.X branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 Files: clang-to

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 449048. njames93 added a comment. Rebase and Ping?? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 449050. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clan

[clang-tools-extra] 37047a2 - misc-const-correctness: fix the link to readability-isolate-declaration

Author: Sylvestre Ledru Date: 2022-08-01T18:52:53+02:00 New Revision: 37047a26731a6731c949682e159fe40786e6d711 URL: https://github.com/llvm/llvm-project/commit/37047a26731a6731c949682e159fe40786e6d711 DIFF: https://github.com/llvm/llvm-project/commit/37047a26731a6731c949682e159fe40786e6d711.dif

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 449059. Purva-Chaudhari added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/test/I

[PATCH] D130827: [clang] Fixed a number of typos

aaron.ballman added a comment. Thanks for the typo fixes! All the changes look correct to me, so LGTM. Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? Comment at: clang/lib/Headers/opencl-c.h:17856

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang-tools-extra] 556c422 - clang-tidy doc: fix some typos

Author: Sylvestre Ledru Date: 2022-08-01T18:57:36+02:00 New Revision: 556c422de1c3b0623e83c85b36a43dd743660fb1 URL: https://github.com/llvm/llvm-project/commit/556c422de1c3b0623e83c85b36a43dd743660fb1 DIFF: https://github.com/llvm/llvm-project/commit/556c422de1c3b0623e83c85b36a43dd743660fb1.dif

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis added a comment. In D130807#3688798 , @paulkirth wrote: > Do you expect the difference between `noprofile` and `omitprofile` to be > confusing to users? I can certainly see how users could be confused by what > the difference is between `noprofile

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added a comment. > Do you need someone to land this on your behalf? Yes. > If so, what name and email address would you like used for patch attribution? `Gabriel Ravier`, `gabrav...@gmail.com` (By the way, is there any way to make this information part of my Phabricator account

[clang] 5674a3c - Fixed a number of typos

Author: Gabriel Ravier Date: 2022-08-01T13:13:18-04:00 New Revision: 5674a3c88088e668b684326c2194a6282e8270ff URL: https://github.com/llvm/llvm-project/commit/5674a3c88088e668b684326c2194a6282e8270ff DIFF: https://github.com/llvm/llvm-project/commit/5674a3c88088e668b684326c2194a6282e8270ff.diff

[PATCH] D130827: [clang] Fixed a number of typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5674a3c88088: Fixed a number of typos (authored by GabrielRavier, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130827: [clang] Fixed a number of typos

aaron.ballman added a comment. In D130827#3691371 , @GabrielRavier wrote: >> Do you need someone to land this on your behalf? > > I assume so since landing seems to mean pushing the commit to the repo which > I'm pretty sure I don't have the rights to d

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 449066. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Herald added subscribers: sstefan1, Anastasia. Herald added a reviewer: jdoerfert. Rely on the CXXScopeSpec to detect more accurately if we are parsing a constructor

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/Support/Compression.cpp:30-32 +ZStdCompressionAlgorithm +*llvm::compression::ZStdCompressionAlgorithm::Instance = +new ZStdCompressionAlgorithm(); dblaikie wrote: > leonardchan wrote: > > Perhaps fo

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3381 &SS) && isConstructorDeclarator(/*Unqualified*/ false)) goto DoneWithDeclSpec; The only remaining failure is in `test/Pars

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

paulkirth added a comment. > I agree that `omitprofile` probably doesn't communicate the correct meaning > very well. I like `nodirectprofile` because it hopefully implies that > indirect profiles are allowed. I'm wondering if anyone else has suggestions. > > Is there any precedent for renamin

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D130058#3689053 , @thakis wrote: > In D130058#3687868 , @aaron.ballman > wrote: > >> In D130058#3687680 , @thakis wrote: >> >>> Hello, t

[PATCH] D126743: [RISCV][Clang] Add tests for all supported policy functions. (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e51917b39cd: [RISCV][Clang] Add tests for all supported policy functions. (NFC) (authored by khchen). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus, ributzka. Herald added a subscriber: mgorny. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently ExtractAPI only emits availab

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. @tapaswenipathak, ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. In D126745#3678776 , @nlopes wrote: > While at it, could you switch those UndefValue with PoisonValue if possible? > Thank you! I'm not sure UndefValue will work because the backend would only check isUndef() to generate correc

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

craig.topper added a comment. In D126745#3691528 , @khchen wrote: > In D126745#3678776 , @nlopes wrote: > >> While at it, could you switch those UndefValue with PoisonValue if possible? >> Thank you! > > I'm not

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

zixuw added a comment. Thanks Daniel! Comment at: clang/test/ExtractAPI/availability.c:16 +//--- input.h +/// Documentation for a. +void a(void); Do we care about doc comments for this particular test? The testing convention for all the ExtractAPI tests is prob

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

reames added a comment. In D130311#3691146 , @craig.topper wrote: > In D130311#3691029 , @reames wrote: > >> I'm not fluent on strict FP, so let me summarize my understanding. This is >> mostly so you can easil

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:286 + // StrictFP support for vectors is incomplete. + if (ISAInfo->hasExtension("zve32x")) +HasStrictFP = false; reames wrote: > craig.topper wrote: > > reames wrote: > > > a

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

reames added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:286 + // StrictFP support for vectors is incomplete. + if (ISAInfo->hasExtension("zve32x")) +HasStrictFP = false; craig.topper wrote: > reames wrote: > > craig.topper wrote: > > > r

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. In D126745#3691544 , @craig.topper wrote: > In D126745#3691528 , @khchen wrote: > >> In D126745#3678776 , @nlopes wrote: >> >>> While at it, could

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 61ef0ab - [clangd] Add decl/def support to SymbolDetails

Author: David Goldman Date: 2022-08-01T14:42:19-04:00 New Revision: 61ef0ab70196bfdc4c301e12384aa91938b15cc4 URL: https://github.com/llvm/llvm-project/commit/61ef0ab70196bfdc4c301e12384aa91938b15cc4 DIFF: https://github.com/llvm/llvm-project/commit/61ef0ab70196bfdc4c301e12384aa91938b15cc4.diff

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG61ef0ab70196: [clangd] Add decl/def support to SymbolDetails (authored by dgoldman). Repository: rG LLVM Github Monorep

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. oops.. all tests need to updated and include all intrinsic IR tests... Is there any benefit to switch UndefValue to PoisonValue? maybe those changed should be in other follow-up patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

aaron.ballman added a comment. Thanks for catching this! As far as these changes go, they're pretty reasonable, but don't seem like they hit all of the problem areas. There's 20+ occurrences of `#if __STDC_VERSION__` and 10+ of `#if __cplusplus` in lib/Headers; shouldn't they all be updated?

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

NoQ added a comment. Uh-oh sorry! I have a couple more questions and then we can probably land. Comment at: clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp:24 + Finder->addMatcher( + objcMessageExpr(hasSelector("setDateFormat:"), + hasArgum

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

aaron.ballman added a comment. Thank you for working on this! This should also include test coverage (hmmm, we don't have a reasonable way to lit test performance regressions though so perhaps we just need to ensure there's at least one test that would normally have been unreasonably slow?)

[PATCH] D130863: [clangd] Make git ignore index directories

sammccall added a comment. My 2c, though I'm away with kids right now so will leave to @kadircet to make a call Given that this is fully contained (logically and physically) within clangd's index directory, this seems elegant and harmless to me. (At first i thought it was modifying project-lev

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added a comment. Ah my bad didn't realize you hadn't accepted this, was there anything else you wanted me to change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 _

[clang] 5fd03b0 - [Driver] Re-run lld with --reproduce when it crashes

Author: Alex Brachet Date: 2022-08-01T20:01:01Z New Revision: 5fd03b00ee029b4cc958ae8e6c970a6123bd12f6 URL: https://github.com/llvm/llvm-project/commit/5fd03b00ee029b4cc958ae8e6c970a6123bd12f6 DIFF: https://github.com/llvm/llvm-project/commit/5fd03b00ee029b4cc958ae8e6c970a6123bd12f6.diff LOG:

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fd03b00ee02: [Driver] Re-run lld with --reproduce when it crashes (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHA

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

MaskRay added a comment. LGTM (Note: I think 2.5h from approval to push was too short for others to react on this patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120175/new/ https://reviews.llvm.org/D120175

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon created this revision. OfekShilon added reviewers: xur, davidxl. Herald added a reviewer: aaron.ballman. Herald added a project: All. OfekShilon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following this

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

benlangmuir created this revision. benlangmuir added reviewers: bnbarham, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. It's an accident that we started return asbol

  1   2   >