[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. @dblaikie, could you please take a look at this and/or D113741 ? Do you see any ways to proceed? Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8*

[PATCH] D128604: [RISCV] Support Zbpbo extension v0.9.11

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:471 + Sched<[WriteCMix, ReadCMix, ReadCMix, ReadCMix]>; def FSR : RVBTernaryR<0b10, 0b101, OPC_OP, "fsr", "$rd, $rs1, $rs3, $rs2">, Sched<[WriteFSReg, ReadFSReg, ReadFSReg, Re

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

jansvoboda11 added a comment. This looks pretty nice. My only concern is the ad-hoc command line parsing. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:55 + getCommandLine(llvm::function_ref< + Expected(const ModuleID &)>

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. In D95588#3622052 , @sunshaoce wrote: > Hello @Jim! We are developing the P extension, are you still maintaining this > patch? Or would you mind co-development together? Yes, I am still on developing the P extension. But it seems spe

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. @kees are you ok with current state? Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + // C11

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd85d9aeef9b: Go-to-type on smart_ptr now also shows Foo (authored by tom-anders, committed by sammccall). Repository: rG LLVM Github Monorep

[clang-tools-extra] cd85d9a - Go-to-type on smart_ptr now also shows Foo

Author: Tom Praschan Date: 2022-07-11T12:13:47+02:00 New Revision: cd85d9aeef9b7e3d6784f5d0be393b463ccc5c5c URL: https://github.com/llvm/llvm-project/commit/cd85d9aeef9b7e3d6784f5d0be393b463ccc5c5c DIFF: https://github.com/llvm/llvm-project/commit/cd85d9aeef9b7e3d6784f5d0be393b463ccc5c5c.diff

[clang] 9f57b65 - [clangd] Include "final" when printing class declaration

Author: Tom Praschan Date: 2022-07-11T12:20:23+02:00 New Revision: 9f57b65a272817752aa00e2fb94154e6eed1d0ec URL: https://github.com/llvm/llvm-project/commit/9f57b65a272817752aa00e2fb94154e6eed1d0ec DIFF: https://github.com/llvm/llvm-project/commit/9f57b65a272817752aa00e2fb94154e6eed1d0ec.diff

[PATCH] D128202: [clangd] Include "final" when printing class declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f57b65a2728: [clangd] Include "final" when printing class declaration (authored by tom-anders, committed by sammccall). Repository: rG LLVM Githu

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

sammccall added a comment. In D128826#3641093 , @tom-anders wrote: > @sammccall I think you can merge this for me now (and also > https://reviews.llvm.org/D128202) Done, sorry for the delay. FWIW I think you should be able to get commit access

[PATCH] D129476: [AArch64][SVE] Prefer SIMD&FP variant of clast[ab]

c-rhodes created this revision. c-rhodes added reviewers: paulwalker-arm, bsmith, peterwaller-arm, DavidTruby. Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. c-rhodes requested review of this revision. Herald add

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129476: [AArch64][SVE] Prefer SIMD&FP variant of clast[ab]

c-rhodes updated this revision to Diff 443594. c-rhodes added a comment. Add full patch context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129476/new/ https://reviews.llvm.org/D129476 Files: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_clasta.c clang/test/CodeGen/aarch64-

[PATCH] D126586: [InstrProf][WIP] Implement boolean counters in coverage

gulfem added a comment. @davidxl and @vsk, This is a WIP prototype implementation, and I would love to hear your early feedback on using 1-byte counters for coverage idea if possible. I'll continue extending the prototype, but that would be great to learn if there is anything fundamentally wrong

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

aaron.ballman added a comment. Thank you for looking into this! I happened to run into this same issue with `#pragma float_control` not behaving the way I'd expect. (FWIW, we also ran into an interesting issue where the floating point options were pushed but never popped in the TU were delayed

[PATCH] D128535: [analyzer] Improve loads from reinterpret-cast fields

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM (given that you remove the vague and disturbing FIXME comments). Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2014-2017 + // FIXME: This is a hack, and d

[PATCH] D128411: [syntax] Introduce a BaseToken class.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:24 #include "clang/Basic/TokenKinds.h" #include "clang/Lex/Token.h" I think Token and TokenKinds are also no longer needed? Comment at: clang/include/cl

[PATCH] D125625: Implementation of '#pragma STDC FENV_ROUND'

sepavloff updated this revision to Diff 443606. sepavloff added a comment. Rebased and addressed reviever's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125625/new/ https://reviews.llvm.org/D125625 Files: clang/include/clang/Basic/Diag

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw updated this revision to Diff 443605. sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128712/new/ https://reviews.llvm.org/D128712 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnot

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3841 +/// matches if ObjCMessageExpr's callee declaration matches +/// NoQ wrote: > Nitpick carryover: needs capital letter and `.` Don't forget to regen the docs whe

[PATCH] D128713: [clang-format] Handle Verilog user-defined primitives

sstwcw updated this revision to Diff 443607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128713/new/ https://reviews.llvm.org/D128713 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/UnwrappedLinePar

[PATCH] D128714: [clang-format] Handle Verilog case statements

sstwcw updated this revision to Diff 443608. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128714/new/ https://reviews.llvm.org/D128714 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/Format.cpp clang/lib/Format/FormatToken.h

[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

balazske updated this revision to Diff 443609. balazske marked 2 inline comments as done. balazske added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129353/new/ https://reviews.llvm.org/D129353 Files: clang-t

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

martong added a comment. Thanks Vince for the patch! I think the implementation is correct. But I am worried that it might do sub-optimal computations on the string literals. I mean, getting the length would require O(N) steps each time, and that could be problematic with long literals, especia

[PATCH] D128709: [clang-format] Handle Verilog attributes

sstwcw updated this revision to Diff 443611. sstwcw added a comment. - don't check peeked token for null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128709/new/ https://reviews.llvm.org/D128709 Files: clang/lib/Format/TokenAnnotator.cpp clan

[PATCH] D125625: Implementation of '#pragma STDC FENV_ROUND'

sepavloff added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:488 + } + if (NewRM != llvm::RoundingMode::Dynamic) +Builder.CreateIntrinsic( aaron.ballman wrote: > I was imagining that if the new rounding mode is dynamic, we still need to > rese

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129435/new/ https://reviews.llvm.org/D129435 __

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 443622. psoni2628 added a comment. - Rebase, ensuring that build bot failures are gone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbu

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 443630. pscoro added a comment. fixed lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Tar

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov updated this revision to Diff 443631. psamolysov added a comment. @aeubanks Thank you for the great explanation. I've applied your suggestion and re-uploaded the patch. The test `unused-nonnull.ll` has been fixed with keeping the `readnone` attribute. Repository: rG LLVM Github Mo

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers added a comment. Thanks @martong , I understand. I'll make the changes and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/ https://reviews.llvm.org/D129269 ___ cfe-co

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

sunshaoce added a comment. In D95588#3641900 , @Jim wrote: > In D95588#3622052 , @sunshaoce wrote: > >> Hello @Jim! We are developing the P extension, are you still maintaining >> this patch? Or would you mind co-d

[clang] f54ca1f - [NFC][Coroutines] Add regression test for heap allocation elision optimization

Author: Dawid Jurczak Date: 2022-07-11T16:41:05+02:00 New Revision: f54ca1f632646ee9a2a052a28e93ffb0bcc4340d URL: https://github.com/llvm/llvm-project/commit/f54ca1f632646ee9a2a052a28e93ffb0bcc4340d DIFF: https://github.com/llvm/llvm-project/commit/f54ca1f632646ee9a2a052a28e93ffb0bcc4340d.diff

[PATCH] D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization

This revision was automatically updated to reflect the committed changes. Closed by commit rGf54ca1f63264: [NFC][Coroutines] Add regression test for heap allocation elision optimization (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D129488: [Sema] Fix evaluation context of immediate functions in default arguments

ilya-biryukov created this revision. ilya-biryukov added a reviewer: jyknight. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. They must be evaluated in the context where default argument is actually used during a call, not in a paramete

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

yaxunl added a comment. need a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129435/new/ https://reviews.llvm.org/D129435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

jhuber6 added a comment. In D129435#3642450 , @yaxunl wrote: > need a test There's a test `clang/test/Driver/openmp-offload-gpu-new.c` already making sure that the following works, so this patch should maintain the same functionality we had before.

[PATCH] D128048: Add a new clang option "-ftime-trace="

jamieschmeiser accepted this revision. jamieschmeiser added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 _

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

hctim created this revision. hctim added a reviewer: eugenis. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang misses attaching sanitizer metadata for external globals. Repository: rG LLVM Github

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Code looks good to me. It's hard to be sure whether it works without running a bunch of hip test cases through it, have you already done so? If it doesn't work out of the box

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 443654. vaibhav.y added a comment. Discard most likely culprit in test code causing unexpected crash. @aaron.ballman I was unable to reproduce the issue on my end using the buildbot instructions and ASAN, UBSAN. Is it possible for you to trigger a pre-merg

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3642558 , @JonChesterfield wrote: > Code looks good to me. It's hard to be sure whether it works without running > a bunch of hip test cases through it, have you already done so? If it doesn't > work out of the box i

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers updated this revision to Diff 443658. vabridgers edited the summary of this revision. vabridgers added a comment. update per comments from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/ https://reviews.llvm.org/D12926

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov updated this revision to Diff 443661. psamolysov added a comment. [Pipelines] Fix the Clang :: CodeGenCoroutines/coro-elide.cpp Now, the `%_Z5task1v.Frame` type doesn't contain a field of the `%_Z5task0v.Frame` one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. I'd tried moving func-attrs after the function simplification pipeline and perf-wise on internal benchmarks it looks fine, but it causes some compile time regressions: https://llvm-compile-time-tracker.com/compare.php?from=d3dd6e57fe84e90cadcdc78fa71d632f6573f156&to=59

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. (and we should definitely separate that out into its own patch first) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830 ___ cfe-commits

[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor nits. Comment at: clang-tools-extra/clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:80-81 + auto BadNonTemplateSpecializationDecl = +

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov marked 10 inline comments as done. ASDenysPetrov added a comment. @martong Thank you for your patience. I started moving to a bit another direction that we can improving it iteratively. Just spoiling, in my latest solution a single symbol will be associated to many classes. Here ar

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. In D109701#3642561 , @vaibhav.y wrote: > Discard most likely culprit in test code causing unexpected crash. > > @aaron.ballman I was unable to reproduce the issue on my end using the > buildbot instructions and ASAN, UBSAN.

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. >> I have suspicions that it was the `SarifResult &&` type in the test so I >> changed it to a `const SarifResult &`. >> >> I've tried running it on a RHEL 7, Darwin on my end. > > If you think you've got it fixed, I think the best we can do is to re-commit > and watch

[clang] 69fcf4f - Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

Author: Vaibhav Yenamandra Date: 2022-07-11T12:18:13-04:00 New Revision: 69fcf4fd5a014b763061f13b5c4434d49c42c35a URL: https://github.com/llvm/llvm-project/commit/69fcf4fd5a014b763061f13b5c4434d49c42c35a DIFF: https://github.com/llvm/llvm-project/commit/69fcf4fd5a014b763061f13b5c4434d49c42c35a.

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69fcf4fd5a01: Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface (authored by vaibhav.y, committed by aaron.ballman). Repository

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, NoQ, Charusso. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a pr

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

adamcz created this revision. adamcz added a reviewer: ilya-biryukov. Herald added a project: All. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code would assume that SubstExpr() cannot fail on concept specialization. This is

[clang] c8a28ae - Revert "Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface"

Author: Aaron Ballman Date: 2022-07-11T12:28:31-04:00 New Revision: c8a28ae214c08c8447a4eb42418585b2b3eef6fb URL: https://github.com/llvm/llvm-project/commit/c8a28ae214c08c8447a4eb42418585b2b3eef6fb DIFF: https://github.com/llvm/llvm-project/commit/c8a28ae214c08c8447a4eb42418585b2b3eef6fb.diff

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good, thank you for following up @jolanta.jensen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129373/new/ https://reviews.llvm

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Unfortunately, it still seems to be causing failures (I had to revert again): https://lab.llvm.org/buildbot/#/builders/91/builds/11840 It looks to be the same failure as before

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. This breaks TestDataFormatterLibcxxSpan.py on GreenDragon: Undefined symbols for architecture x86_64: "__ZGIW10std_config", referenced from: __GLOBAL__sub_I_main.cpp in main.o "__ZGIW4span", referenced from: __GLOBAL__sub_I_main.cpp in main.

Re: [clang] c8a28ae - Revert "Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface"

On Mon, Jul 11, 2022 at 12:28 PM Aaron Ballman via cfe-commits wrote: > > > Author: Aaron Ballman > Date: 2022-07-11T12:28:31-04:00 > New Revision: c8a28ae214c08c8447a4eb42418585b2b3eef6fb > > URL: > https://github.com/llvm/llvm-project/commit/c8a28ae214c08c8447a4eb42418585b2b3eef6fb > DIFF: > h

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3642762 , @JDevlieghere wrote: > This breaks TestDataFormatterLibcxxSpan.py on GreenDragon: > > Undefined symbols for architecture x86_64: > "__ZGIW10std_config", referenced from: > __GLOBAL__sub_I_main.cpp

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3642777 , @iains wrote: > In D126189#3642762 , @JDevlieghere > wrote: > >> This breaks TestDataFormatterLibcxxSpan.py on GreenDragon: >> >> Undefined symbols for archite

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3642777 , @iains wrote: > In D126189#3642762 , @JDevlieghere > wrote: > >> This breaks TestDataFormatterLibcxxSpan.py on GreenDragon: >> >> Undefined symbols for architecture x

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. In D109701#3642748 , @aaron.ballman wrote: > Unfortunately, it still seems to be causing failures (I had to revert again): > > https://lab.llvm.org/buildbot/#/builders/91/builds/11840 > > It looks to be the same failure as befo

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ilya-biryukov added a comment. A few NITs from my side, hopefully they can improve things a bit. Comment at: clang/include/clang/AST/ASTContext.h:2676 + /// Determine whether two 'requires' expressions are similar enough. + /// Use of 'requires' isn't mandatory, works with

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3642779 , @JDevlieghere wrote: > In D126189#3642777 , @iains wrote: > >> In D126189#3642762 , @JDevlieghere >> wrote: >> >>> This break

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. @manas ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Need to update RISCVTargetLowering::decomposeMulByConstant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 _

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129435/new/ https://reviews.llvm.org/D129435 ___ cfe-commits mailing list cfe-commits@li

[clang] ac892c7 - [OMPIRBuilder] Add support for simdlen clause

Author: Prabhdeep Singh Soni Date: 2022-07-11T13:29:06-04:00 New Revision: ac892c70a456a443ef5d52ec886b4b6b0fae9244 URL: https://github.com/llvm/llvm-project/commit/ac892c70a456a443ef5d52ec886b4b6b0fae9244 DIFF: https://github.com/llvm/llvm-project/commit/ac892c70a456a443ef5d52ec886b4b6b0fae924

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

yaxunl added a comment. In D128914#3642567 , @jhuber6 wrote: > In D128914#3642558 , > @JonChesterfield wrote: > >> Code looks good to me. It's hard to be sure whether it works without running >> a bunch of hip t

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac892c70a456: [OMPIRBuilder] Add support for simdlen clause (authored by psoni2628, committed by arnamoy10). Repository: rG LLVM Github Monorepo

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis created this revision. Herald added a project: All. ellis retitled this revision from "[instrprof] Allow compiler generated functions in SCL" to "[InstrProf] Allow compiler generated functions in SCL". ellis edited the summary of this revision. ellis added reviewers: kyulee, phosek. ellis pu

[PATCH] D129456: [lldb] Add image dump pcm-info command

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with a comment Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( Left over ? Repos

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443687. ckissane added a comment. clean a space and make accurate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione added a reviewer: Michael137. kastiglione added inline comments. Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( mib wrote: > Left over ? yep thanks! Repository: rG LLVM G

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > MaskRay wrote: > > This needs a change in lld/test/C

[PATCH] D88299: [clang-format] Add MacroUnexpander.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a project: All. OK, I think we've reached the point where: - the impact is very clear, this solves a whole class of clang-format's biggest problems - the idea clearly works

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3642820 , @iains wrote: > JFTR, I did not get any notification from green dragon (which is odd, AFAIR > it's sent email before) or I would have looked right away - kicked off a > build will take a look as soon a

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. In D109701#3642786 , @vaibhav.y wrote: > In D109701#3642748 , @aaron.ballman > wrote: > >> Unfortunately, it still seems to be causing failures (I had to revert again): >> >> https:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. As I mentioned, the proper approach is to add zstd functionality along with the CMake change, instead of adding CMake to all llvm-project components without a way to test them. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABL

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3642992 , @JDevlieghere wrote: > In D126189#3642820 , @iains wrote: > >> JFTR, I did not get any notification from green dragon (which is odd, AFAIR >> it's sent email before) o

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > Please check for lifetime markers, I assume case 2 will have a new one > Please check for lifetime markers, I assume case 2

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) + F->addFnAttr(llvm::Attribute::NoProfile); ---

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

ahatanak created this revision. ahatanak added reviewers: arphaman, benlangmuir. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This patch teaches `getCursorPlatformAvailabilityForDecl` to look for availability attributes on the containin

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3643001 , @iains wrote: > In D126189#3642992 , @JDevlieghere > wrote: > >> In D126189#3642820 , @iains wrote: >> >>> JFTR, I did

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) + F->addFnAttr(llvm::Attribute::NoProfile);

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129413/new/ https://reviews.llvm.org/D129413 ___

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + // C11 6.7.2.1 §18 serge-sans-p

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3643021 , @JDevlieghere wrote: > In D126189#3643001 , @iains wrote: > >> In D126189#3642992 , @JDevlieghere >> wrote: >> >>> In D126189

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. Herald added a subscriber: steakhal. LGTM Zarko, sorry about taking so long to review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added a comment. The review shows the diff with the previous iteration of the patch. Can you generate a diff with the current top-of-tree? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/ https://reviews.llvm.org/D129377 ___

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

ASDenysPetrov added a comment. Herald added a project: All. @vsavchenko Is this alive? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 ___ cfe-commits mailing l

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 443699. cor3ntin added a comment. Fix crash on PowerPC (I forgot to removed a non-sense line that could cause the CurPtr to move incorrectly past a / in the ALTIVEC code path). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D128672: Update DynInit generation for ASan globals.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-68 - if (FsanitizeArgument.has(SanitizerKind::Address)) { -// TODO(hctim): Make this conditional whe

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3643045 , @iains wrote: > In D126189#3643021 , @JDevlieghere > wrote: > >> In D126189#3643001 , @iains wrote: >> >>> In D126189#3

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3853 +/// objcMessageExpr(objcMessageCallee(objcMethodDecl(hasName("foo" +AST_MATCHER_P(ObjCMessageExpr, objcMessageCallee, + internal::Matcher, InnerMatcher) {

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim updated this revision to Diff 443702. hctim marked an inline comment as done. hctim added a comment. Integrate Vitaly's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llvm.org/D128672 Files: clang/lib

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + // C11 6.7.2.1 §18 jyknight wrote:

[clang] e7c8ded - Revert "[C++20][Modules] Fix two tests for CTORs that return pointers [NFC]."

Author: Iain Sandoe Date: 2022-07-11T19:49:48+01:00 New Revision: e7c8ded6df6d38b019a1de268535d2dd73e7adaf URL: https://github.com/llvm/llvm-project/commit/e7c8ded6df6d38b019a1de268535d2dd73e7adaf DIFF: https://github.com/llvm/llvm-project/commit/e7c8ded6df6d38b019a1de268535d2dd73e7adaf.diff L

[clang] b19d3ee - Revert "[C++20][Modules] Build module static initializers per P1874R1."

Author: Iain Sandoe Date: 2022-07-11T19:50:31+01:00 New Revision: b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf URL: https://github.com/llvm/llvm-project/commit/b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf DIFF: https://github.com/llvm/llvm-project/commit/b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf.diff L

  1   2   >