JDevlieghere added a comment. In D126189#3643045 <https://reviews.llvm.org/D126189#3643045>, @iains wrote:
> In D126189#3643021 <https://reviews.llvm.org/D126189#3643021>, @JDevlieghere > wrote: > >> In D126189#3643001 <https://reviews.llvm.org/D126189#3643001>, @iains wrote: >> >>> In D126189#3642992 <https://reviews.llvm.org/D126189#3642992>, >>> @JDevlieghere wrote: >>> >>>> In D126189#3642820 <https://reviews.llvm.org/D126189#3642820>, @iains >>>> wrote: >>>> >>>>> JFTR, I did not get any notification from green dragon (which is odd, >>>>> AFAIR it's sent email before) or I would have looked right away - kicked >>>>> off a build will take a look as soon as that's done. >>>> >>>> Yes, the bot was already red because of a different issue. >>>> >>>> FWIW I tried reverting ac507102d258b6fc0cb57eb60c9dfabd57ff562f >>>> <https://reviews.llvm.org/rGac507102d258b6fc0cb57eb60c9dfabd57ff562f> and >>>> 4328b960176f4394416093e640ad4265bde65ad7 >>>> <https://reviews.llvm.org/rG4328b960176f4394416093e640ad4265bde65ad7> >>>> locally and I'm still getting a linker error about missing symbols: >>> >>> those refs come up as 'bad object' for me .. can you identify the upstream >>> changes? >> >> That's odd, both Github and Phab think those are the canonical hashes: >> >> https://github.com/llvm/llvm-project/commit/ac507102d258b6fc0cb57eb60c9dfabd57ff562f >> https://github.com/llvm/llvm-project/commit/4328b960176f4394416093e640ad4265bde65ad7 > > pilot error (pasto...) > >>>> Undefined symbols for architecture arm64: >>>> "vtable for std::__1::format_error", referenced from: >>>> std::__1::format_error::format_error(char const*) in main.o >>>> std::__1::format_error::format_error(std::__1::basic_string<char, >>>> std::__1::char_traits<char>, std::__1::allocator<char> > const&) in main.o >>> >>> That seems also unrelated to the modules code, but I could always be >>> surprised :) > > OK - so if I cannot figure out what is happening in the next couple or hours, > I can revert those two commits (that's 9PM for me so I probably cannot do > much more today). Thanks, if the bot reproduces the other issue I mentioned I'll bisect it down to see if there's another commit that's causing issues. I should've mentioned that that failures only happens when building with `-gmodules`, so it does sound somewhat related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
