ilya-biryukov added a comment.
A few NITs from my side, hopefully they can improve things a bit.
================
Comment at: clang/include/clang/AST/ASTContext.h:2676
+ /// Determine whether two 'requires' expressions are similar enough.
+ /// Use of 'requires' isn't mandatory, works with constraints expressed in
----------------
NIT: maybe be more specific here?
It's not clear what "similar enough" means without context, other comments
follow the pattern.
================
Comment at: clang/lib/AST/ASTContext.cpp:6254
return false;
if (TXTC->hasExplicitTemplateArgs() != TYTC->hasExplicitTemplateArgs())
return false;
----------------
Do we even want to compare the template argument sizes here?
Would comparing only `getImmediatelyDeclaredConstraint` produce the same
results?
If that's a performance optimization, we are probably better off moving it
inside `isSameConstraintExpr`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129068/new/
https://reviews.llvm.org/D129068
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
