ckissane added inline comments.
================ Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ ---------------- MaskRay wrote: > MaskRay wrote: > > This needs a change in lld/test/CMakeLists.txt > > > > Looks like you haven't run `ninja check-lld` as I mentioned. > Actually I am preparing a lld patch and you probably should drop have_zstd > from lld/ for this patch. I get this when I try to run that: `ninja: error: unknown target 'check-lld', did you mean 'check-lit'?` ================ Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ ---------------- ckissane wrote: > MaskRay wrote: > > MaskRay wrote: > > > This needs a change in lld/test/CMakeLists.txt > > > > > > Looks like you haven't run `ninja check-lld` as I mentioned. > > Actually I am preparing a lld patch and you probably should drop have_zstd > > from lld/ for this patch. > I get this when I try to run that: > `ninja: error: unknown target 'check-lld', did you mean 'check-lit'?` Got it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
