[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

akyrtzi updated this revision to Diff 436554. akyrtzi added a comment. Assert that `SkipExcludedConditionalBlock()` is not recursively called. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127379/new/ https://reviews.llvm.org/D127379 Files: clan

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:514 + BeginPtr = PP.CurLexer->getBufferLocation(); + SkipRangePtr = &PP.RecordedSkippedRanges[BeginPtr]; + if (*SkipRangePtr) { akyr

Re: [clang] f13019f - [clang] Use any_of and none_of (NFC)

On Sun, Jun 12, 2022 at 10:17 AM Kazu Hirata via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kazu Hirata > Date: 2022-06-12T10:17:12-07:00 > New Revision: f13019f8367a417075e70effb13dcf58024090b2 > > URL: > https://github.com/llvm/llvm-project/commit/f13019f8367a417075e70effb13dcf

Re: [clang] d941d59 - Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible"

Please include details about the reason for a revert in the revert commit message - helpful for folks following along/looking to see if a given revert addresses an issue they're seeing, etc. On Sun, Jun 12, 2022 at 7:47 AM Jez Ng via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Je

Re: [clang] d4bcb45 - [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible

Please include details of what changed between one commit and a recommit of a patch - helpful for reviewers checking what's changed since the last commit, double-checking that the patch fully addresses the issues, etc. On Sun, Jun 12, 2022 at 2:24 PM Jez Ng via cfe-commits < cfe-commits@lists.llvm

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta updated this revision to Diff 436557. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CXX/expr/expr.const/p2-0x.cpp clang/test/SemaCXX/constant

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Couple more minor things, but basically LGTM. Comment at: clang/include/clang/Lex/Preprocessor.h:2601 + /// This is used to guard against calling this function rec

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders updated this revision to Diff 436561. wanders added a subscriber: kimgr. wanders added a comment. Updated diff with: - Release note - Cleaned up command line options in RUN commands - Fixed type mimatch pointed out by @kimgr (out of band) Repository: rG LLVM Github Monorepo CHANGES

[clang] 2a5d567 - Fix-forward broken ASan test on Windows.

Author: Mitch Phillips Date: 2022-06-13T14:23:23-07:00 New Revision: 2a5d567041565a2c6b8bc8aa7845ad176dbf5d54 URL: https://github.com/llvm/llvm-project/commit/2a5d567041565a2c6b8bc8aa7845ad176dbf5d54 DIFF: https://github.com/llvm/llvm-project/commit/2a5d567041565a2c6b8bc8aa7845ad176dbf5d54.diff

[PATCH] D126984: [clang] Add support for optimize function attribute

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3469 +support the GCC semantics. Optimization levels `-O1` through `-O4` are +ignored. Only "-O0", "-Oz", "-Os", and "-Ofast" are supported. + something about `optimize(-Os)` still

[PATCH] D126984: [clang] Add support for optimize function attribute

xbolva00 added a comment. If you compile file with -Ofast and use optimise(-Os) for F - I would expect no fast math flags for function F but I am worried a bit that only “optsize” is added. Plesse verify and/or add such test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added a comment. LGTM: http://45.33.8.238/win/60042/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 ___ cfe-commits mailing list cfe-commits@

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek updated this revision to Diff 436575. phosek marked an inline comment as done. Herald added subscribers: cfe-commits, abrachet. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek added inline comments. Comment at: compiler-rt/CMakeLists.txt:512 +# default libunwind (which may be missing still). +append_list_if(CXX_SUPPORTS_UNWINDLIB_NONE_FLAG --unwindlib=none SANITIZER_COMMON_LINK_FLAGS) + mstorsjo wrote: > phosek wrote: >

[PATCH] D126984: [clang] Add support for optimize function attribute

jdoerfert added a comment. In D126984#3571573 , @aeubanks wrote: > IIRC in the past there was a strong preference to not have the pass manager > support this sort of thing > if you want to support this, there should be an RFC for how the optimization >

[PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

efriedma added a comment. A couple notes skimming the changes: 1. If you're going to update URLs, please verify the new URLs are actually valid. 2. Some of the "URLs" you're updating aren't actually URLs. For example, the `xmlns` attribute in SVG files must be the exact string written in the s

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek updated this revision to Diff 436584. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D115674 Files: clang/cmake/caches/Fuchsia-stage2.cmake compiler-rt/CMakeLists.txt compiler-rt/cmake/config-ix.cmake

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

phosek added a comment. @mstorsjo let me know if this looks good to you, I tested this locally and it seems to be working fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D115674 ___

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

efriedma added a comment. Why are you messing with test_demangle.pass.cpp? The demangler doesn't care what symbols we actually define in LLVM... it's just a bunch of hardcoded testcases. So it doesn't matter if it continues to refer to GCCBuiltin. Other changes look fine. Repository: rG L

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. No, I don't think there are any problems. We can probably just pop the cleanups at the end of the asm statement. The original commit message said the asm calls had to be wrapped in `StmtExpr`s because temporaries would get destroyed before the asm calls, but that doesn

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8320 +TC->getDriver().isUsingLTO(/* IsOffload */ true) +? ",feature=" + llvm::join(FeatureArgs, ",feature=") +: ""; This makes a couple of implicit assump

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

mdfazlay updated this revision to Diff 436589. mdfazlay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added erroneous tests, nesting of regions test and analysis tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 added a comment. Thanks for the comments, I'll try to address them. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8320 +TC->getDriver().isUsingLTO(/* IsOffload */ true) +? ",feature=" + llvm::join(FeatureArgs, ",feature=") +: "";

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev updated this revision to Diff 436590. sgatev added a comment. Rebase main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125931/new/ https://reviews.llvm.org/D125931 Files: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptio

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

steplong updated this revision to Diff 436592. steplong added a comment. - Ignore /Zc:wchar_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang/include/clang/Driver/Options.td clang/test/Dr

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

thakis added a comment. Thanks for the successful whack-a-moling :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. a gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev marked 3 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:596-598 + MergedEnv.makeOr( + MergedEnv.makeAnd(Env1.getFlowConditionToken(), *HasValueVal1), + Merg

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

tra added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu-new.c:117 + +// CHECK-LTO-FEATURES: clang-offload-packager{{.*}}feature={{.*}}ptx jhuber6 wrote: > tra wrote: > > This should probably be a bit more specific/verbose. E.g. I'd want to mak

[PATCH] D126192: [Driver] Improve linking options for target AVR

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. It is fine if you don't add a magic linker script for -fuse-ld=lld. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 _

[clang] d7599be - [Driver] Improve linking options for target AVR

Author: Ben Shi Date: 2022-06-13T23:38:59Z New Revision: d7599be9e84fb205b7f50de406dc87858aebc0f4 URL: https://github.com/llvm/llvm-project/commit/d7599be9e84fb205b7f50de406dc87858aebc0f4 DIFF: https://github.com/llvm/llvm-project/commit/d7599be9e84fb205b7f50de406dc87858aebc0f4.diff LOG: [Driv

[PATCH] D126192: [Driver] Improve linking options for target AVR

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7599be9e84f: [Driver] Improve linking options for target AVR (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://rev

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 updated this revision to Diff 436607. jhuber6 added a comment. Adjust how we generate arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127686/new/ https://reviews.llvm.org/D127686 Files: clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:735 + llvm::StringMap LastOpt; + for (unsigned I = 0, N = Features.size(); I < N; ++I) { +StringRef Name = Features[I]; // Record the index of the last occurence

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 updated this revision to Diff 436611. jhuber6 added a comment. Does this approach work? I'm just using the reverse iterator and only adding the argument if it hasn't been seen yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127686/new/

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:661 + +The $map_type_modifier vector specifies the modifier for each map type +operand abidmalikwaterlo

[clang] 520d17b - Revert "[Driver] Improve linking options for target AVR"

Author: Ben Shi Date: 2022-06-14T09:12:21+08:00 New Revision: 520d17bfa012e07daf7abda68cf903838b374848 URL: https://github.com/llvm/llvm-project/commit/520d17bfa012e07daf7abda68cf903838b374848 DIFF: https://github.com/llvm/llvm-project/commit/520d17bfa012e07daf7abda68cf903838b374848.diff LOG:

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

akyrtzi updated this revision to Diff 436612. akyrtzi added a comment. Add more comments about the use of `SkippingExcludedConditionalBlock` and move the new `Preprocessor` fields towards the top of the class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. Two questions for Clang developers as I work on my next patches: 1. What is the Clang policy for warnings on extension usages? For example, this diff permits redeclaration of typedefs, which is a Plan 9 and Microsoft C extension. Earlier in the file this extension is

[clang] 3b6e166 - [Driver] Improve linking options for target AVR

Author: Ben Shi Date: 2022-06-14T01:30:49Z New Revision: 3b6e166999bb83197c8b70468c2d371c58cf0c25 URL: https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 DIFF: https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25.diff LOG: [Driv

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 436616. abidmalikwaterloo added a comment. Revised the patcg according to the reviews of the reviewers. clean the code and add some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ h

[PATCH] D127706: [Clang] Enable MSVC embedded records for Plan 9

ksaunders created this revision. ksaunders added a reviewer: rsmith. ksaunders added a project: clang. Herald added a project: All. ksaunders requested review of this revision. Herald added a subscriber: cfe-commits. This diff enables MSVC embedded records when Plan 9 extensions are enabled. As w

[PATCH] D127707: [Clang] Simplify unifying target features

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, jdoerfert, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch simplifies how we unify target features. Now we simply i

[clang] 0ba43f4 - [sanitizer] Add -lresolv only for non-Android non-musl Linux

Author: Fangrui Song Date: 2022-06-13T19:12:13-07:00 New Revision: 0ba43f4c2b263268f6fbc56bb3f6d43936781957 URL: https://github.com/llvm/llvm-project/commit/0ba43f4c2b263268f6fbc56bb3f6d43936781957 DIFF: https://github.com/llvm/llvm-project/commit/0ba43f4c2b263268f6fbc56bb3f6d43936781957.diff

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

MaskRay added a comment. I pushed 0ba43f4c2b263268f6fbc56bb3f6d43936781957 with an elaborated comment. This patch is not needed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. I love the tests (pretty cool examples of what can be handled). Thanks for the thoroughness! Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessMo

[clang] 11cf75f - [Driver][test] Make ananas.c and solaris-ld.c robust

Author: Fangrui Song Date: 2022-06-13T19:44:24-07:00 New Revision: 11cf75f602e6717e2a5195b3e8ca161dd9de9945 URL: https://github.com/llvm/llvm-project/commit/11cf75f602e6717e2a5195b3e8ca161dd9de9945 DIFF: https://github.com/llvm/llvm-project/commit/11cf75f602e6717e2a5195b3e8ca161dd9de9945.diff

[clang] f7e19a5 - [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

Author: Argyrios Kyrtzidis Date: 2022-06-13T21:46:46-07:00 New Revision: f7e19a59284208712314a2d0702b48c445909130 URL: https://github.com/llvm/llvm-project/commit/f7e19a59284208712314a2d0702b48c445909130 DIFF: https://github.com/llvm/llvm-project/commit/f7e19a59284208712314a2d0702b48c445909130.

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7e19a592842: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly… (authored by akyrtzi). Repository: rG LLVM Github Mo

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

tbaeder updated this revision to Diff 436650. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127638/new/ https://reviews.llvm.org/D127638 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/test/SemaCXX/nested-name-spec.cpp Index: clang/test/SemaCXX/nested-name-spec.cpp ===

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

tbaeder added a comment. That does indeed work, thanks for the suggestion! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127638/new/ https://reviews.llvm.org/D127638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D127624: [C++20][Modules] Allow for redeclarations in partitions.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Yeah, it might be painful to compare string all the time. Let's do it when refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 436661. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Aaron's comments - `{}` => `llvm::None` in Lexer.cpp - Fix casing in UnicodeNameToCodepoint.cpp to match the style, and a couple I missed in UnicodeNameMappingGenerator.cpp

[clang] 735e6c4 - [Coroutines] Convert coroutine.presplit to enum attr

Author: Chuanqi Xu Date: 2022-06-14T14:23:46+08:00 New Revision: 735e6c40b5e9a128820f009595de4728e5d6b3d5 URL: https://github.com/llvm/llvm-project/commit/735e6c40b5e9a128820f009595de4728e5d6b3d5 DIFF: https://github.com/llvm/llvm-project/commit/735e6c40b5e9a128820f009595de4728e5d6b3d5.diff LO

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG735e6c40b5e9: [Coroutines] Convert coroutine.presplit to enum attr (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rjmccall added a comment. Yeah, I think the appropriate thing is to just treat the entire asm statement like it's a single full-expression. As always, that implies an annoying lifetime for blocks and C compound literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D127528: [Clang] Let the linker choose shared or static libunwind unless specified

mstorsjo added a reviewer: mstorsjo. mstorsjo added a comment. LGTM in general, but I'd leave it to the others to formally approve. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1477 if (Args.hasArg(options::OPT_shared_libgcc)) return LibGccType::SharedLibGcc;

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

mstorsjo accepted this revision. mstorsjo added a comment. The changes left in this patch seem fine to me now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115674/new/ https://reviews.llvm.org/D115674 _

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3577815 , @iains wrote: > In D126694#3576853 , @ChuanqiXu > wrote: > >> In D126694#3576602 , @iains wrote: >> >>> @ChuanqiXu - I cha

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

akuegel added a comment. It seems this change triggers a warning: https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1 llvm-project/llvm/lib/Transforms/Utils/CodeExtractor.cpp:901:15: error: enumeration value 'PresplitCoroutine' not handled in swit

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu added a comment. In D127471#3580581 , @akuegel wrote: > It seems this change triggers a warning: > > https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1 > > llvm-project/llvm/lib/Transforms/Utils/C

[PATCH] D125669: Adding support for target in_reduction

RitanyaB added a comment. Could someone please review the changes? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125669 ___ cfe-commits mailing list cfe-com

[PATCH] D127486: [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

martong accepted this revision. martong added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:362-364 - /// Retrieves and sets the UserMode. This is a high-level option, - /// which is used

<    1   2   3