cor3ntin updated this revision to Diff 436661.
cor3ntin marked an inline comment as done.
cor3ntin added a comment.
Address Aaron's comments
- `{}` => `llvm::None` in Lexer.cpp
- Fix casing in UnicodeNameToCodepoint.cpp to match the style, and a couple I
missed in UnicodeNameMappingGenerator.cpp
- Fix an underflow in `LiteralSupport.cpp`
- Add an assert in `ProcessNamedUCNEscape`
- Reserve less space in `fullName()` + add comment in
`UnicodeNameToCodepoint.cpp`
- remove unused jamo constants in `UnicodeNameToCodepoint.cpp`
- Add license + unicode url to `UnicodeNameMappingGenerator.cpp`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123064/new/
https://reviews.llvm.org/D123064
Files:
clang/include/clang/Basic/DiagnosticLexKinds.td
clang/include/clang/Lex/Lexer.h
clang/lib/Lex/Lexer.cpp
clang/lib/Lex/LiteralSupport.cpp
clang/test/FixIt/fixit-unicode-named-escape-sequences.c
clang/test/Lexer/char-escapes-delimited.c
clang/test/Lexer/unicode.c
clang/test/Parser/cxx11-user-defined-literals.cpp
clang/test/Preprocessor/ucn-pp-identifier.c
clang/test/Sema/ucn-identifiers.c
llvm/CMakeLists.txt
llvm/include/llvm/Support/Unicode.h
llvm/lib/Support/CMakeLists.txt
llvm/lib/Support/UnicodeNameToCodepoint.cpp
llvm/lib/Support/UnicodeNameToCodepointGenerated.cpp
llvm/unittests/Support/UnicodeTest.cpp
llvm/utils/UnicodeData/CMakeLists.txt
llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
