mstorsjo added a reviewer: mstorsjo.
mstorsjo added a comment.
LGTM in general, but I'd leave it to the others to formally approve.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1477
if (Args.hasArg(options::OPT_shared_libgcc))
return LibGccType::SharedLibGcc;
- // The Android NDK only provides libunwind.a, not libunwind.so.
----------------
Previously, `OPT_shared_libgcc` would override the default for android, but now
it no longer would. I guess that might be sensible, but it seems slightly
outside of what the patch says it does. (I guess it's fine to include the
change too, but I just wanted to raise it for discussion.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127528/new/
https://reviews.llvm.org/D127528
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
