[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. In D126291#3550563 , @Meinersbur wrote: > While the test passes now, I still get `LINK : fatal error LNK1561: entry > point must be defined` when trying to actually link. Isn't it expected to not > work yet? > > Linking with `lld

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:753 + llvm::opt::ArgStringList &CmdArgs) { + if (TC.getTriple().isOSWindows()) { +CmdArgs.push_back("Fortran_main.lib"); mmuetzel wrote: > Ar

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae created this revision. python3kgae added reviewers: Anastasia, svenvh, jdoerfert, azabaznov, beanz, tra, yaxunl, pow2clk. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One clang builti

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:623 + IntrusiveRefCntPtr DiagID(new DiagnosticIDs()); + struct TestDiagnosticConsumer : public DiagnosticConsumer {}; + MaskRay wrote:

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 433673. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driver/ToolChainTest.cpp ==

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

nridge added a comment. It seems you have uploaded just the changes relative to the previous patch. If you made a second commit, you need to `squash` it into the first and resubmit. Otherwise the test looks good, thanks! Comment at: clang-tools-extra/clangd/unittests/Semantic

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:118-119 TokenType NextLBracesType = TT_Unknown, + bool *HasDoWhile = nullptr,

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1889 TokenCount = Line->Tokens.size(); - if (TokenCount == 1 || - (TokenCount == 2 && Line->Tokens.front().Tok->is(tok::comment))) { Why did you re

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

nikic added a comment. It looks like this causes a major compile-time regression in the clang frontend: http://llvm-compile-time-tracker.com/compare.php?from=6232a8f3d61e5856c17e7b314385e9ea8068cdc1&to=8c8a2679a20f621994fa904bcfc68775e7345edc&stat=instructions For example, tramp3d-v4 is up 5% i

[PATCH] D120495: [clang][dataflow] Add transfer functions for structured bindings

This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rG0e286b77cf7b: [clang][dataflow] Add transfer functions for structured bindings (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 0e286b7 - [clang][dataflow] Add transfer functions for structured bindings

Author: Stanislav Gatev Date: 2022-06-02T08:02:26Z New Revision: 0e286b77cf7bebca568b60ac81c1717291040bc3 URL: https://github.com/llvm/llvm-project/commit/0e286b77cf7bebca568b60ac81c1717291040bc3 DIFF: https://github.com/llvm/llvm-project/commit/0e286b77cf7bebca568b60ac81c1717291040bc3.diff LO

[clang] db15e31 - [clang-format] Handle do-while loops for RemoveBracesLLVM

Author: owenca Date: 2022-06-02T01:08:40-07:00 New Revision: db15e31212436ae51c04e8b5fcc2f140db4d6626 URL: https://github.com/llvm/llvm-project/commit/db15e31212436ae51c04e8b5fcc2f140db4d6626 DIFF: https://github.com/llvm/llvm-project/commit/db15e31212436ae51c04e8b5fcc2f140db4d6626.diff LOG: [

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb15e3121243: [clang-format] Handle do-while loops for RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D126801: [analyzer][NFC] Add partial specializations for ProgramStateTraits

martong added a comment. Nice! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h:287 - // Partial specialization for void*. - template <> struct ProgramStatePartialTrait { -using data_type = void *; + // Partial specialization for e

[PATCH] D126742: [RISCV][Clang] Support RVV policy functions.

fakepaper56 added inline comments. Comment at: clang/lib/Sema/SemaRVVLookup.cpp:329 + + auto appendPolicySuffix = [&](std::string suffix) { +Name += suffix; Using `const std::string &suffix`. Comment at: clang/lib/Support/RISCVVIntrinsicUt

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a subscriber: tonic. tstellar added a comment. In D125624#3552463 , @ruiu wrote: >> OK, as I mentioned. I think we need an attorney to review this change and >> confirm that it actually accomplishes this goal. > > Can you add an attorney a

[clang] f730749 - [clang] [ARM] Add __builtin_sponentry like on aarch64

Author: Martin Storsjö Date: 2022-06-02T12:29:59+03:00 New Revision: f730749e8584fe7ea3927d0359f20d167d281e80 URL: https://github.com/llvm/llvm-project/commit/f730749e8584fe7ea3927d0359f20d167d281e80 DIFF: https://github.com/llvm/llvm-project/commit/f730749e8584fe7ea3927d0359f20d167d281e80.diff

[PATCH] D126764: [clang] [ARM] Add __builtin_sponentry like on aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGf730749e8584: [clang] [ARM] Add __builtin_sponentry like on aarch64 (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126764/new/ https:

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433694. junaire added a comment. also swap TBAA Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeG

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

mstorsjo created this revision. mstorsjo added reviewers: efriedma, zzheng. Herald added a subscriber: kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. The backend now can generate working unw

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille created this revision. serge-sans-paille added reviewers: george.burgess.iv, kees. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald a

[PATCH] D126865: [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied

mstorsjo created this revision. mstorsjo added reviewers: MaskRay, efriedma, zzheng. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. ARM EHABI isn't signalled by any specific compiler built

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille added a comment. Note: I named the option `-fstrict-flex-arrays` and not `-fstrict-flex-array` because we already have `-fstrict-enums`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1889 TokenCount = Line->Tokens.size(); - if (TokenCount == 1 || - (TokenCount == 2 && Line->Tokens.front().Tok->is(tok::comment))) { --

[clang] 81e4441 - [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

Author: Gabor Marton Date: 2022-06-02T11:41:19+02:00 New Revision: 81e44414aa925f5dcaf05ef658d1bffd8937ef4c URL: https://github.com/llvm/llvm-project/commit/81e44414aa925f5dcaf05ef658d1bffd8937ef4c DIFF: https://github.com/llvm/llvm-project/commit/81e44414aa925f5dcaf05ef658d1bffd8937ef4c.diff

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81e44414aa92: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl (authored by martong). Repository: rG LLVM Github Monorep

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

njames93 added a comment. Can I ask what the motivation is for this change? You may want to check the actual header files for the checks. A lot of them have a comment saying. /// For the user-facing documentation see: /// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-reserved-iden

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 433702. sstwcw added a comment. - add comment and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/D124749 Files: clang/lib/Format/FormatToken.h clang/lib/Format/For

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

martong added a comment. I think we should avoid `auto` when using `State->get<>` because the type is not immediate for the reader. (Unlike in a `cast`.) Comment at: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp:198 // The special errno region should never garbage col

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

mstorsjo created this revision. mstorsjo added reviewers: efriedma, zzheng. Herald added a subscriber: kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. This goes hand in hand with D126870

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126803/new/ https://reviews.llvm.org/D126803

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:138 TYPE(CSharpGenericTypeConstraintComma) \ + TYPE(VerilogNumberBase) /* for the base in a number literal, not including \ +

[clang-tools-extra] 35f0890 - [clang-tidy] Remove extra ";" in ModernizeModuleTest.cpp

Author: Mikael Holmen Date: 2022-06-02T12:50:00+02:00 New Revision: 35f0890c4edce1975b17d0901607f2fba9216462 URL: https://github.com/llvm/llvm-project/commit/35f0890c4edce1975b17d0901607f2fba9216462 DIFF: https://github.com/llvm/llvm-project/commit/35f0890c4edce1975b17d0901607f2fba9216462.diff

Re: [PATCH] D125052: [HLSL] Enable vector types for hlsl.

Hi Xiang, I would be more than happy to test the fix for you :). Though it is 11:45 pm for me now and I am going to bed. But I can take a look tomorrow. Thanks, Shubham > On Jun 1, 2022, at 11:42 PM, stan li wrote: > > Hi Shubham, > > I found one issue in the change. > But I don’t have a M

[PATCH] D126780: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, But please add a note to ReleaseNotes before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126780/new/ https://reviews.llvm.o

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong added a comment. I've made some measurements with the diff down below. So, it seems like the chance of being a recursive call is very unlikely (roughly 1/1). Thus I am going to update this condition with `LLVM_UNLIKELY`. Besides, the depth of the call stack seems to be less than 4 i

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

aaron.ballman added a comment. In D125802#3552047 , @browneee wrote: > It looks like the leak is rooted at the allocation here: > https://github.com/llvm/llvm-project/blob/1a155ee7de3b62a2fabee86fb470a1554fadc54d/clang/lib/Sema/SemaTemplateInstantiateDecl

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you add a release note for the change? (There's an `Improvements to pp-trace` section in docs\ReleaseNotes.rst) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

martong marked 4 inline comments as done. martong added a comment. > Consequently, a SmallPtrSet with 4 as the small buffer size would be better > than the SmallVector Ahh, SmallVector is still better, because with the set we need to do a search in the `erase, which compares badly to a simple d

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

martong updated this revision to Diff 433719. martong marked 3 inline comments as done. martong edited the summary of this revision. martong added a comment. - Add LLVM_UNLIKELY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://revi

[clang] c745f2c - Revert "Drop qualifiers from return types in C (DR423)"

Author: Aaron Ballman Date: 2022-06-02T08:28:43-04:00 New Revision: c745f2ce6c03bc6d1e59cac69cc15923d4400191 URL: https://github.com/llvm/llvm-project/commit/c745f2ce6c03bc6d1e59cac69cc15923d4400191 DIFF: https://github.com/llvm/llvm-project/commit/c745f2ce6c03bc6d1e59cac69cc15923d4400191.diff

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT updated this revision to Diff 433722. oToToT added a comment. Added a release note for the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty added a comment. In D126340#3552645 , @nikic wrote: > It looks like this causes a major compile-time regression in the clang > frontend: > http://llvm-compile-time-tracker.com/compare.php?from=6232a8f3d61e5856c17e7b314385e9ea8068cdc1&to=8c8a267

[clang] 30ad481 - Revert "cmake: use llvm dir variables for clang/utils/hmaptool"

Author: Nikita Popov Date: 2022-06-02T14:55:58+02:00 New Revision: 30ad481e87ca7cd2250bd5771ab66ddfe623eb10 URL: https://github.com/llvm/llvm-project/commit/30ad481e87ca7cd2250bd5771ab66ddfe623eb10 DIFF: https://github.com/llvm/llvm-project/commit/30ad481e87ca7cd2250bd5771ab66ddfe623eb10.diff

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

erichkeane added a comment. In D125802#3553015 , @aaron.ballman wrote: > In D125802#3552047 , @browneee > wrote: > >> It looks like the leak is rooted at the allocation here: >> https://github.com/llvm/llvm-proj

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

steakhal accepted this revision. steakhal added a comment. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___ cfe-commits mailing list cfe-commits@

[libunwind] dfaee3c - [libunwind][ci][AIX] Add libunwind to buildbot CI

Author: Xing Xue Date: 2022-06-02T09:03:10-04:00 New Revision: dfaee3c9cfa17fce6af317ddcae89c6f6550cf94 URL: https://github.com/llvm/llvm-project/commit/dfaee3c9cfa17fce6af317ddcae89c6f6550cf94 DIFF: https://github.com/llvm/llvm-project/commit/dfaee3c9cfa17fce6af317ddcae89c6f6550cf94.diff LOG:

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

steakhal added a comment. Express why this is not an NFC patch in the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___ cfe-commits mailing list cfe-

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane planned changes to this revision. erichkeane added a comment. In D126818#3551504 , @erichkeane wrote: > Note this was mentioned as a 'must also do' in my discussion on deferred > constraints with @rsmith, however as this already fails, I don'

[PATCH] D126878: [analyzer] Remove NotifyAssumeClients

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov updated this revision to Diff 433729. mizvekov edited the summary of this revision. mizvekov added a comment. - fix for standalone builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308 Files:

[clang] d42fe9a - Revert "[clang][AIX] add option mdefault-visibility-export-mapping"

Author: Hans Wennborg Date: 2022-06-02T15:09:39+02:00 New Revision: d42fe9aa84203a8f51b43a901d72fdc39eea69f7 URL: https://github.com/llvm/llvm-project/commit/d42fe9aa84203a8f51b43a901d72fdc39eea69f7 DIFF: https://github.com/llvm/llvm-project/commit/d42fe9aa84203a8f51b43a901d72fdc39eea69f7.diff

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

hans added a comment. We're hitting an assertion in Chromium due to this: llvm/clang/lib/AST/Decl.cpp:1510: clang::LinkageInfo clang::LinkageComputer::getLVForDecl(const clang::NamedDecl *, clang::LVComputationKind): Assertion `D->getCachedLinkage() == LV.getLinkage()' failed. See https://b

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3552887 , @njames93 wrote: > Can I ask what the motivation is for this change? https://discourse.llvm.org/t/clang-tidy-rfc-use-module-name-as-a-directory-for-organizing-files/62499 CHANGES SINCE LAST ACTION

[PATCH] D126878: [analyzer] Remove NotifyAssumeClients

steakhal added a comment. Measure if it changes any reports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126878/new/ https://reviews.llvm.org/D126878 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] b2c6251 - [PS5] Support r and y specifiers of freebsd_kernel_printf format strings

Author: Paul Robinson Date: 2022-06-02T06:27:11-07:00 New Revision: b2c6251c06700bfe8a69b780cb27928d3ba029db URL: https://github.com/llvm/llvm-project/commit/b2c6251c06700bfe8a69b780cb27928d3ba029db DIFF: https://github.com/llvm/llvm-project/commit/b2c6251c06700bfe8a69b780cb27928d3ba029db.diff

[clang] e374216 - Revert "unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 8c8a2679a20f"

Author: Nico Weber Date: 2022-06-02T09:31:57-04:00 New Revision: e37421669e223ac4e67a0158eae7d78af2ff0b88 URL: https://github.com/llvm/llvm-project/commit/e37421669e223ac4e67a0158eae7d78af2ff0b88 DIFF: https://github.com/llvm/llvm-project/commit/e37421669e223ac4e67a0158eae7d78af2ff0b88.diff LO

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. @nikic can you confirm this new patch is good for standalone? @Ericson2314 FYI in case your patch is going to improve on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308 __

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

thakis added a comment. When you reland this, please reland 4463bd0f89181234e0cef982e21de2e96038f873 at the same time. Else, this breaks tests in some build configurations. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 0b46121 - Update more DR status information for C.

Author: Aaron Ballman Date: 2022-06-02T09:32:44-04:00 New Revision: 0b46121c4130eec702066bca65802c21a9517539 URL: https://github.com/llvm/llvm-project/commit/0b46121c4130eec702066bca65802c21a9517539 DIFF: https://github.com/llvm/llvm-project/commit/0b46121c4130eec702066bca65802c21a9517539.diff

[PATCH] D126633: [pseudo] Use the pseudoCXX library in fuzzer.

sammccall added a comment. As discussed offline: - this should really be a cross-cutting change for all tools - we're going to have multiple grammars or variants (e.g. c, c++, obj-c) - it would be nice to preserve the ability for tools to use a grammar from a file This all points at having a li

[PATCH] D126689: [IR] Enable opaque pointers by default

uabelho added a comment. Is anyone here ever using llvm-stress? I noticed that with this patch, llvm-stress seems to start producing code that llc crashes on, and it crashes even if I run on older llc versions. One example: llc -o /dev/null stress.ll crashes with llc: ../lib/CodeGen/Select

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 433732. upsj added a comment. - fix varargs, again :) - remove parameter names entirely if they occur multiple times Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 File

[PATCH] D126801: [analyzer][NFC] Add partial specializations for ProgramStateTraits

steakhal updated this revision to Diff 433734. steakhal marked an inline comment as done. steakhal added a comment. - host common implementation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126801/new/ https://reviews.llvm.org/D126801 Files: clang/include/clang/StaticAnalyzer/Core/P

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

steakhal updated this revision to Diff 433737. steakhal marked 2 inline comments as done. steakhal added a comment. - replace `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126802/new/ https://reviews.llvm.org/D126802 Files: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

steakhal updated this revision to Diff 433738. steakhal added a comment. - rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126803/new/ https://reviews.llvm.org/D126803 Files: clang/include/clang/Basic/SourceLocation.h clang/lib/StaticAnalyzer/Checkers/ObjCSelfInitChecker.cpp

[PATCH] D126816: Only issue warning for subtraction involving null pointers on live code paths

jamieschmeiser updated this revision to Diff 433736. jamieschmeiser edited the summary of this revision. jamieschmeiser added a comment. Respond to review comments: add cpp test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126816/new/ https://reviews.llvm.org/D126816 Files: clang/l

[PATCH] D126801: [analyzer][NFC] Add partial specializations for ProgramStateTraits

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h:292 -static void *MakeVoidPtr(data_type d) { - return const_cast(d);

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp created this revision. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Flags uses of const-qualifi

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126802/new/ https://reviews.llvm.org/D126802 ___ cfe-commits mailing list cfe-commits

[PATCH] D126881: Use default arguments instead of overloads.

asoffer created this revision. Herald added a project: All. asoffer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126881 Files: clang/include/clang/Frontend/ASTUnit.h c

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 433743. carlosgalvezp added a comment. Fix FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidC

[PATCH] D126881: Use default arguments instead of overloads.

asoffer updated this revision to Diff 433744. asoffer added a comment. Use default arguments instead of overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126881/new/ https://reviews.llvm.org/D126881 Files: clang/include/clang/Frontend/AST

[PATCH] D126881: Use default arguments instead of overloads.

asoffer updated this revision to Diff 433745. asoffer added a comment. Remove non-existant overload from cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126881/new/ https://reviews.llvm.org/D126881 Files: clang/lib/Frontend/ASTUnit.cpp

[PATCH] D126689: [IR] Enable opaque pointers by default

nikic added a comment. @uabelho Here's a slightly cleaned up test case that does not use opaque pointers: target triple = "x86_64-unknown-linux-gnu" define void @test(i1 %cond, <1 x i16>* %p) { br label %loop loop: %v = load <1 x i16>, <1 x i16>* %p, align 2 %ins = insert

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

asoffer updated this revision to Diff 433747. asoffer added a comment. Use default arguments instead of overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126806/new/ https://reviews.llvm.org/D126806 Files: clang/lib/Frontend/ASTUnit.cpp

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

asoffer abandoned this revision. asoffer added a comment. I don't know what happened here, but when I update a diff half my changes disappear. I'm going to recreate this in a new diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126806/new/ http

[clang] 5a6352b - Tidy up `pragma comment lib` handling and testing

Author: Paul Robinson Date: 2022-06-02T07:52:26-07:00 New Revision: 5a6352bc70fb0f309de22ea75ef132f32d8be9b4 URL: https://github.com/llvm/llvm-project/commit/5a6352bc70fb0f309de22ea75ef132f32d8be9b4 DIFF: https://github.com/llvm/llvm-project/commit/5a6352bc70fb0f309de22ea75ef132f32d8be9b4.diff

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

bzcheeseman added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:260 /// to FoldingSets that were not originally designed to have that behavior. -template struct FoldingSetTrait - : public DefaultFoldingSetTrait {}; +template +struct FoldingSetTrait : public D

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 433757. carlosgalvezp added a comment. Move logic from check to registerMatchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 Files: clang-tools-extra/cla

[PATCH] D126689: [IR] Enable opaque pointers by default

nikic added a comment. I believe https://reviews.llvm.org/D126886 should fix the DAGCombiner issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126689/new/ https://reviews.llvm.org/D126689 ___ cfe-comm

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

aaron.ballman added a comment. In D126796#3551996 , @cjdb wrote: > In D126796#3551834 , @tschuett > wrote: > >> In D126796#3551781 , @cjdb wrote: >> >>> In D126796#355131

[PATCH] D126084: [Sema] Reject list-initialization of a scoped enum variable from an element of a different scoped enum type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you also add a release note about the fix before landing the changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12608

[PATCH] D126888: Add a parameter to LoadFromASTFile that accepts a file system and defaults to the real file-system.

asoffer created this revision. asoffer added a reviewer: ymandel. Herald added a project: All. asoffer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126888 Files: clang/i

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

aaron.ballman added a comment. Can you post some examples of the output from this option so we can see what the end results look like more easily? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126832/new/ https://reviews.llvm.org/D126832

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added a comment. In D126291#3552573 , @rovka wrote://italic text// > I don't really know why `link.exe` doesn't work. According to the docs >

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/Attr.td:2945 C2x<"", "nodiscard", 201904>, CXX11<"clang", "warn_unused_resul

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

steakhal added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:205-208 +- Fixed a crash in :doc:`performance-unnecessary-value-param + ` when the specialization + template has an unnecessary value paramter. Removed the fix for a template. + ---

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551288 , @aaron.ballman wrote: > In D126796#3551280 , @MaskRay wrote: > >> In D126796#3551261 , @cjdb wrote: >> >>> In D126796#3550848 <

[PATCH] D126891: [clang-tidy] The check should ignore final classes

steakhal created this revision. steakhal added reviewers: aaron.ballman, njames93, LegalizeAdulthood, whisperity. Herald added subscribers: carlosgalvezp, martong, rnkovacs, kbarton, xazax.hun, nemanjai. Herald added a project: All. steakhal requested review of this revision. Herald added a proje

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg updated this revision to Diff 433772. csigg added a comment. Rename pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158 Files: mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td mlir/include/mlir/Dia

[PATCH] D126689: [IR] Enable opaque pointers by default

aprantl added a comment. It looks like this patch has broken 168 tests in LLDB: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/44239/changes#41d5033eb162cb92b684855166cabfa3983b74c6 I'm going to dig a little deeper, but I might ask you to revert this until we can figure out a solution

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

aaron.ballman added a comment. In D125723#3550956 , @steplong wrote: > Appreciate the help! It's not clear to me how to go from the strings "Os", > "foo1", "foo2", "foo3" to adding "-Os -ffoo1 -ffoo2 -ffoo3" to the > compilation line for that function

[PATCH] D126892: [NFC] Fix issue on CMake Xcode build configuration.

python3kgae created this revision. python3kgae added a reviewer: rastogishubham. Herald added subscribers: Anastasia, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. add missing dependency fo

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

rnk added a comment. In D125723#3553664 , @aaron.ballman wrote: > In D125723#3550956 , @steplong > wrote: > >> Appreciate the help! It's not clear to me how to go from the strings "Os", >> "foo1", "foo2", "foo3

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

MaskRay added a comment. If you still decide to add an option to clang, I think "diagnostics" is better than "warnings". There are many diagnostics which are errors by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://revi

[PATCH] D126602: [Clang][OpenMP] Replace IgnoreImpCasts with IgnoreImplicitAsWritten in atomic compare

tianshilei1992 added a comment. I will refine some logics to set `X`, `E`, etc. to avoid more `IgnoreImpCasts`. However, I don't know how to deal with type promotion in the condition statement. Here we consider the following case: if (x == e) { x = d; } `x` and `d` can be set easily w/o need

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

aaron.ballman added a comment. In D125723#3553705 , @rnk wrote: > In D125723#3553664 , @aaron.ballman > wrote: > >> In D125723#3550956 , @steplong >> wrote: >> >>> Appre

  1   2   3   >