tbaeder marked 2 inline comments as done.
tbaeder added inline comments.
================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:623
+ IntrusiveRefCntPtr<DiagnosticIDs> DiagID(new DiagnosticIDs());
+ struct TestDiagnosticConsumer : public DiagnosticConsumer {};
+
----------------
MaskRay wrote:
> delete `public`.
>
> Can you avoid using a derived DiagnosticConsumer?
I can use the `SimpleDiagnosticConsumer` class created earlier in the file.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125862/new/
https://reviews.llvm.org/D125862
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
