rovka added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:753
+                                  llvm::opt::ArgStringList &CmdArgs) {
+  if (TC.getTriple().isOSWindows()) {
+    CmdArgs.push_back("Fortran_main.lib");
----------------
mmuetzel wrote:
> Are those correct for MinGW? Should this be checking for 
> `TC.getTriple().isKnownWindowsMSVCEnvironment()` instead?
Right, I hadn't considered MinGW. Thanks for pointing it out, I'll update the 
patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to