nridge added a comment. It seems you have uploaded just the changes relative to the previous patch. If you made a second commit, you need to `squash` it into the first and resubmit.
Otherwise the test looks good, thanks! ================ Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:811 + )cpp", + // Template specialization + R"cpp( ---------------- nit: `// Explicit template specialization` to be a bit more specific Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126757/new/ https://reviews.llvm.org/D126757 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits