[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

steakhal updated this revision to Diff 429947. steakhal added a comment. Use `cast` and `dyn_cast` in `castAs` and `getAs` respecitvely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125709/new/ https://reviews.llvm.org/D125709 Files: clang/incl

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

steakhal marked an inline comment as done. steakhal added a comment. I had to fix the `doIt` to return `To` instead of `Optional` to make it work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125709/new/ https://reviews.llvm.org/D125709

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

jchlanda updated this revision to Diff 429956. jchlanda edited the summary of this revision. jchlanda added a reviewer: Anastasia. jchlanda added a comment. Herald added a subscriber: kosarev. Use helper functions when handling address space values. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, balazske, ASDenysPetrov, bzcheeseman, xazax.hun. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requeste

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:99-100 + template bool isa() const { return llvm::isa(*this); } + /// Convert to the specified SVal type, asserting that this SVal is of This is the

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

martong added a comment. In D125400#3508955 , @balazske wrote: > Function `mkdir` is modeled incorrectly by the checker. According to the man > page it can return 0 or -1 only (-1 is error) but the checker allows > non-negative value at success. So the

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

jchlanda added inline comments. Comment at: clang/include/clang/AST/Type.h:486 + bool IsSYCLOrOpenCL = false) { +if (ASMap) { + bool IsATargetAS = false; jchlanda wrote: > tra wrote: > > If A and B are both target AS

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

martong added a comment. In D125400#3516164 , @balazske wrote: > @martong Do you mean that a "describe" function is needed for the return > value constraint of the function and for the errno constraint type? Then a > note tag can contain what the functi

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:435 + assert(Cond); + State = State->assume(*Cond, true); + return errno_modeling::setErrnoValue(State, C.getLocationContext(), balazske wro

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

steakhal updated this revision to Diff 429960. steakhal added a comment. Refactor in the `getAs` uses of `clang/include/StaticAnalyzer` directory as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125749/new/ https://reviews.llvm.org/D125749

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

martong added a comment. > I'm not sure, shall I add tests? Yes, please. Unit tests for `dyn_cast` and `isa` should be easy. However, I am not sure how to test `cast` for the failure cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125709/new/

[PATCH] D125706: [analyzer][NFC] Use idiomatic classof instead of isKind

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125706/new/ https://reviews.llvm.org/D125706 _

[PATCH] D125707: [analyzer][NFC] Remove unused friend SVal declarations

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125707/new/ https://reviews.llvm.org/D125707 _

[PATCH] D125708: [analyzer][NFC] Remove unused default SVal constructors

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125708/new/ https://reviews.llvm.org/D125708 _

[clang] b250cca - [OpenCL] Do not guard vload/store_half builtins

Author: Sven van Haastregt Date: 2022-05-17T10:57:23+01:00 New Revision: b250cca11d5996ed01d72cb1f933867da0e8d5e0 URL: https://github.com/llvm/llvm-project/commit/b250cca11d5996ed01d72cb1f933867da0e8d5e0 DIFF: https://github.com/llvm/llvm-project/commit/b250cca11d5996ed01d72cb1f933867da0e8d5e0.

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGb250cca11d59: [OpenCL] Do not guard vload/store_half builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://review

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

linjamaki added a comment. From my point of view this patch LGTM. Comment at: clang/include/clang/Driver/Options.td:4164-4169 +def fintegrated_objemitter : Flag<["-"], "fintegrated-objemitter">, + Flags<[CoreOption, NoXarchOption]>, Group, +

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

krisb added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:689 auto ScopeDIE = DIE::get(DIEValueAllocator, dwarf::DW_TAG_lexical_block); + insertDIE(Scope->getScopeNode(), ScopeDIE); if (Scope->isAbstractScope()) In case of c

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

andrew abandoned this revision. andrew added a comment. Herald added a project: All. Replaced with D125756 D125757 D125758 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:181 + + static const auto Decltype = decltypeType(hasUnderlyingExpr(Call)); + static const auto TemplateArg = whisperity wrote: > whisperity wrote: > >

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

aaron.ballman added a comment. I know it's retroactive, but this also LGTM. Thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commi

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 ___ cfe-commits mailing lis

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

hans added inline comments. Comment at: clang/test/CodeGen/no-builtin-2.c:51 +// CHECK: {{.*}}call {{.*}} @memmove +void foo4(char *s, char *d, size_t n) __attribute__((no_builtin("*"))) { + bar(s); In AttrDocs.td it says the wildcard case is spelled "__attri

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 429997. kosarev added a comment. Herald added subscribers: ThomasRaoux, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, mravishankar, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb,

[PATCH] D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf

foad added inline comments. Comment at: llvm/lib/IR/ConstantRange.cpp:724 auto BW = getBitWidth(); -APInt Min = APInt::getMinValue(BW).zextOrSelf(ResultBitWidth); -APInt Max = APInt::getMaxValue(BW).zextOrSelf(ResultBitWidth); +APInt Min = APInt::getMinValue(BW);

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead created this revision. pcwang-thead added reviewers: asb, luismarques, kito-cheng, craig.topper. Herald added subscribers: sunshaoce, VincentWu, luke957, jeroen.dobbelaere, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, t

[clang] df2a4ea - [clang] Expose CoawaitExpr's operand in the AST

Author: Nathan Ridge Date: 2022-05-17T08:13:37-04:00 New Revision: df2a4eae6b190806c0b96ef3312975e1c97dbda0 URL: https://github.com/llvm/llvm-project/commit/df2a4eae6b190806c0b96ef3312975e1c97dbda0 DIFF: https://github.com/llvm/llvm-project/commit/df2a4eae6b190806c0b96ef3312975e1c97dbda0.diff

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf2a4eae6b19: [clang] Expose CoawaitExpr's operand in the AST (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

hans added inline comments. Comment at: clang/test/Driver/cl-zc.cpp:50 // RUN: %clang_cl /c -### /Zc:wchar_t- -- %s 2>&1 | FileCheck -check-prefix=WCHAR_T-OFF %s -// WCHAR_T-OFF: argument unused during compilation +// WCHAR_T-OFF: "-fno-wchar" Should probably

[PATCH] D125711: [concepts] Implement dcl.decl.general p4: No constraints on non-template funcs

erichkeane marked an inline comment as done. erichkeane added a comment. In D125711#3517065 , @royjacobson wrote: > Code and added/modified tests LGTM! > > Do you think we should add a release note, given that it could break existing > code? Its seems a

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:83-86 +void DiscardedReturnValueCheck::onStartOfTranslationUnit() { + ConsumedCalls.clear(); + CallMap.clear(); +} whisperity wrote: > aaron.ballma

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

aaron.ballman added a comment. Btw, I'm in C standards meetings all week this week, so my reviews are going to be delayed by a bit, just as an FYI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124446/new/ https://reviews.llvm.org/D124446 ___

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal updated this revision to Diff 430012. steakhal added a comment. This revision is now accepted and ready to land. - Copy the `mylib.h` under the build directory to have deterministic relative order to the LIT test file. - Use `SourceManager::isBeforeInTranslationUnit` instead of the fancy

[clang] 99639e5 - Enabling the detection of devtoolset-11 toolchain.

Author: Kamau Bridgeman Date: 2022-05-17T07:57:45-05:00 New Revision: 99639e5a3e6e7f3f207128fc3bfd707596d5ba59 URL: https://github.com/llvm/llvm-project/commit/99639e5a3e6e7f3f207128fc3bfd707596d5ba59 DIFF: https://github.com/llvm/llvm-project/commit/99639e5a3e6e7f3f207128fc3bfd707596d5ba59.dif

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

This revision was automatically updated to reflect the committed changes. Closed by commit rG99639e5a3e6e: Enabling the detection of devtoolset-11 toolchain. (authored by kamaub). Changed prior to commit: https://reviews.llvm.org/D125499?vs=429059&id=430013#toc Repository: rG LLVM Github Mon

[PATCH] D125769: [clang-tidy] Introduce the WarnIntoHeaders option to modernize-deprecated-headers

steakhal created this revision. steakhal added reviewers: aaron.ballman, whisperity, LegalizeAdulthood, alexfh. Herald added subscribers: carlosgalvezp, martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

steakhal created this revision. steakhal added reviewers: aaron.ballman, whisperity, LegalizeAdulthood, alexfh. Herald added subscribers: carlosgalvezp, martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal created this revision. steakhal added reviewers: aaron.ballman, whisperity, LegalizeAdulthood, alexfh. Herald added subscribers: martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:446 +} +const bool BState = State->contains(D); +if (!BState) { // This is the first time we see this foreign function. -

[clang-tools-extra] 86bc639 - [pseudo] Add the missing ; terminal for module-declaration rule.

Author: Haojian Wu Date: 2022-05-17T15:14:46+02:00 New Revision: 86bc6399a063439f2c58f9eed3ee6bf2d9276bf6 URL: https://github.com/llvm/llvm-project/commit/86bc6399a063439f2c58f9eed3ee6bf2d9276bf6 DIFF: https://github.com/llvm/llvm-project/commit/86bc6399a063439f2c58f9eed3ee6bf2d9276bf6.diff LO

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

pengfei added inline comments. Comment at: clang/test/Driver/x86-target-features.c:173 // LVIHARDENING: "-target-feature" "+lvi-load-hardening" "-target-feature" "+lvi-cfi" -// NO-LVIHARDENING-NOT: lvi +// NO-LVIHARDENING-NOT: "-target-feature" "+lvi How abou

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 430019. pengfei added a comment. Herald added subscribers: armkevincheng, eric-k256, javed.absar. Herald added a reviewer: sjarus. Rebased on the avx512fp16 implementation. Still WIP for optimizations and a fast RA issue. Repository: rG LLVM Github Monore

[clang] 6da3d66 - [concepts] Implement dcl.decl.general p4: No constraints on non-template funcs

Author: Erich Keane Date: 2022-05-17T06:21:51-07:00 New Revision: 6da3d66f03f9162ef341cc67218be40e22fe9808 URL: https://github.com/llvm/llvm-project/commit/6da3d66f03f9162ef341cc67218be40e22fe9808 DIFF: https://github.com/llvm/llvm-project/commit/6da3d66f03f9162ef341cc67218be40e22fe9808.diff L

[PATCH] D125711: [concepts] Implement dcl.decl.general p4: No constraints on non-template funcs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6da3d66f03f9: [concepts] Implement dcl.decl.general p4: No constraints on non-template funcs (authored by erichkeane). Herald added a project: clang.

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong updated this revision to Diff 430023. martong marked an inline comment as done. martong added a comment. - Change ctuBifurcate to use bool in GDM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123773/new/ https://reviews.llvm.org/D123773 Fi

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. This only shows up if one passes module maps to Clang in `-std=c++20` mod

[clang-tools-extra] 9c6a2f2 - Fix an unused variable warning in no-asserts build mode

Author: Dmitri Gribenko Date: 2022-05-17T15:27:44+02:00 New Revision: 9c6a2f29660b886044a267bb4de662cd801079bc URL: https://github.com/llvm/llvm-project/commit/9c6a2f29660b886044a267bb4de662cd801079bc DIFF: https://github.com/llvm/llvm-project/commit/9c6a2f29660b886044a267bb4de662cd801079bc.dif

[PATCH] D123784: [clang][analyzer][ctu] Traverse the ctu CallEnter nodes in reverse order

martong abandoned this revision. martong marked an inline comment as done. martong added a comment. Abandoning because by using a `bool` in `ctuBifurcate`, the CTUWorklist will not have more than one elements during the first phase. Details: https://reviews.llvm.org/D123773?id=426037#inline-1206

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

martong added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:31 + -std=c++11-or-later: +This flag will cause multiple runs withing the same check_clang_tidy +execution. Make sure you don't have shared state across these runs. -

[clang] 2def74b - Fix release note typo from 6da3d66f

Author: Erich Keane Date: 2022-05-17T06:35:06-07:00 New Revision: 2def74bef15a867d940520ddf3808d09b7fff95b URL: https://github.com/llvm/llvm-project/commit/2def74bef15a867d940520ddf3808d09b7fff95b DIFF: https://github.com/llvm/llvm-project/commit/2def74bef15a867d940520ddf3808d09b7fff95b.diff L

[PATCH] D125775: [ARM] Don't Enable AES Pass for Generic Cores

lenary created this revision. lenary added reviewers: john.brawn, dmgreen. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This brings clang/llvm i

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre updated this revision to Diff 430029. thopre marked an inline comment as done. thopre added a comment. Be more conservative in what we reject Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 Files:

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong added inline comments. Comment at: clang/test/CodeGen/no-builtin-2.c:51 +// CHECK: {{.*}}call {{.*}} @memmove +void foo4(char *s, char *d, size_t n) __attribute__((no_builtin("*"))) { + bar(s); hans wrote: > In AttrDocs.td it says the wildcard case is

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

bzcheeseman added a comment. In D125709#3518096 , @steakhal wrote: > I had to fix the `doCast` to return `To` instead of `Optional` to make it > work. That's fine (or it should be!) but you can also just dereference the optional, right? Repository:

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, but I think this is choosing a (new) public name for clang modules/header modules, so maybe Richard or others might want to weigh in? Comment at: clang/lib/Driver/

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong updated this revision to Diff 430047. martong added a comment. - Update ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123773/new/ https://reviews.llvm.org/D123773 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski created this revision. awarzynski added reviewers: rovka, jeanPerier, peixin, kiranktp, Leporacanthicus, dpalermo, ekieri, schweitz, shraiysh, h-vetinari, rouson. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: clementval. Herald added pro

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added a comment. In D125683#3516911 , @mstorsjo wrote: > I guess that's better than silently (well, cmake warns, but it's easy to > miss) no longer doing what it used to, but it's not ideal IMO. I do my > continuous build testing with a build in

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne updated this revision to Diff 430051. ldionne added a comment. Don't remove the old options yet for backwards compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125683/new/ https://reviews.llvm.org/D125683 Files: clang/cmake/ca

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

steakhal added a comment. In D125709#3518242 , @martong wrote: >> I'm not sure, shall I add tests? > > Yes, please. Unit tests for `dyn_cast` and `isa` should be easy. However, I > am not sure how to test `cast` for the failure cases. What if we were us

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee added a comment. Thank you for your reviews, and sorry for the mess in my last comment. I'm new to clang/Phabricator and trying to get used to it :) Comment at: clang/lib/Sema/SemaType.cpp:5203 + T.isConstQualified() && + T->isStructureOrClassType()) { +

[PATCH] D125789: Fix release note typo from 6da3d66f

sheisc created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. sheisc requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The GNU assembler (used in gcc) complains about the syntactic

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

bzcheeseman accepted this revision. bzcheeseman added a comment. This revision is now accepted and ready to land. > In D125709#3519033 , @bzcheeseman > wrote: > >> In D125709#3518096 , @steakhal >> wrote: >> >>>

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

steakhal added a comment. Thanks for your help @bzcheeseman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125709/new/ https://reviews.llvm.org/D125709 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

ilya-biryukov updated this revision to Diff 430056. ilya-biryukov added a comment. - Revert gnu++20 fix - Always pass -fheader-modules/-fno-header-modules when modules are enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125773/new/ https://re

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks good to me after addressing Hans's comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

ilya-biryukov added a reviewer: rsmith. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. In D125773#3519048 , @sammccall wrote: > LG, but I think this is choosing a (new) public name for clang modules/header > modules, so ma

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong updated this revision to Diff 430060. steplong added a comment. - Removed `__attribute__((no_builtin("*")))` from test - Remove the logic that accepted `__attribute__((no_builtin("*")))` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 430062. sammccall added a comment. Address comments Add end-to-end test Move ownership of AsyncTaskRunner to allow blockUntilIdle() in test Fix bugs caught by end-to-end-test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang-tools-extra] ecaa4d9 - [clangd] Indexing of standard library

Author: Sam McCall Date: 2022-05-17T16:50:41+02:00 New Revision: ecaa4d9662c9a6ac013ac40a8ad72a2c75e3fd3b URL: https://github.com/llvm/llvm-project/commit/ecaa4d9662c9a6ac013ac40a8ad72a2c75e3fd3b DIFF: https://github.com/llvm/llvm-project/commit/ecaa4d9662c9a6ac013ac40a8ad72a2c75e3fd3b.diff LO

[PATCH] D115232: [clangd] Indexing of standard library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecaa4d9662c9: [clangd] Indexing of standard library (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. We accidently define two identical rules for user-defined-string-literal (one

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

DavidSpickett added a comment. Do you know how this will work with the llvm-testsuite runs that currrently use gfortran for codegen? Here is one we have: https://lab.llvm.org/buildbot/#/builders/179/builds/3694 Currently: 2022-05-17 13:06:53 INFO: Execute: /usr/bin/cmake -DCMAKE_C_COMPILER:

[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx.bnf:716 string-literal := string-literal-chunk -string-literal := string-literal string-literal-chunk +string-literal := string-literal-chunk string-literal user-defined-literal := user-defined-integer-l

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

sammccall added a comment. The intent here is that `user-defined-string-literal-chunk := STRING_LITERAL` only matches when there's a ud-suffix. And `string-literal-chunk := STRING_LITERAL` only matches when there isn't. (e.g. with a rule guard, which we don't have implemented) If this was happen

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

asb added a comment. Thanks for the patch - can you add test coverage for this please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125765/new/ https://reviews.llvm.org/D125765 ___ cfe-commits mailing l

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3519297 , @DavidSpickett wrote: > Can we expect the current `flang-new`, soon to be `flang` to also cope with > these tests (I have no expectations myself here, fine if not) or should we > move the bots to use `fl

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

krasimir added a comment. We found another regression with this in wrongly indenting/not putting on its own line ObjC `@interface`: % ./clang-format --version clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655) % cat t

[PATCH] D125789: Fix release note typo from 6da3d66f

pengfei added a comment. I guess a lot of lines of tests need to update $ grep -rn " {z}" llvm/test/CodeGen/X86/ | wc -l 7797 Comment at: clang/docs/ReleaseNotes.rst:368 unsigned character literals. This fixes `Issue 54886

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2156 Prefixes.push_back("/opt/rh/devtoolset-10/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-9/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-8/root/usr"); Mas

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal updated this revision to Diff 430069. steakhal marked an inline comment as done. steakhal added a comment. fix typo `withing` -> `within` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/ https://reviews.llvm.org/D125771 Files:

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

sheisc updated this revision to Diff 430067. sheisc retitled this revision from "Fix release note typo from 6da3d66f" to "FIX the assembly format of the x86 backend to make both clang and gcc happy". sheisc edited the summary of this revision. sheisc added a project: libc-project. Repository: r

[clang-tools-extra] 76ddbb1 - Revert "[clangd] Indexing of standard library"

Author: Sam McCall Date: 2022-05-17T17:17:27+02:00 New Revision: 76ddbb1ca747366417be64fdf79218df099a5973 URL: https://github.com/llvm/llvm-project/commit/76ddbb1ca747366417be64fdf79218df099a5973 DIFF: https://github.com/llvm/llvm-project/commit/76ddbb1ca747366417be64fdf79218df099a5973.diff LO

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

DavidSpickett added a comment. Sounds good to me. https://reviews.llvm.org/D125796 for the bot side, let me know if/when the first half of the change goes in. I'll leave it to others to approve the change overall. I do think being able to do `./bin/flang` and get the right flang will save a lot

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

pengfei added a comment. I think another way is to report the issue to GCC. From the perspective of the user, GCC should support both `{%k1} {z}` and `{%k1}{z}`. Then we don't need the clange on LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

sheisc abandoned this revision. sheisc added a comment. In D125789#3519361 , @pengfei wrote: > I guess a lot of lines of tests need to update > > $ grep -rn " {z}" llvm/test/CodeGen/X86/ | wc -l > 7797 Thanks. Yes. It seems to be a big revision, caus

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:546 + {"include/wordexp.h", ""}, + {"include/x86intrin.h", ""}, + {"include/xlocale.h", ""}, ilya-biryukov wrote: > ppluzhnikov wrote: >

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

sheisc added a comment. In D125789#3519411 , @pengfei wrote: > I think another way is to report the issue to GCC. From the perspective of > the user, GCC should support both `{%k1} {z}` and `{%k1}{z}`. Then we don't > need the clange on LLVM. Yes. It i

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

asb added a comment. Based on the discussion we had, I think this makes sense. It's a bit repetitive, but could you please add a test to clang/test/Driver that checks the list of enabled features for generic (and for completeness, probably bleeding-edge as well). Thanks. Repository: rG LLVM

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

asb added a comment. Oh, and per recent updates to the LLVM Developer policy I think it would be worth updating the Clang ReleaseNotes.rst to mention this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

pengfei added a comment. In D125789#3519433 , @sheisc wrote: > In D125789#3519411 , @pengfei wrote: > >> I think another way is to report the issue to GCC. From the perspective of >> the user, GCC should support

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

sheisc added a comment. In D125789#3519493 , @pengfei wrote: > In D125789#3519433 , @sheisc wrote: > >> In D125789#3519411 , @pengfei >> wrote: >> >>> I think another way

[PATCH] D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf

reames added a comment. Coming into this late, but I'd have preferred to see this separated into at least two pieces. One for each "non-obvious" adjustment, and one final one which just did the replace on the renaming sites. This differs from feedback from other reviewers above, so don't feel

[PATCH] D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy

craig.topper added a comment. Is it gcc that needs a fix or binutils? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125789/new/ https://reviews.llvm.org/D125789 ___ cfe-commits mailing list cfe-commits@l

  1   2   >