tstellar added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2156
     Prefixes.push_back("/opt/rh/devtoolset-10/root/usr");
     Prefixes.push_back("/opt/rh/devtoolset-9/root/usr");
     Prefixes.push_back("/opt/rh/devtoolset-8/root/usr");
----------------
MaskRay wrote:
> The detection is wasted every Linux user (even if they don't use 
> RedHat/Fedora). Some may need to be refactored to detect `/opt/rh` first. 
> Some ancient devtoolset-* may be deleted now.
@kamaub Are you planning to address these comments in a follow up change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125499/new/

https://reviews.llvm.org/D125499

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to