[PATCH] D123126: [cmake] Remove LLVM_ENABLE_NEW_PASS_MANAGER cmake option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed4e6e03981a: [cmake] Remove LLVM_ENABLE_NEW_PASS_MANAGER cmake option (authored by nikic). Herald added a project: clang. Herald added a subscriber:

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

sammccall added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:318 FileEntryRef ReturnedRef(*NamedFileEnt); - if (UFE.isValid()) { // Already have an entry with this inode, return it. + if (ReusingEntry) { // Already have an entry with this inode, return it.

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:872-883 +if (NewState && NewState != State) { + StringRef Note = Case.getNote(); + const NoteTag *Tag = C.getNoteTag( + // Sorry couldn't help myse

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

steakhal added a comment. In D122841#3431617 , @NoQ wrote: > I looked up the history. I believe this refers to > https://clang.llvm.org/docs/LanguageExtensions.html#memory-references-to-specified-segments: > >> Annotating a pointer with address space #25

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

awarzynski added a comment. In D123070#3429519 , @hans wrote: > I worry that the closing comments on '}'s might rot since there's no tooling > to maintain them though. I share your concern. However, from my experience these `let` statements rarely chan

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall created this revision. sammccall added reviewers: dexonsmith, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - isValid: FileManager only ever returns valid FileEntries (see next po

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:400 + /// then the return value is 0 + /// and the note may say "Assuming the character is non-alphabetical". + class SummaryCase { It would be

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

sammccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:519-521 +void setLangDefaults(LangOptions &Opts, Language Lang, const llvm::Triple &T, + std::vector &Includes, + LangStandard::Kind LangStd);

[PATCH] D122885: [clang] Draft: Implement P1703R1

iains added a comment. FWIW probably these 5 patches are pretty independent of changes to the preprocessor... ... the first four of those are extremely unlikely to clash - since they are concerned with the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains added a comment. @dblaikie - is the explanation for the change in diagnostics at the same time OK? (if not I can split the patch, but either way I'd like to land what is acceptable soonish). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1221

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao updated this revision to Diff 420764. rZhBoYao marked 2 inline comments as done. rZhBoYao added a reviewer: erichkeane. rZhBoYao added a comment. I think an extra parameter is inevitable without complicating things too much. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122981/n

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420770. dang added a comment. Manage PatchComponents stack manipulation using RAII to avoid forgetting to pop the stack when returning early from `serializeAPIRecord`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } QuietMisdreavus wrote: > dang wrote: >

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

RKSimon resigned from this revision. RKSimon added a comment. Sorry but this is not an area I know enough about to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 __

[clang] 77c74fd - [OpenCL] Remove argument names from math builtins

Author: Sven van Haastregt Date: 2022-04-06T11:43:59+01:00 New Revision: 77c74fd877b27418171693f187b8db865567b8dc URL: https://github.com/llvm/llvm-project/commit/77c74fd877b27418171693f187b8db865567b8dc DIFF: https://github.com/llvm/llvm-project/commit/77c74fd877b27418171693f187b8db865567b8dc.

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

iains added a comment. In D119409#3410893 , @ChuanqiXu wrote: > In D119409#3410868 , @iains wrote: > >> In D119409#3410474 , @ChuanqiXu >> wrote: >> >>> In D119409#340980

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 420771. hokein marked 12 inline comments as done. hokein added a comment. address review comments; rename methods; fix templatename::print and add a test; add a fixme for qualified template name; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein added a comment. In D123127#3429589 , @sammccall wrote: > This looks pretty good! > The tests in clang are sadly indirect. This is mostly due to the fact that `TemplateName` is not dumped. This patch extend the `NodeDumper` to print a `using` ind

[PATCH] D123200: [compiler-rt][AVR] Add initial support of target AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, ddunbar, howard.hinnant, samsonov, aykevl. Herald added subscribers: StephenFan, Jim, mgorny, dberris, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: Sanitizers, cfe

[PATCH] D123200: [compiler-rt][AVR] Add initial support of target AVR

benshi001 added a comment. Build `libclang_rt.builtins-avr.a` which contains math functions, such as `mulsi3`, `divmodsi4`, `mulsf3`, ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123200/new/ https://reviews.llvm.org/D123200 _

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang updated this revision to Diff 420773. dang added a comment. Address code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 Files: clang/include/clang/ExtractAPI/API.h clang/include

[clang] ba4482f - [clang][NFC] Add specificity to compatibility hack

Author: Nathan Sidwell Date: 2022-04-06T03:57:36-07:00 New Revision: ba4482f481991799a922d5cf124a56bea5866254 URL: https://github.com/llvm/llvm-project/commit/ba4482f481991799a922d5cf124a56bea5866254 DIFF: https://github.com/llvm/llvm-project/commit/ba4482f481991799a922d5cf124a56bea5866254.diff

[PATCH] D123119: [clang][NFC] Add specificity to compatibility hack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba4482f48199: [clang][NFC] Add specificity to compatibility hack (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

sammccall added a comment. Thanks, I think this is just about ready to go. Only substantive issue is I think we should address the QualifiedTemplate/UsingTemplate interaction in a more principled way. Comment at: clang/include/clang/AST/PropertiesBase.td:625 +let Class = Prope

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks lgtm! I would still be looking out for build bot statuses in case there are OS specific code paths that were using isvalid. it might also be worthwhile to send out `operator<` chang

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. Friendly ping. In D122748#3417500 , @erichkeane wrote: > would still like to see the feedback from the original submitter here to see > if there is more work to do in here that would be valuable. Unsure, maybe we can process w

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 420805. hokein marked an inline comment as done. hokein added a comment. address remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123127/new/ https://reviews.llvm.org/D123127 Files: clang-too

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein added inline comments. Comment at: clang/include/clang/AST/TemplateName.h:446 /// that this qualified name refers to. TemplateDecl *Template; sammccall wrote: > hokein wrote: > > sammccall wrote: > > > It seems really unfortunate that this is a `Te

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski created this revision. Herald added a subscriber: mgorny. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Support for generating LLVM BC files is added in Flang's compiler a

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Add support

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall updated this revision to Diff 420808. sammccall marked 2 inline comments as done. sammccall added a comment. Remove obsolete const_casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123197/new/ https://reviews.llvm.org/D123197 Files:

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall added a comment. In D123197#3432386 , @kadircet wrote: > thanks lgtm! I would still be looking out for build bot statuses in case > there are OS specific code paths that were using isvalid. Will do! > it might also be worthwhile to send out `

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

kadircet added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:462 UFE->Dir = &DirInfo->getDirEntry(); - UFE->UID = NextFileUID++; - UFE->IsValid = true; + UFE->UID = NextFileUID++; UFE->File.reset(); sammccall wrote: > kadircet wrot

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

unterumarmung added a comment. @ekieri, hello! Thank you for the comment, it is really helpful! It turns out that I've researched the issue poorly. Actually, `nvfortran` compiler forbids to use `INTENT` attribute on local variables, even though a "mod" file can be generated. It generates a sever

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

kadircet added a comment. thanks a lot for doing this! some drive-by comments Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:87 + // to handle the UsingTemplateName case. + bool TraverseTemplateName(TemplateName TN) { +if (const auto *UTN = TN.getAsUsingTemplateN

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers added a comment. Ahhh, I see - thanks for the references and discussion. I'll craft a patch to comprehend the use case and user-facing option, and post for review. We'll see how it goes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

rovka added a comment. Why not use the BackendAction for this? There seems to be a lot of shared code, up until the point where you create and use the pass manager (and in the future, when the backend switches to the new pass manager, there will be even more shared code). Co

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

sammccall added inline comments. Comment at: clang/include/clang/AST/TemplateName.h:404 + + TemplateName UnderlyingTN; + UsingShadowDecl *USD = nullptr; (Per offline discussion) The UnderlyingTN here seems like it would refer to the TemplateDecl pointed to by

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

erichkeane added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2906 +SkipBodyInfo *SkipBody = nullptr, +bool FnDeleted = false); Decl *ActOnStartOfFunctionDef(Scope *S, Decl *D, I t

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski updated this revision to Diff 420821. awarzynski added a comment. Herald added a reviewer: sscalpone. Add missing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123211/new/ https://reviews.llvm.org/D123211 Files: clang/include/cla

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:446 Outer.add(RD, Flags); // add(Decl) will despecialize if needed. +else if (const auto *UTN = + TST->getTemplateName().getAsUsingTemplateName()) -

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:60-61 const NamedDecl *D, const TemplateArgumentList *Innermost, -bool RelativeToPrimary, const FunctionDecl *Pattern) { +bool RelativeToPrimary, const FunctionDecl *Pattern, boo

[PATCH] D122535: [clang-tidy] Never consider assignments as equivalent in `misc-redundant-expression` check

njames93 added a comment. FWIW, False negatives are more tolerable than false positives in clang tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122535/new/ https://reviews.llvm.org/D122535 ___ cfe-c

[PATCH] D123182: [Concepts] Fix issue #53640

erichkeane added a comment. Can you improve the commit-message? Title in particular, but more details would be greatly appreciated. Comment at: clang/lib/Sema/SemaOverload.cpp:2955 /// FunctionParamTypesAreEqual - This routine checks two function proto types /// for equalit

[clang] 31c9711 - [PS4] clang-format PS4CPU.cpp/.h

Author: Paul Robinson Date: 2022-04-06T06:52:29-07:00 New Revision: 31c971145f5eef53e443fe7e9b137db6b5b6319d URL: https://github.com/llvm/llvm-project/commit/31c971145f5eef53e443fe7e9b137db6b5b6319d DIFF: https://github.com/llvm/llvm-project/commit/31c971145f5eef53e443fe7e9b137db6b5b6319d.diff

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall updated this revision to Diff 420832. sammccall added a comment. revert clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123197/new/ https://reviews.llvm.org/D123197 Files: clang/include/clang/Basic/DirectoryEntry.h

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:462 UFE->Dir = &DirInfo->getDirEntry(); - UFE->UID = NextFileUID++; - UFE->IsValid = true; + UFE->UID = NextFileUID++; UFE->File.reset();

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method

psamolysov-intel updated this revision to Diff 420831. psamolysov-intel retitled this revision from "[clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method" to "[clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method". psamolysov-intel edited the summary of this revis

[clang-tools-extra] 68eac9a - [clangd] Code action to declare missing move/copy constructor/assignment

Author: Sam McCall Date: 2022-04-06T16:14:42+02:00 New Revision: 68eac9a6e7a10eba8081bab340fda8be13a7840e URL: https://github.com/llvm/llvm-project/commit/68eac9a6e7a10eba8081bab340fda8be13a7840e DIFF: https://github.com/llvm/llvm-project/commit/68eac9a6e7a10eba8081bab340fda8be13a7840e.diff LO

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG68eac9a6e7a1: [clangd] Code action to declare missing move/copy constructor/assignment (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

sammccall added a comment. In D116514#3230255 , @njames93 wrote: > Shouldn't the constructors that need `std::move` also ensure the `` > header is also included, or at least transitively included. We don't want to > generate constructors that wont compi

[clang-tools-extra] afa9430 - [clangd] Add code action to generate a constructor for a C++ class

Author: Sam McCall Date: 2022-04-06T16:23:50+02:00 New Revision: afa94306a8c197e346d3234e5ac5292ab90eae73 URL: https://github.com/llvm/llvm-project/commit/afa94306a8c197e346d3234e5ac5292ab90eae73 DIFF: https://github.com/llvm/llvm-project/commit/afa94306a8c197e346d3234e5ac5292ab90eae73.diff LO

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

This revision was automatically updated to reflect the committed changes. Closed by commit rGafa94306a8c1: [clangd] Add code action to generate a constructor for a C++ class (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D116514?vs=419225&id=420840#toc Repository:

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

ekieri added a comment. Ok, good. Then please abandon this revision (Add Action... down by the comment box), so that its status is clear to everybody. Cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123113/new/ https://reviews.llvm.org/D1231

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8792-8794 +if (!isa(FromDi)) + if (auto *FromDiDC = dyn_cast(FromDi)) +if (FromDiDC->containsDecl(PrevFromDi)) martong wrote: > We should elevate this logic and

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 edited the summary of this revision. durin42 updated this revision to Diff 420854. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cx

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski updated this revision to Diff 420862. awarzynski added a comment. Move code a bit, add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123211/new/ https://reviews.llvm.org/D123211 Files: clang/include/clang/Driver/Options.td

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:483 + + llvm::ModulePassManager MPM; + llvm::ModuleAnalysisManager MAM; rovka wrote: > Nit: I think you can move these closer to their first use. Thanks, I thought that I _did_

[PATCH] D121838: [WIP] Generalize "check-all" umbrella targets, use for check-clang-tools

kbobyrev added a comment. I think this is no longer [WIP] but rather review-ready, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/new/ https://reviews.llvm.org/D121838 ___ cfe-commits mailin

[PATCH] D121838: [WIP] Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall added a comment. Ran into problems caused by check-clang-tools not running clangd tests again, probably worth In D121838#3433022 , @kbobyrev wrote: > I think this is no longer [WIP] but rather review-ready, right? It's both WIP and review-rea

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with a couple of small changes noted below. Comment at: clang/lib/CodeGen/BackendUtil.cpp:167 + /// Check whether we should emit a module summary. + /// The mo

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added a comment. Thanks for taking a look Diana! > Why not use the BackendAction for this? This action only requires the middle-end in LLVM :) The `BackendAction` will use the backend, but that's not needed here. > There seems to be a lot of shared code, up until the point where you

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

ChuanqiXu added a comment. In D122981#3432233 , @rZhBoYao wrote: > I think an extra parameter is inevitable without complicating things too much. My thought is that it might not be worth to fix the problem for the workaround. I feel like the problem is

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. I like the idea of using the RAII context/guard to manage the path components stack. I have one non-blocking comment about the rest of the patch now. Comme

[PATCH] D122734: [HIP] Fix mangling number for local struct

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122734/new/ https://reviews.llvm.org/D122734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang updated this revision to Diff 420875. dang marked 2 inline comments as done. dang added a comment. Address code review feedback: - Remove unnecessary code - Add a test to validate that everything works in the presence of header maps - Simplify existing test - Fix small nits Repository: r

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:72 +// primarily to resolve headers found via headermaps, as they remap +// locations. +const auto *FileInfo = PP.getHeaderSearchInfo().getExisti

[clang-tools-extra] af89e47 - [pseudo] Add crude heuristics to choose taken preprocessor branches.

Author: Sam McCall Date: 2022-04-06T17:22:35+02:00 New Revision: af89e4792d23779969c70284dcf6cfafa411637c URL: https://github.com/llvm/llvm-project/commit/af89e4792d23779969c70284dcf6cfafa411637c DIFF: https://github.com/llvm/llvm-project/commit/af89e4792d23779969c70284dcf6cfafa411637c.diff LO

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/DirectiveMap.cpp:329 +const auto &Tokens = Code.tokens(Dir.Tokens); +if (Tokens.empty() || Tokens.front().Kind != tok::hash) + return llvm::None; ---

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGaf89e4792d23: [pseudo] Add crude heuristics to choose taken preprocessor branches. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420883. dang marked an inline comment as done. dang added a comment. Make `SymbolGraphSerializer::serializeAPIRecord` const again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123045/new/ https://reviews.llvm.org

[PATCH] D123026: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

psamolysov-intel updated this revision to Diff 420888. psamolysov-intel retitled this revision from "[clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method" to "[clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary". psamolysov-intel edited the summary of this rev

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 420894. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/include/llvm/ADT/STLExtras.h llvm/unittests/ADT/STLExtrasTest.cpp Index: llvm/uni

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added a comment. Fixed the change, and added a new test. Hope the coverage is at a fairly good level now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 ___ cfe-commits mailing lis

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, akyrtzi. Herald added a subscriber: mgrang. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dep

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

jansvoboda11 updated this revision to Diff 420905. jansvoboda11 added a comment. Finish test description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123229/new/ https://reviews.llvm.org/D123229 Files: clang/include/clang/Lex/DirectoryLookup.h

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

aaron.ballman added a comment. > In D121838#3433022 , @kbobyrev > wrote: > >> I think this is no longer [WIP] but rather review-ready, right? > > It's both WIP and review-ready :-) > There are some mechanical cleanups left to do as mentioned in the commen

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 420915. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cxx1y-sized-deallocation.cpp clang/test/CodeG

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

tstellar added a comment. Can you elaborate more on the problem this is solving? Also, what are the user visible changes? Will check-all and check-clang run the same set of tests as before? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/ne

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall added a comment. In D121838#3433472 , @tstellar wrote: > Can you elaborate more on the problem this is solving? Also, what are the > user visible changes? Most directly, check-clang-tools does not currently run clangd or clang-pseudo tests, b

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

zixuw accepted this revision. zixuw added a comment. Unused include of declaration fragments in SymbolGraphSerializer. Otherwise LGTM! Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:17 #include "clang/ExtractAPI/API.h" +#include "clang/ExtractAPI/Dec

[PATCH] D123019: [clang][extract-api] Add support for typedefs

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! 🚢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 __

[PATCH] D123235: atomic compare fail : Parser & AST support

koops created this revision. koops added reviewers: dreachem, soumitra, tianshilei1992, cchen. Herald added a subscriber: arphaman. Herald added a project: All. koops requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

thakis added a comment. Normalizing to `\` seems better to me than normalizing to `/` too. I abstractly like changing as little as necessary at every stage, which in this case would mean changing just the slashiness of slashes that clang itself adds, so I'm still weakly in favor of that. But I

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420938. dang added a comment. Remove unnecessary include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123045/new/ https://reviews.llvm.org/D123045 Files: clang/include/clang/ExtractAPI/Serialization/SymbolGra

[clang] 28d7931 - [clang][extract-api] Fix small issues with SymbolGraphSerializer

Author: Daniel Grumberg Date: 2022-04-06T18:42:55+01:00 New Revision: 28d793144f2a5c92b83df3cc3d2772ec4cab0ad3 URL: https://github.com/llvm/llvm-project/commit/28d793144f2a5c92b83df3cc3d2772ec4cab0ad3 DIFF: https://github.com/llvm/llvm-project/commit/28d793144f2a5c92b83df3cc3d2772ec4cab0ad3.dif

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28d793144f2a: [clang][extract-api] Fix small issues with SymbolGraphSerializer (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3430706 , @erichkeane wrote: > In D122983#3427518 , @xbolva00 > wrote: > >> Could you please check that https://github.com/llvm/llvm-test-suite is >> buildable with you

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

cameron.mcinally added inline comments. Herald added a project: All. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; Sorry for the lat

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added a comment. In D122983#3433685 , @aaron.ballman wrote: > In D122983#3430706 , @erichkeane > wrote: > >> In D122983#3427518 , @xbolva00 >> wrote: >> >>>

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

dexonsmith accepted this revision. dexonsmith added a reviewer: benlangmuir. dexonsmith added a subscriber: benlangmuir. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Once we've removed the last use of `DirectoryEntry::getName()`, we should drop `DirectoryEnt

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:318 FileEntryRef ReturnedRef(*NamedFileEnt); - if (UFE.isValid()) { // Already have an entry with this inode, return it. + if (ReusingEntry) { // Already have an entry with this inode, return it.

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3433691 , @erichkeane wrote: > In D122983#3433685 , @aaron.ballman > wrote: > >> The `-Wimplicit-function-declaration` already exists today, so I believe we >> can land

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420946. cor3ntin added a comment. - Typo fixes for invalid code points Add a method `NearestMatchesForCodepointName` that will return the N closest valid codepoints, by edit distance. This is used to detect typos in named escape sequences in literals. - Add

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

tomrittervg added a comment. Just a note - I was able to test this finally and it works for what I was trying to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/ https://reviews.llvm.org/D123155 __

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 planned changes to this revision. durin42 added a comment. I'll hold off on this one until the other LLVM patches are done, then mail out the clang work as its own logical unit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ htt

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang updated this revision to Diff 420950. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 Files: clang/include/clang/ExtractAPI/API.h clang/incl

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

dexonsmith added a comment. > The ugly part here: > > - FileEntryTest was constructing dummy FileEntrys to wrap in FileEntryRef > - I changed this to use a FileManager as a factory It's not clear *why* you changed this to use a FileManager as a factory. It seems unrelated to removing `FileEntry:

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan requested changes to this revision. urnathan added a comment. This revision now requires changes to proceed. Either update this when you're ready, or abandon and create a new one for 1857. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12288

[clang] 482fad4 - [clang][DOC] Document module mangler changes

Author: Nathan Sidwell Date: 2022-04-06T11:13:32-07:00 New Revision: 482fad4a3fcb013aa19e97661e3d66583d026bb8 URL: https://github.com/llvm/llvm-project/commit/482fad4a3fcb013aa19e97661e3d66583d026bb8 DIFF: https://github.com/llvm/llvm-project/commit/482fad4a3fcb013aa19e97661e3d66583d026bb8.diff

  1   2   >