dang marked 2 inline comments as done. dang added inline comments.
================ Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:72 + // primarily to resolve headers found via headermaps, as they remap + // locations. + const auto *FileInfo = PP.getHeaderSearchInfo().getExistingFileInfo(File); ---------------- cishida wrote: > How is this searching by the way the header was included? It looks like > comparisons are based on file locations as `KnownIncludes` stores file paths. Upon second thought and further testing all this stuff isn't needed because we always construct the input buffer using `#include "ABSOLUTE_PATH"`. I have added a test to validate that this works when using a header map. If we ever move to relative includes, then we should change how this to use only include string comparisons (potentially caching the FileEntries as a performance optimization). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123148/new/ https://reviews.llvm.org/D123148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
