kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks lgtm! I would still be looking out for build bot statuses in case there
are OS specific code paths that were using isvalid. it might also be worthwhile
to send out `operator<` change in a separate commit, just to give downstream
users an opportunity to handle fixes for the two in isolation (or reverts if
need be).
================
Comment at: clang/lib/Basic/FileManager.cpp:462
UFE->Dir = &DirInfo->getDirEntry();
- UFE->UID = NextFileUID++;
- UFE->IsValid = true;
+ UFE->UID = NextFileUID++;
UFE->File.reset();
----------------
nit: revert formatting
================
Comment at: clang/unittests/Basic/FileEntryTest.cpp:45
return DirectoryEntryRef(
*Dirs.insert({Name, const_cast<DirectoryEntry &>(Base.getDirEntry())})
.first);
----------------
no need for const_cast here anymore, right?
================
Comment at: clang/unittests/Basic/FileEntryTest.cpp:60
{Name, FileEntryRef::MapValue(
const_cast<FileEntry &>(Base.getFileEntry()), DR)})
.first);
----------------
similarly we can drop the const_cast here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123197/new/
https://reviews.llvm.org/D123197
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
