[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added a comment. Can somebody commit this? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723/new/ https://reviews.llvm.org/D121723 ___ cfe-commits mailing list cfe-c

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

skan added a comment. In D120395#3365622 , @craig.topper wrote: >> So at this point we have these options: >> >> 1. Make the `__m[128|256|512]bh` types aliases of `__m[128|256|512]i` >> 2. Deprecate the `__m[128|256|512]bh` types and replace them with >

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

ChuanqiXu added a comment. In D121723#3384962 , @Endill wrote: > Can somebody commit this? I don't have commit access. Hi, what's your prefered name and email addressed? I would love to commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added a comment. In D121723#3384982 , @ChuanqiXu wrote: > In D121723#3384962 , @Endill wrote: > >> Can somebody commit this? I don't have commit access. > > Hi, what's your prefered name and email addressed

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added a comment. Somehow the bot can't create a branch when trying to merge this patch. The error is failure to lock. The error persists after restarting the process. Does anyone know why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[clang] a603f56 - [clang] CWG 2354: prohibit alignas for enums

Author: Vlad Serebrennikov Date: 2022-03-16T15:48:18+08:00 New Revision: a603f566dbe04d8a9eb0ada67b585965945f7e6d URL: https://github.com/llvm/llvm-project/commit/a603f566dbe04d8a9eb0ada67b585965945f7e6d DIFF: https://github.com/llvm/llvm-project/commit/a603f566dbe04d8a9eb0ada67b585965945f7e6d.

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

This revision was automatically updated to reflect the committed changes. Closed by commit rGa603f566dbe0: [clang] CWG 2354: prohibit alignas for enums (authored by Endill, committed by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415719. cor3ntin added a comment. Add more tests for implicitely constexpr lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.r

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415720. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnos

[PATCH] D121775: [clangd] Handle more than two conflicting semantic tokens in resolveConflict()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. In D120540#3384644 , @ChuanqiXu wrote: > @rsmith told me that the ideal situation would combine C++20 modules and > clang modules together in D113391 Maybe I understand something slightly differe

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

MyDeveloperDay added a comment. Firstly thank you for taking the time to submit the patch, I've only taken a cursory view at first and I definitely have some comments, I've added the main clang-format reviewers This is a very invasive patch so there are a number of things we might want to do t

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge added inline comments. Herald added projects: clang-tools-extra, All. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157 +resolveConflict(ArrayRef Tokens) { + if (Tokens.size() != 2) +return llvm::None; nridge wrote: > sammccall wrote:

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains added a comment. In D121098#3384590 , @ChuanqiXu wrote: > In D121098#3383835 , @iains wrote: > >>> I am a little bit confused for the intuition. Couldn't we just import the >>> pre-processed header? What's

[PATCH] D121779: [RISCV] Add zihintntl instructions

alextsao1999 created this revision. alextsao1999 added a reviewer: s. Herald added subscribers: VincentWu, luke957, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked 7 inline comments as done. tbaeder added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:1105 void clearListOnly() { ParsedAttributesView::clearListOnly(); Range = SourceRange(); aaron.ballman wrote: > erichkeane wro

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 415729. tbaeder marked an inline comment as done. tbaeder added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Remove `ParsedAttributesViewWithRange` and address other review comments. CHANGES SINCE LAST ACTION https://

[clang] 7fb2d9f - [clang-format] Fix crashes due to missing l_paren

Author: Owen Pan Date: 2022-03-16T01:45:20-07:00 New Revision: 7fb2d9f9b5efaf15c10711826b496ee65f70491d URL: https://github.com/llvm/llvm-project/commit/7fb2d9f9b5efaf15c10711826b496ee65f70491d DIFF: https://github.com/llvm/llvm-project/commit/7fb2d9f9b5efaf15c10711826b496ee65f70491d.diff LOG:

[PATCH] D121682: [clang-format] Fix crashes due to missing l_paren

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fb2d9f9b5ef: [clang-format] Fix crashes due to missing l_paren (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121682/new/ https://rev

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2241 +**BreakBetweenInstancePorts** (``Boolean``) :versionbadge:`clang-format 15` + For Verilog, put each port on its own line in module instantiations. I don't feel "Inst

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 415734. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c cla

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains marked 3 inline comments as done. iains added a comment. In D121588#3384799 , @vsapsai wrote: > Sorry, I'm pretty ignorant in this area but based on > >> The job construction is altered to build a C++20 header unit (rather than a >> PCH file, as wo

[PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The change looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121746/new/ https://reviews.llvm.org/D121746 _

[PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75acad41bcd6: Use lit_config.substitute instead of foo % lit_config.params everywhere (authored by sammccall). Repository: rG LLVM Github Monorepo

[PATCH] D121779: [RISCV] Add zihintntl compressed instructions

alextsao1999 updated this revision to Diff 415737. alextsao1999 added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121779/new/ https://reviews.llvm.org/D121779 Files: llvm/lib/Target/RISCV/RISCVInstrInfoC.td llvm/test/MC/RIS

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1373 + else if (!Current.isOneOf(tok::comment, tok::identifier) && + !Keywords.isPPHash(Current, Style) && !Current.isStringLiteral()) State.StartOfStringLiteral = 0; -

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

MyDeveloperDay added a comment. I'm very much a "clang-format all the things" kind of person which is why I added C# and JSON support, as someone who moves between languages all day every day I want one tool to rule them all.. I'd love it if it would format YAML (but thats another story).. For

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:2161 -if (PrevToken->isOneOf(tok::l_paren, tok::l_square, tok::l_brace, - to

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

curdeius added a comment. No objections here, but I need to see other patches to understand where it takes us before accepting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121755/new/ https://reviews.llvm.org/D121755 ___

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains added a comment. In D121589#3381989 , @ChuanqiXu wrote: > In D121589#3381894 , @iains wrote: > >> In D121589#3381343 , @ChuanqiXu >> wrote: >> It's not practic

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

krasimir added inline comments. Comment at: clang/lib/Format/Format.cpp:3451 +for (auto Suffix : Lang.second) + if (FileName.endswith(Suffix)) +return Lang.first; I kinda prefer the old style of handling this I find it simpler to read. I'd be OK

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal updated this revision to Diff 415747. steakhal added a comment. Fix the single case when the `Sep` was not forwarded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121387/new/ https://reviews.llvm.org/D121387 Files: clang/test/Analysis/diagnostics/Inputs/expected-sarif/sari

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal added a comment. I'd like to reach a wider consensus regarding this patch. @aaron.ballman @NoQ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121387/new/ https://reviews.llvm.org/D121387 ___ cfe-commits mailing list cfe-commits@lists.

[clang] 0aab344 - [Clang] Allow "ext_vector_type" applied to Booleans

Author: Simon Moll Date: 2022-03-16T11:10:32+01:00 New Revision: 0aab344104034e6191114a74f0d9eb5129bf550d URL: https://github.com/llvm/llvm-project/commit/0aab344104034e6191114a74f0d9eb5129bf550d DIFF: https://github.com/llvm/llvm-project/commit/0aab344104034e6191114a74f0d9eb5129bf550d.diff LO

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0aab34410403: [Clang] Allow "ext_vector_type" applied to Booleans (authored by simoll). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 415757. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/ParsedAttr.h clang/include/clang/Sema/Se

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll added a comment. @kaz7 With rG0aab34410403 in tree you should be able to enable the masked intrinsics now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121586/new/ http

[clang] a7c08bc - [flang][driver] Add support for `-mllvm`

Author: Andrzej Warzynski Date: 2022-03-16T10:41:04Z New Revision: a7c08bcf777ee0712c140052d0814f55a02dd27b URL: https://github.com/llvm/llvm-project/commit/a7c08bcf777ee0712c140052d0814f55a02dd27b DIFF: https://github.com/llvm/llvm-project/commit/a7c08bcf777ee0712c140052d0814f55a02dd27b.diff

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7c08bcf777e: [flang][driver] Add support for `-mllvm` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.l

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

iains added a comment. In D121590#3381344 , @ChuanqiXu wrote: > This looks a little bit odd. Is this consistent with GCC too? It is consistent, GCC does not warm for this - but that was not the primary motivation in this case. This is simply a convenie

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

iains added a comment. In D121591#3381348 , @ChuanqiXu wrote: > Oh, I found all the series of patches looks confusing to me. Maybe due to > that I lack a use experience with header unit. I really couldn't judge if it > is necessary or useful. Could you

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

hokein added a comment. I think this patch is probably doing too much: 1. move CLANG_TOOLS_DIR to `configure_site_lit_cfg()` 2. rename. Can we split it into two patches? Land the first part, and the second part afterwards. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 +

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 415769. kwk added a comment. - Use std::numeric_limits::max() instead of INT_MAX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cpp cl

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk marked an inline comment as done. kwk added a comment. Addressed review comments. Comment at: clang/lib/Format/Format.cpp:2779 /*CheckMainHeader=*/!MainIncludeFound && FirstIncludeBlock); -int Priority = Categories.getSortIncludePriority( -I

[PATCH] D119479: [clang][extract-api] Add global record support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Looks mostly good now. Comment at: clang/include/clang/SymbolGraph/API.h:99 + + GlobalRecord *addGlobal(GVKind Kind, StringRef Name, SmallString<128> &USR, +

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon added a comment. In D121327#3383733 , @yln wrote: > New revision here: D121736 FYI - you could have continued to use this phab for review, it makes it easier to compare the changes you've made Repository: r

[clang] 1e25ff8 - [clang][deps] Fix traversal of precompiled dependencies

Author: Jan Svoboda Date: 2022-03-16T12:17:53+01:00 New Revision: 1e25ff84d89e94ec7af6352b02e2d74a5e273a85 URL: https://github.com/llvm/llvm-project/commit/1e25ff84d89e94ec7af6352b02e2d74a5e273a85 DIFF: https://github.com/llvm/llvm-project/commit/1e25ff84d89e94ec7af6352b02e2d74a5e273a85.diff L

[clang] 6007b0b - [clang][deps] NFC: Use range-based for loop instead of iterators

Author: Jan Svoboda Date: 2022-03-16T12:17:53+01:00 New Revision: 6007b0b67bcb7c446f012357e34d5cd3b6c58d88 URL: https://github.com/llvm/llvm-project/commit/6007b0b67bcb7c446f012357e34d5cd3b6c58d88 DIFF: https://github.com/llvm/llvm-project/commit/6007b0b67bcb7c446f012357e34d5cd3b6c58d88.diff L

[clang] 77924d6 - [clang][deps] Modules don't contribute to search path usage

Author: Jan Svoboda Date: 2022-03-16T12:17:52+01:00 New Revision: 77924d60efa8b3a0278361fe77403a71576c9349 URL: https://github.com/llvm/llvm-project/commit/77924d60efa8b3a0278361fe77403a71576c9349 DIFF: https://github.com/llvm/llvm-project/commit/77924d60efa8b3a0278361fe77403a71576c9349.diff L

[clang] d73daa9 - [clang][deps] Don't prune search paths used by dependencies

Author: Jan Svoboda Date: 2022-03-16T12:17:53+01:00 New Revision: d73daa9135463ad4d4a08a9f0a75e109f921ad54 URL: https://github.com/llvm/llvm-project/commit/d73daa9135463ad4d4a08a9f0a75e109f921ad54 DIFF: https://github.com/llvm/llvm-project/commit/d73daa9135463ad4d4a08a9f0a75e109f921ad54.diff L

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG77924d60efa8: [clang][deps] Modules don't contribute to search path usage (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D121295?vs=415381&id=415776#toc Repository: rG

[PATCH] D121685: [clang][deps] NFC: Use range-based for loop instead of iterators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6007b0b67bcb: [clang][deps] NFC: Use range-based for loop instead of iterators (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CH

[PATCH] D121303: [clang][deps] Don't prune search paths used by dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd73daa913546: [clang][deps] Don't prune search paths used by dependencies (authored by jansvoboda11). Changed prior to commit: https://reviews.llv

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e25ff84d89e: [clang][deps] Fix traversal of precompiled dependencies (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.or

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains marked 3 inline comments as done. iains added inline comments. Comment at: clang/lib/Frontend/FrontendOptions.cpp:30-31 .Case("cppm", Language::CXX) + .Case("iih", InputKind(Language::CXX).getPreprocessed()) .Case("iim", InputKind(Language::CXX).getPrepro

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Herald added a project: All. Abandoning this. We don't need to collect usage info from `-fimplicit-module-maps` because we don't use that feature during explicit builds: D120465 . Support for us

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet added a comment. Thanks, LG in general. I suppose the extra timing overhead should be negligible, considering the preamble build times but would be nice to see some numbers if you have any. Apart from that I've raised the concern around multiple preamble builds finishing in parallel an

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

MattDevereau created this revision. MattDevereau added reviewers: peterwaller-arm, paulwalker-arm, DavidTruby, bsmith. Herald added subscribers: ctetreau, psnobl, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. MattDevereau requested review of th

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

Szelethus added a comment. Seems like all new files are missing the header blurb about the licence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121197/new/ https://reviews.llvm.org/D121197 ___ cfe-comm

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

aaron.ballman added a comment. In D119609#3384568 , @junaire wrote: > Hi @aaron.ballman @erichkeane, I have already left a comment in GCC's > Bugzilla, but unfortunately there's been no response for almost a week. I'm > even not sure there's really a bu

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

sgatev added a comment. In D121197#3385669 , @Szelethus wrote: > Seems like all new files are missing the header blurb about the licence. Thanks for spotting that! I'll prepare a patch to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall added a comment. In D121763#3385492 , @hokein wrote: > I think this patch is probably doing too much: 1. move CLANG_TOOLS_DIR to > `configure_site_lit_cfg()` 2. rename. > > Can we split it into two patches? Land the first part, and the second p

[clang] 85db3a2 - [clang][deps] Attempt to fix test on Windows

Author: Jan Svoboda Date: 2022-03-16T13:36:32+01:00 New Revision: 85db3a27cf8118b89a6759757fb3b6fccb96db96 URL: https://github.com/llvm/llvm-project/commit/85db3a27cf8118b89a6759757fb3b6fccb96db96 DIFF: https://github.com/llvm/llvm-project/commit/85db3a27cf8118b89a6759757fb3b6fccb96db96.diff L

[clang] f9096b8 - [clang][deps] NFC: Align path separator conversion in tests

Author: Jan Svoboda Date: 2022-03-16T13:40:09+01:00 New Revision: f9096b89ddc1efe30fc6235abf79253544831fe0 URL: https://github.com/llvm/llvm-project/commit/f9096b89ddc1efe30fc6235abf79253544831fe0 DIFF: https://github.com/llvm/llvm-project/commit/f9096b89ddc1efe30fc6235abf79253544831fe0.diff L

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. In D119609#3385671 , @aaron.ballman wrote: > In D119609#3384568 , @junaire wrote: > >> Hi @aaron.ballman @erichkeane, I have already left a comment in GCC's >> Bugzilla, but unfortunatel

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

MyDeveloperDay added a comment. You need to rebase the patch, it doesn't apply. Comment at: clang/lib/Format/Format.cpp:3451 +for (auto Suffix : Lang.second) + if (FileName.endswith(Suffix)) +return Lang.first; krasimir wrote: > I kinda prefer

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch introduces `DataflowModel`, a virtual base class for

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs, mgorny. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Chromium's implementation of assertions (`CHECK`, `DCHEC

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Just NFC nits from me with coding style stuff, so this LGTM! Feel free to fix the style nits when you land or land this as-is and do an NFC commit to fix them. ===

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

aaron.ballman added a comment. In D63085#3384302 , @iamsergio wrote: > I don't think we need to worry about formatting, that's the IDE's job (and > whatever formatter it uses). > In general, the code that knows how to warn should also be the one that know

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

aaron.ballman added a comment. In D120952#3384239 , @ajohnson-uoregon wrote: > For the specific argument matchers (`cudaBlockDim()`, `cudaStream()`, etc), I > agree, I'm not sure if there's any other use cases in tree. I wasn't aware > you could write

[PATCH] D121119: [clang][SVE] Add support for bitwise operators on SVE types

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. LGTM, modulo that the require lines look like they need fixing. Comment at: clang/test/CodeGen/aarch64-sve-vector-bitwise-ops.c:7 + +// AND + --

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

erichkeane added a comment. 1 small request, otherwise LGTM. Comment at: clang/lib/AST/Type.cpp:3330 + case EST_Uninstantiated: +return CT_Dependent; Slight preference for moving just this line to 3351 (above or below) to get the fallthrough behavior on

[PATCH] D120956: [clang][AST matchers] new AST matcher argumentsGivenCountIs(n) that checks the actual number of arguments given in a function call

aaron.ballman added a comment. In D120956#3384416 , @ajohnson-uoregon wrote: > When we're doing matcher generation, we aren't able to look up the > FunctionDecl and see if there are defaults (because the function name itself > might be a parameter for

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415805. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-noexcept.cpp Index: clang/test/SemaTemplate/class-template-noexcept.cpp =

[PATCH] D120959: [clang][AST matchers] new hasExpectedReturnType submatcher for ReturnStmts

aaron.ballman added a comment. In D120959#3384525 , @ajohnson-uoregon wrote: > This is our use case: > https://github.com/ajohnson-uoregon/llvm-project/blob/feature-ajohnson/clang-tools-extra/clang-rewrite/MatcherGenCallback.h#L365 > > I'm not sure if

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM! Let me know if you need me to commit this for you (and if so, what name/email address you'd like it committed under). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1214

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:148-149 +/// b) Models should focus on _modeling_ a particular aspect of program +///semant

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

sdesmalen accepted this revision. sdesmalen added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:530-531 + IntrinsicInst &II) { + IRBuilder<> Bui

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou added a comment. In D121498#3385896 , @erichkeane wrote: > LGTM! Let me know if you need me to commit this for you (and if so, what > name/email address you'd like it committed under). Thank you for your guidance! I do need you to commit th

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

aaron.ballman added reviewers: urnathan, iains, ChuanqiXu. aaron.ballman added a comment. In D121497#3383910 , @compnerd wrote: > This was something that I was hitting an issue with. Does cl hit the same issue when building a module that includes intsafe

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:139 +/// Virtual base class for "dataflow models": reusable analysis components that +/// model a particular aspect of program semantics, with respect to a specific -

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp:16-17 +namespace dataflow { +/// Determines whether `D` is one of the methods used to implement Chromium's +/// `CHECK` macros. +bool isCheckLikeMethod(llvm::SmallDenseSet

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

ymandel updated this revision to Diff 415817. ymandel added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121796/new/ https://reviews.llvm.org/D121796 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysi

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30adb9fd2797: let EST_Uninstantiated in FunctionProtoType::canThrow return (authored by zhouyizhou, committed by erichkeane). Repository: rG LLVM

[clang] 30adb9f - let EST_Uninstantiated in FunctionProtoType::canThrow return

Author: Zhouyi Zhou Date: 2022-03-16T07:09:42-07:00 New Revision: 30adb9fd279785d18f9902ba980c7d8b31a6c8d7 URL: https://github.com/llvm/llvm-project/commit/30adb9fd279785d18f9902ba980c7d8b31a6c8d7 DIFF: https://github.com/llvm/llvm-project/commit/30adb9fd279785d18f9902ba980c7d8b31a6c8d7.diff L

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:139 +/// Virtual base class for "dataflow models": reusable analysis components that +/// model a particular aspect of program sema

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 415821. ymandel added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files: clang/include/clang/Analysis/FlowSensitive/Models/ChromiumCheckMode

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:206 + +EXPECT_TRUE(Env.flowConditionImplies(*FooVal)); + }; gribozavr2 wrote: > Sorry, could you e

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

iains added a comment. could we see an example of the modular code that fails (and what flavour of modules compilation is being used)? or is there already a PR for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121497/new/ https://reviews.llv

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

hokein added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 + # Like LLVM_{TOOLS,LIBS}_DIR, but pointing at the build tree. + string(REPLACE "${CMAKE_CFG_INTDIR}" "${LLVM_BUILD_MODE}" CURRENT_TOOLS_DIR "${LLVM_RUNTIME_OUTPUT_INTDIR}") + string(REPLACE "${C

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 + # Like LLVM_{TOOLS,LIBS}_DIR, but pointing at the build tree. + string(REPLACE "${CMAKE_CFG_INTDIR}" "${LLVM_BUILD_MODE}" CURRENT_TOOLS_DIR "${LLVM_RUNTIME_OUTPUT_INTDIR}") + string(REPLACE "

[PATCH] D121775: [clangd] Handle more than two conflicting semantic tokens in resolveConflict()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121775/new/ https://reviews.llvm.org/D121775 __

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157 +resolveConflict(ArrayRef Tokens) { + if (Tokens.size() != 2) +return llvm::None; nridge wrote: > nridge wrote: > > sammccall wrote: > > > why a limit of 2, vs

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 + # Like LLVM_{TOOLS,LIBS}_DIR, but pointing at the build tree. + string(REPLACE "${CMAKE_CFG_INTDIR}" "${LLVM_BUILD_M

[clang-tools-extra] e5b1b9e - [pseudo] Cleanup the leftover header guards after the movement, NFC.

Author: Haojian Wu Date: 2022-03-16T16:25:18+01:00 New Revision: e5b1b9edb8b6f6cd926c2ba3e1ad1b6f767021d6 URL: https://github.com/llvm/llvm-project/commit/e5b1b9edb8b6f6cd926c2ba3e1ad1b6f767021d6 DIFF: https://github.com/llvm/llvm-project/commit/e5b1b9edb8b6f6cd926c2ba3e1ad1b6f767021d6.diff LO

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, saudi. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D92191 , a bunch o

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Herald added a project: All. Abandoning this. We don't need to collect usage info from -fimplicit-module-maps because we don't use that feature during explicit builds: D120465 . Support for usag

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:150-151 +///should relate to each other -- that is, how they should compose. Open +///questions include: Do we want to enable composition of models that have +///

  1   2   3   >