sgatev accepted this revision.
sgatev added inline comments.
This revision is now accepted and ready to land.
================
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:148-149
+/// b) Models should focus on _modeling_ a particular aspect of program
+/// semantics -- for example, a type and its related functions, and should
be
+/// composable with other models over the same lattice.
+///
----------------
Do we want to compose models that have different lattice types? Do we want to
have models with no lattices that only use `Environment`? If we don't know this
yet, I suggest replacing this with a FIXME to explore model composability at a
later point when we have answers to these questions.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:153
+/// the analysis.
+template <typename Lattice>
+class DataflowModel : public Environment::ValueModel {
----------------
`LatticeT` for consistency with the code above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121796/new/
https://reviews.llvm.org/D121796
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
