ymandel marked 3 inline comments as done. ymandel added inline comments.
================ Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:206 + + EXPECT_TRUE(Env.flowConditionImplies(*FooVal)); + }; ---------------- gribozavr2 wrote: > Sorry, could you explain how this works? I think the flow condition should > not be implying 'Foo' since we're supposed to ignore this unrelated Check() > call. Good catch -- that was a typo (and the test was failing -- I'd gone back and forth on the formulation and uploaded at the wrong point). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
