[PATCH] D119319: [AArch64] Emit TBAA metadata for SVE load/store intrinsics

sdesmalen created this revision. Herald added subscribers: ctetreau, jeroen.dobbelaere, kosarev, hiraditya, kristof.beyls, tschuett. sdesmalen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In Clang we can attach TBAA me

[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

hokein updated this revision to Diff 407062. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118990/new/ https://reviews.llvm.org/D118990 Files: clang/include/clang

[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:146 +// derived from X. (Known as FIRST sets in grammar-based parsers). +std::vector> firstSets(const Grammar &); +// For each nonterminal X, computes the set of terminals that could imm

[clang] fe932a8 - [pseudo] Add first and follow set computation in Grammar.

Author: Haojian Wu Date: 2022-02-09T09:16:27+01:00 New Revision: fe932a88e970d707c0759fae1f211d0f40ca06da URL: https://github.com/llvm/llvm-project/commit/fe932a88e970d707c0759fae1f211d0f40ca06da DIFF: https://github.com/llvm/llvm-project/commit/fe932a88e970d707c0759fae1f211d0f40ca06da.diff LO

[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe932a88e970: [pseudo] Add first and follow set computation in Grammar. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping^2. It would be great if this could be reviewed/commited soon: it fixes hundreds of testsuite failures, so I'd like to get it into LLVM 14. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews

[clang] 69c3309 - [flang][driver] Add support for `-emit-mlir`

Author: Andrzej Warzynski Date: 2022-02-09T08:35:48Z New Revision: 69c3309d4545cd729c41b102303686e19c92f55c URL: https://github.com/llvm/llvm-project/commit/69c3309d4545cd729c41b102303686e19c92f55c DIFF: https://github.com/llvm/llvm-project/commit/69c3309d4545cd729c41b102303686e19c92f55c.diff

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c3309d4545: [flang][driver] Add support for `-emit-mlir` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://revie

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

MaskRay added a comment. This needs some tests, otherwise there is a risk that others may break your changes when refactoring driver code. The style I favor most is `test/Driver/linux-cross.cpp`. freebsd.c is not too bad. linux-ld.c is somewhat messy but can give you some idea what to test. I'l

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407070. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td flang/in

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

jdoerfert added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + sameerds wrote: > jdoerfert wrote: > > sameerds wrote: > > > jdoerfert wrote: > > > > jdoerfert wrote: > > > > > sameerds wrote: > > > > >

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nikic added a comment. It looks like this breaks expensive checks builds due to machine verifier errors: https://lab.llvm.org/buildbot/#/builders/16/builds/24103 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D1

[clang] cd81723 - [clang-cl] Bump default -fms-compatibility-version to 19.14

Author: Muhammad Omair Javaid Date: 2022-02-09T13:54:25+05:00 New Revision: cd817231ec4ffc4362a71cd151dd5b9cf91f1a3e URL: https://github.com/llvm/llvm-project/commit/cd817231ec4ffc4362a71cd151dd5b9cf91f1a3e DIFF: https://github.com/llvm/llvm-project/commit/cd817231ec4ffc4362a71cd151dd5b9cf91f1a

[clang] c091792 - [NFC] Fix SSE3 intrinsics test for PowerPC

Author: Qiu Chaofan Date: 2022-02-09T17:00:34+08:00 New Revision: c091792cd3a82e60e10ea14c28ff64b14c17a254 URL: https://github.com/llvm/llvm-project/commit/c091792cd3a82e60e10ea14c28ff64b14c17a254 DIFF: https://github.com/llvm/llvm-project/commit/c091792cd3a82e60e10ea14c28ff64b14c17a254.diff L

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3307106 , @nikic wrote: > It looks like this breaks expensive checks builds due to machine verifier > errors: https://lab.llvm.org/buildbot/#/builders/16/builds/24103 Sorry about that. Looking into it now. Repository:

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda updated this revision to Diff 407078. jchlanda added a comment. Tidy up FMA_TUPLE class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118977/new/ https://reviews.llvm.org/D118977 Files: clang/include/clang/Basic/BuiltinsNVPTX.def cla

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:937 +class FMA_TUPLE Preds = [hasPTX70, hasSM80]> { + string Variant = V; tra wrote: > I think the default should be the most useful/common and the least > surprising value. >

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds marked 2 inline comments as not done. sameerds added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + jdoerfert wrote: > sameerds wrote: > > jdoerfert wrote: > > > sameerds wrote: > > > > jdoerfe

[clang] 5e0be95 - [analyzer][docs][NFC] Fix some broken links and some cosmetic changes

Author: Balazs Benics Date: 2022-02-09T10:22:28+01:00 New Revision: 5e0be95fce2640bda83dd02c1dc85d3e0836fa1a URL: https://github.com/llvm/llvm-project/commit/5e0be95fce2640bda83dd02c1dc85d3e0836fa1a DIFF: https://github.com/llvm/llvm-project/commit/5e0be95fce2640bda83dd02c1dc85d3e0836fa1a.diff

[PATCH] D119245: [analyzer][docs][NFC] Fix some broken links and some cosmetic changes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e0be95fce26: [analyzer][docs][NFC] Fix some broken links and some cosmetic changes (authored by steakhal). Herald added a project: clang. Herald add

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. @Anastasia @svenvh ping. Just a kind reminder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 ___ cfe-commits mailing list cfe-commi

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

sammccall added a comment. In D119130#3304505 , @kbobyrev wrote: > Oh, and also regarding the Python generator scripts: they don't seem to work > with the latest archives :( 2018 mentioned in the docs (works perfectly) but > 2019 crashes. Yikes, we sho

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/StandardLibraryTest.cpp:50 + EXPECT_THAT(Vector->headers(), ElementsAre(*VectorH)); +} + maybe add a test for

[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

sammccall added inline comments. Comment at: clang/unittests/Tooling/Syntax/Pseudo/GrammarTest.cpp:25 MATCHER_P(TargetID, SID, "") { return arg.Target == SID; } template testing::Matcher Sequence(T... IDs) { hokein wrote: > sammccall wrote: > > whoops, I mis

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

uabelho added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478 + HELP, METAVAR, VALUES) \ + {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS}, +#include "clang/Driver/Options.inc" -

[PATCH] D119172: [pseudo] Implement LRGraph

hokein updated this revision to Diff 407092. hokein marked 16 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119172/new/ https://reviews.llvm.org/D119172 Files: clang/inclu

[PATCH] D119172: [pseudo] Implement LRGraph

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:131 + + // Constructs an LR(0) automaton. + static LRGraph buildLR0(const Grammar &); sammccall wrote: > IIUC the data structure used here is inherently LR0, rather th

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 407093. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add a test for C Standard Library symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307222 , @sammccall wrote: > In D119130#3304505 , @kbobyrev > wrote: > >> Oh, and also regarding the Python generator scripts: they don't seem to work >> with the latest arc

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46a6f5ae148a: [clangd] NFC: Move stdlib headers handling to Clang (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D11913

[clang] 46a6f5a - [clangd] NFC: Move stdlib headers handling to Clang

Author: Kirill Bobyrev Date: 2022-02-09T11:05:39+01:00 New Revision: 46a6f5ae148ae2044f13cddf1bb1498a8bcfb372 URL: https://github.com/llvm/llvm-project/commit/46a6f5ae148ae2044f13cddf1bb1498a8bcfb372 DIFF: https://github.com/llvm/llvm-project/commit/46a6f5ae148ae2044f13cddf1bb1498a8bcfb372.diff

[clang] f1984b1 - [pseudo] Implement LRGraph

Author: Haojian Wu Date: 2022-02-09T11:20:07+01:00 New Revision: f1984b14336777e1978bfe994dd1e43ebea93f00 URL: https://github.com/llvm/llvm-project/commit/f1984b14336777e1978bfe994dd1e43ebea93f00 DIFF: https://github.com/llvm/llvm-project/commit/f1984b14336777e1978bfe994dd1e43ebea93f00.diff LO

[PATCH] D119172: [pseudo] Implement LRGraph

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1984b143367: [pseudo] Implement LRGraph (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

paulwalker-arm added a comment. After this commit I am seeing the link time error ld.lld: error: undefined symbol: clang::DeclContext::isInlineNamespace() const >>> referenced by StandardLibrary.cpp:118 (/home/pmw/projects/upstream-llvm/llvm-project/clang/lib/Tooling/Inclusions/StandardLibra

[clang] fe69058 - [OpenCL] Fix atomic_fetch_add/sub with half type

Author: Sven van Haastregt Date: 2022-02-09T10:47:45Z New Revision: fe690587bedb23dec2753549d4216059a7f894a1 URL: https://github.com/llvm/llvm-project/commit/fe690587bedb23dec2753549d4216059a7f894a1 DIFF: https://github.com/llvm/llvm-project/commit/fe690587bedb23dec2753549d4216059a7f894a1.diff

[clang] e3ba831 - [clang] Fix the tooling build after D119130

Author: Kirill Bobyrev Date: 2022-02-09T11:52:03+01:00 New Revision: e3ba831937189ec61e28ced0b0bfc1e41a3510f8 URL: https://github.com/llvm/llvm-project/commit/e3ba831937189ec61e28ced0b0bfc1e41a3510f8 DIFF: https://github.com/llvm/llvm-project/commit/e3ba831937189ec61e28ced0b0bfc1e41a3510f8.diff

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307333 , @paulwalker-arm wrote: > After this commit I am seeing the link time error > > ld.lld: error: undefined symbol: clang::DeclContext::isInlineNamespace() > const > >>> referenced by StandardLibrary.cpp:11

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

paulwalker-arm added a comment. Yep, that did the trick. Many Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D118847: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355

kbobyrev added a comment. Mostly LG with few nits. I think it might be able to make it into the 14 release if we cherry-pick into the release branch. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) +

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + sameerds wrote: > jdoerfert wrote: > > sameerds wrote: > > > jdoerfert wrote: > > > > sameerds wrote: > > > > > jdoerfert wrote: > > > > > >

[clang] 2e099c9 - [clang] Remove duplicate doc index for ClangLinkerWrapper

Author: Simon Pilgrim Date: 2022-02-09T11:21:36Z New Revision: 2e099c9e60060adee977191b4aaabb471db96e91 URL: https://github.com/llvm/llvm-project/commit/2e099c9e60060adee977191b4aaabb471db96e91 DIFF: https://github.com/llvm/llvm-project/commit/2e099c9e60060adee977191b4aaabb471db96e91.diff LOG:

[clang] 4883145 - [clang] Fix sphinx "start-string without end-string" warning

Author: Simon Pilgrim Date: 2022-02-09T11:31:24Z New Revision: 4883145a8fd767f5e29a03f919bb3c86ac401b07 URL: https://github.com/llvm/llvm-project/commit/4883145a8fd767f5e29a03f919bb3c86ac401b07 DIFF: https://github.com/llvm/llvm-project/commit/4883145a8fd767f5e29a03f919bb3c86ac401b07.diff LOG:

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

Szelethus updated this revision to Diff 407106. Szelethus added a comment. - Rename from `.*Imprecise` to `.*AsWritten`. - Copy comments to relevant functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119004/new/ https://reviews.llvm.org/D119004 Files: clang/include/clang/Static

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe updated this revision to Diff 407115. Febbe retitled this revision from "Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355" to "Added early exit for defaulted FunctionDecls.". Febbe edited the summary of this revision.

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) + // operator<=> generates also the AST of e.g. operator==, which is implicit + if (F->getLocation().isInvalid() || F->i

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71 + template + requires(T{0}) // + friend constexpr auto kbobyrev wrote: > nit: `//` looks unrelated I used the `//` to brea

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71 + template + requires(T{0}) // + friend conste

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. In D118021#3307079 , @MaskRay wrote: > This needs some tests, otherwise there is a risk that others may break your > changes when refactoring driver code. I thought it would be enough that any breakage there would cause a large numbe

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

aaron.ballman added subscribers: cfe-commits, aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D118052#3273241 , @gftg wrote: > Thanks, João, that's exactly what I needed. For the record, the use of > `-DLLV

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 407120. ro added a comment. Add tests in `solaris-ld.c`. Spot-checked by running the single test with `llvm-lit` on `sparcv9-sun-solaris2.11`, `amd64-solaris2.11`, and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe added a comment. Can I still add a diff, or does this cause a revoke (apply the rest of the feedback)? Also, is the commit added automatically to the repo, or do I / another one have to rebase it. Sorry for those questions, this is my first contribution to llvm. CHANGES SINCE LAST ACTI

[PATCH] D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

Szelethus updated this revision to Diff 407121. Szelethus marked 8 inline comments as done. Szelethus added a comment. Fixes according to reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118880/new/ https://reviews.llvm.org/D118880 Files: clang/lib/StaticAnalyzer/Chec

[PATCH] D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

Szelethus added inline comments. Comment at: clang/test/Analysis/NewDeleteLeaks.cpp:152 + // like to deallocate anything. + bar(); +} steakhal wrote: > I guess we would not have the warning if `bar` would accept the pointer `P`, > since that way it would escap

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h:102-103 + /// Returns true if the CallEvent is a call to a function that matches + /// the CallDescription. + /// NoQ wrote: > ping ==

[PATCH] D119296: KCFI sanitizer

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:695 +def KCFIUnchecked : Attr { + let Spellings = [Clang<"kcfi_unchecked">]; Is there a reason the attribute isn't inheritable? e.g., ``` [[clang::kcfi_unchecked]] extern int i;

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1096 + if (TM->Options.JMCInstrument) +addPass(createJMCInstrumenterPass()); addCodeGenPrepare(); ychen wrote: > hans wrote: > > could this be moved into addIRPasses()? > Yes, i

[PATCH] D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'm content. Thanks for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118880/new/ https://reviews.llvm.org/D118880 ___ cfe-

[PATCH] D119326: [clang] [MinGW] Default to DWARF 4

mstorsjo created this revision. mstorsjo added reviewers: dblaikie, rnk, mati865. mstorsjo requested review of this revision. Herald added a project: clang. Neither LLDB nor GDB seem to work with DWARF 5 debug information on Windows right now. This applies the same change as in 9c6272861032f511a2

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

aykevl added a comment. Apparently there is also another patch that tries to do something very similar: D81223 . In D72404#3305275 , @mehdi_amini wrote: > Why can't you build the object files with `-Os` in the first place

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407130. awarzynski added a comment. Herald added a subscriber: mehdi_amini. Updated `fir::CodeGenSpecifics::get` to see whether the unit tests pass on Windows. If they do, I'll create a seperate patch with this change. Repository: rG LLVM Github Monore

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added a comment. In D118847#3307497 , @Febbe wrote: > Can I still add a diff, or does this cause a revoke (apply the rest of the > feedback)? > Also, is the commit added automatically to the repo, or do I / another one > have to rebase it. > >

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

jrtc27 added a comment. Ping? I'd really like to get this fixed in 14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list cfe-commits@

[libunwind] 6f17768 - [runtimes] Remove support for standalone builds

Author: Louis Dionne Date: 2022-02-09T08:55:31-05:00 New Revision: 6f17768e11480063f4c2bcbeea559505fee3ea19 URL: https://github.com/llvm/llvm-project/commit/6f17768e11480063f4c2bcbeea559505fee3ea19 DIFF: https://github.com/llvm/llvm-project/commit/6f17768e11480063f4c2bcbeea559505fee3ea19.diff

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no prototype">, InGroup< + DiagGroup<"strict-calls-without-protot

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

aykevl added a comment. After some more testing on a larger amount of code (many small programs, together over 1MB of code), LoopRotate indeed seems to be the culprit. I'm now looking into a patch to LoopRotate to respect the `optsize` function attribute. Repository: rG LLVM Github Monorepo

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM as far as the changes go (I can't speak to how appropriate the changes are for the PS4 target). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407139. awarzynski added a comment. Remove the change from `fir::CodeGenSpecifics::get` (this was uploaded as a seperate patch: https://reviews.llvm.org/D119332) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349-352 + // This should be an assert, but asserts shouldn't be used in signal + // handlers + if (!CurContext) +return; ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). --

[PATCH] D118437: [NFC] [Modules] Refactor ODR checking for default template argument in ASTReader

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. ok, thanks for considering the suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118437/new/ https://reviews.llvm.org/D118437 _

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 407155. tyb0807 added a comment. Fix buildbots failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/Code

[clang] a464444 - [OpenCL][Docs] Update OpenCL 3.0 status info

Author: Sven van Haastregt Date: 2022-02-09T15:12:49Z New Revision: a46b2888b9d0fcfb712897f0110cadb84d93 URL: https://github.com/llvm/llvm-project/commit/a46b2888b9d0fcfb712897f0110cadb84d93 DIFF: https://github.com/llvm/llvm-project/commit/a46b2888b9d0fcfb712897f0110cadb84d93.diff

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 407159. tyb0807 added a comment. Turn off warnings for negative tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cpp c

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} tianshilei1992 wrote: > ABataev wrote: > > Output? > I did it on

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + sameerds wrote: > sameerds wrote: > > jdoerfert wrote: > > > sameerds wrote: > > > > jdoerfert wrote: > > > > > sameerds wrote: > > > > > > jd

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

ldionne created this revision. Herald added subscribers: libcxx-commits, ayermolo, arphaman, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added projects: libunwind, Flang. Herald added a reviewe

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. MaskRay: Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added a comment. In D118070#3308304 , @pkasting wrote: > MaskRay: Friendly ping. I think I still feel that having this in LLVMSupport is strange, but am happy if the two other folks I added are happy... Repository: rG LLVM Github Monorepo C

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante added a comment. Sorry I missed your message. At the moment I don't intend to continue with this review. Do you want to commandeer this one or do you prefer me to abandon it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71966/new/ https://reviews.llvm.org/D71966

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe updated this revision to Diff 407200. Febbe marked 4 inline comments as done. Febbe added a comment. Last batch of suggested changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118847/new/ https://reviews.llvm.org/D118847 Files: clang-tools-extra/clang-tidy/modernize/UseTrail

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe marked an inline comment as done. Febbe added a comment. Thank you for the review. I am done and you can commit the patch :) . I don't have the rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118847/new/ https://reviews.llvm.org/D118847 __

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} The new 3-argument constructor a

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} tra wrote: > The new 3-argu

[clang] 8073da0 - [NFC] Fix sign-compare warning in GrammarBNF thanks to int promotion

Author: Erich Keane Date: 2022-02-09T11:25:58-08:00 New Revision: 8073da0beed804d0cef1697b72fdc4151457a327 URL: https://github.com/llvm/llvm-project/commit/8073da0beed804d0cef1697b72fdc4151457a327 DIFF: https://github.com/llvm/llvm-project/commit/8073da0beed804d0cef1697b72fdc4151457a327.diff L

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

mehdi_amini added a comment. In D72404#3307623 , @aykevl wrote: > So, should all passes just look at the `optsize` and `minsize` attributes > instead of the `SizeLevel`? In other words, should > `PassManagerBuilder.SizeLevel` be removed and should passes

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} jchlanda wrote: > tra wrote: > >

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc updated this revision to Diff 407227. pcc retitled this revision from "AST: Move __va_list tag to the top level on ARM architectures." to "AST: Move __va_list tag back to std conditionally on AArch64.". pcc edited the summary of this revision. pcc added a comment. Make it conditional Repos

[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

beanz created this revision. beanz added reviewers: aaron.ballman, jyknight, rnk, dblaikie. beanz requested review of this revision. Herald added a project: clang. None of these tests are really intended to test the file offset as much as to test the structure. Making the regex allows this test to

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda marked 2 inline comments as done. jchlanda added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162 SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq) : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {} -

[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

beanz added a comment. I realize this is a _big_ silly NFC change, but I figured I'd blast it out there in case anyone objects to the premise. My goal is to eventually get to the point where Windows developers can use autocrlf (see the note here: https://llvm.org/docs/GettingStarted.html#check

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); pcc wrote: > We considered a

[PATCH] D119296: KCFI sanitizer

samitolvanen marked an inline comment as not done. samitolvanen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:696 +def KCFIUnchecked : Attr { + let Spellings = [Clang<"kcfi_unchecked">]; + let Subjects = SubjectList<[Var, TypedefName]>; j

[PATCH] D119296: KCFI sanitizer

samitolvanen planned changes to this revision. samitolvanen added a comment. Thanks for the pointers, Aaron. I'll rework the attribute code and also address the issues Nick pointed out in the next revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

rafauler added a comment. BOLT modifications LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119351/new/ https://reviews.llvm.org/D119351 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Add `ObjCProtocolLoc` which behaves like `TypeLoc` but for `ObjCProtocolDecl` references.

[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this NFC change is reasonable. We do lose a bit of JSON dumping test coverage from it (I don't see any tests for the offset there now), but I am okay with that as I don't

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

Quuxplusone added inline comments. Comment at: bolt/docs/OptimizingClang.md:228-236 $ CPATH=${TOPLEV}/stage1/install/bin/ -$ cmake -G Ninja ${TOPLEV}/llvm-project/llvm -DLLVM_TARGETS_TO_BUILD=X86 \ +$ cmake -G Ninja -S ${TOPLEV}/llvm-project/llvm -B ${TOPLEV}/stage2-prof-gen \ +

[PATCH] D119364: Refactor nested if else with ternary operator

phyBrackets created this revision. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119364 Files: clang/lib/CodeGen/CGExprScalar.cpp Index: clang/lib/CodeGen/C

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This removes clangd's existing workaround in favor of prope

[PATCH] D119296: KCFI sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); samitolvanen wrote: > pcc wrote: > >

  1   2   >