Quuxplusone added inline comments.
================
Comment at: bolt/docs/OptimizingClang.md:228-236
$ CPATH=${TOPLEV}/stage1/install/bin/
-$ cmake -G Ninja ${TOPLEV}/llvm-project/llvm -DLLVM_TARGETS_TO_BUILD=X86 \
+$ cmake -G Ninja -S ${TOPLEV}/llvm-project/llvm -B ${TOPLEV}/stage2-prof-gen \
+ -DLLVM_TARGETS_TO_BUILD=X86 \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_C_COMPILER=$CPATH/clang -DCMAKE_CXX_COMPILER=$CPATH/clang++ \
-DLLVM_ENABLE_PROJECTS="clang;lld" \
-DLLVM_USE_LINKER=lld -DLLVM_BUILD_INSTRUMENTED=ON \
----------------
FWIW, I personally prefer to run cmake and ninja //from// the build directory,
i.e.
```
$ mkdir ${TOPLEV}/llvm-project/llvm/stage2-prof-gen
$ cd ${TOPLEV}/llvm-project/llvm/stage2-prof-gen
$ CPATH=${TOPLEV}/stage1/install/bin
$ cmake -G Ninja \
-DLLVM_TARGETS_TO_BUILD=X86 \
~~~
-DCMAKE_INSTALL_PREFIX=${TOPLEV}/stage2-prof-gen/install \
../llvm-project/llvm
$ ninja install
```
This is the style that was used in `DataFlowSanitizer.rst` below, which you
explicitly moved away from into `-B`/`-S`/`-C` land (where I find it harder to
keep straight all the different extra options that are needed).
Orthogonally, I'm worried that the advice on lines 73–74 of README.md doesn't
mention `CMAKE_INSTALL_PREFIX`. When I'm building libc++ locally as part of my
development workflow, I //absolutely do not// want to blow away my computer's
default standard library installation; but what //do// I want to do? Should I
use something like `-DCMAKE_INSTALL_PREFIX=$(pwd)/install` as depicted here?
Can I really not get away with "running it out of the buildroot" the way I'm
used to?— I //must// install it somewhere on my system in order to test it at
all?
================
Comment at: flang/README.md:37
+If you are interested in writing new documentation, follow
[markdown style guide from
LLVM](https://github.com/llvm/llvm-project/blob/main/llvm/docs/MarkdownQuickstartTemplate.md).
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119351/new/
https://reviews.llvm.org/D119351
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
