ro added a comment. In D118021#3307079 <https://reviews.llvm.org/D118021#3307079>, @MaskRay wrote:
> This needs some tests, otherwise there is a risk that others may break your > changes when refactoring driver code. I thought it would be enough that any breakage there would cause a large number of test failures. But it's certainly better to avoid problems up from rather than reacting afterwards. > The style I favor most is `test/Driver/linux-cross.cpp`. freebsd.c is not too > bad. linux-ld.c is somewhat messy but can give you some idea what to test. > I'll add a note that zignore isn't tested and that is a problem. It seemed easiest to add to `solaris-ld.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
