[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

browneee added a comment. Hi, This change appears to break on of the buildbots (clang-ppc64le-linux-lnt ): https://lab.llvm.org/buildbot/#/builders/105/builds/21233/steps/7/logs/FAIL__Clang__aarch64-mops_c TEST 'Clang :: CodeG

[PATCH] D119296: KCFI sanitizer

samitolvanen created this revision. Herald added subscribers: dexonsmith, dang, jdoerfert, cryptoad. Herald added a reviewer: aaron.ballman. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The KCFI sanitizer, enabled with -fsan

[PATCH] D119299: [NFC] clang-format one function.

eugenis created this revision. eugenis added reviewers: kda, vitalybuka. eugenis requested review of this revision. Herald added a project: clang. fix code formatting Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119299 Files: clang/lib/CodeGen/CGClass.cpp Index: clang/li

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

eugenis created this revision. eugenis added reviewers: kda, vitalybuka. eugenis requested review of this revision. Herald added projects: clang, Sanitizers. Herald added a subscriber: Sanitizers. -fsanitize-memory-use-after-dtor detects memory access after a subobject is destroyed but its memory

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5419 + typedef typeof(f1) * __attribute__((kcfi_unchecked) unchecked_t; + ((unchecked_t)p2)(); // unchecked + `p2` is already unchecked. Would it be more demonstrative to

[PATCH] D119296: KCFI sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); We considered a scheme like this befo

[clang] 9b81d2f - Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS"

Author: tyb0807 Date: 2022-02-09T00:10:09Z New Revision: 9b81d2fae8c05ea611578137101e46a7b61fbaed URL: https://github.com/llvm/llvm-project/commit/9b81d2fae8c05ea611578137101e46a7b61fbaed DIFF: https://github.com/llvm/llvm-project/commit/9b81d2fae8c05ea611578137101e46a7b61fbaed.diff LOG: Rever

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 reopened this revision. tyb0807 added a comment. This revision is now accepted and ready to land. Reverted due to buildbots failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 ___

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rnk added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1658-1659 Target.getNewAlign(), getContext().getTypeSize(allocType))); allocationAlign = std::max( allocationAlign, getContext().toCharUnitsFromBits(AllocatorAlign)); } --

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen created this revision. ychen added reviewers: mubashar_, lenary, pbarrio. Herald added a subscriber: kristof.beyls. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { + assert(CGM.getCodeGenOpts().hasReducedDebugInfo()); + assert(!LexicalBlockStack.empty() && "Region stack mismatch,

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4667 + + SmallVector Expr; + AppendAddressSpaceXDeref(AddressSpace, Expr); aprantl wrote: > 13 seems to be unnecessarily high. Shouldn't 1 be enough for the expected > single DW_OP_der

[clang] dc8f4e1 - [cxx_status] Add a couple of Feb 2022 library papers that need compiler support.

Author: Richard Smith Date: 2022-02-08T17:25:52-08:00 New Revision: dc8f4e118d92982ff5f6316fe7d541d120ebabd1 URL: https://github.com/llvm/llvm-project/commit/dc8f4e118d92982ff5f6316fe7d541d120ebabd1 DIFF: https://github.com/llvm/llvm-project/commit/dc8f4e118d92982ff5f6316fe7d541d120ebabd1.diff

[clang] deaf22b - [X86] Implement -fzero-call-used-regs option

Author: Bill Wendling Date: 2022-02-08T17:42:54-08:00 New Revision: deaf22bc0e306bc44c70d2503e9364b5ed312c49 URL: https://github.com/llvm/llvm-project/commit/deaf22bc0e306bc44c70d2503e9364b5ed312c49 DIFF: https://github.com/llvm/llvm-project/commit/deaf22bc0e306bc44c70d2503e9364b5ed312c49.diff

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdeaf22bc0e30: [X86] Implement -fzero-call-used-regs option (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer argumen

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. In D115610#3304289 , @urnathan wrote: > the landed version is good, with Richard's suggested member name change. > Can't see a way of post-commit accepting? Yeah, maybe we can't do post-commit accept formally. Repository:

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + jdoerfert wrote: > sameerds wrote: > > jdoerfert wrote: > > > jdoerfert wrote: > > > > sameerds wrote: > > > > > jdoerfert wrote: > > > > >

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1658-1659 Target.getNewAlign(), getContext().getTypeSize(allocType))); allocationAlign = std::max( allocationAlign, getContext().toCharUnitsFromBits(AllocatorAlign)); } -

[clang] 8440ec6 - [docs] Document -ffinite-math-only, -fhonor-{infinities,infinites,nans}

Author: Jon Roelofs Date: 2022-02-08T18:10:17-08:00 New Revision: 8440ec66f4f0f2e4f49061262648809345952bf7 URL: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7 DIFF: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7.diff L

[clang] cfe7f69 - [RISCV][NFC] Refactor RISCVISAInfo.

Author: Zakk Chen Date: 2022-02-08T18:37:43-08:00 New Revision: cfe7f690367b9d2903f099162f0bcbbfd18c7610 URL: https://github.com/llvm/llvm-project/commit/cfe7f690367b9d2903f099162f0bcbbfd18c7610 DIFF: https://github.com/llvm/llvm-project/commit/cfe7f690367b9d2903f099162f0bcbbfd18c7610.diff LOG

[PATCH] D119250: [RISCV][NFC] Refactor RISCVISAInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe7f690367b: [RISCV][NFC] Refactor RISCVISAInfo. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 1d97cb1 - [HIP] Emit amdgpu_code_object_version module flag

Author: Yaxun (Sam) Liu Date: 2022-02-08T21:58:40-05:00 New Revision: 1d97cb1f6e44a77cfc6911b916656e3c5de9bec8 URL: https://github.com/llvm/llvm-project/commit/1d97cb1f6e44a77cfc6911b916656e3c5de9bec8 DIFF: https://github.com/llvm/llvm-project/commit/1d97cb1f6e44a77cfc6911b916656e3c5de9bec8.dif

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d97cb1f6e44: [HIP] Emit amdgpu_code_object_version module flag (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D119299: [NFC] clang-format one function.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I don't think you need approval for that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119299/new/ https://reviews.llvm.org/D119299 ___

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD, Is XLenRI correct for GPR

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

MaskRay added inline comments. Comment at: clang/lib/Driver/Job.cpp:304 +void Command::setRedirectFiles(std::vector> Redirects) { + RedirectFiles = Redirects; Comment at: clang/lib/Driver/Job.cpp:370 + ma

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay created this revision. MaskRay added reviewers: DiggerLin, hubert.reinterpretcast, jasonliu, stevewan, Xiangling_L. Herald added a reviewer: ctetreau. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - For `-###`, `-o %t.o`

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay updated this revision to Diff 407038. MaskRay edited the summary of this revision. MaskRay added a comment. update more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119309/new/ https://reviews.llvm.org/D119309 Files: clang/test/Driver/a

[PATCH] D117809: [clang] Add an extract-api driver option

MaskRay added a comment. Thanks for working on such tools but the patch order is not right. You should implement the functionality first, and in the last, add the driver option. The driver option is user-facing and the availability makes users think the functionality is ready when it actually is

[clang] a163cdf - [docs] Re-generate ClangCommandLineReference.rst

Author: Fangrui Song Date: 2022-02-08T20:54:52-08:00 New Revision: a163cdf6b50c0b7706fcf7805fd29736ad4eb9c2 URL: https://github.com/llvm/llvm-project/commit/a163cdf6b50c0b7706fcf7805fd29736ad4eb9c2 DIFF: https://github.com/llvm/llvm-project/commit/a163cdf6b50c0b7706fcf7805fd29736ad4eb9c2.diff

[PATCH] D119296: KCFI sanitizer

joaomoreira added inline comments. Comment at: clang/include/clang/Basic/Attr.td:696 +def KCFIUnchecked : Attr { + let Spellings = [Clang<"kcfi_unchecked">]; + let Subjects = SubjectList<[Var, TypedefName]>; Are you considering that perhaps one could use KCFI a

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev w

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added a comment. In D118948#3295589 , @hctim wrote: > In D118948#3295321 , @MaskRay wrote: > >> I haven't investigated the use case yet, just commented a few things. Please >> split the patch into 3: >> >

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added inline comments. Comment at: lld/ELF/Driver.cpp:690 +if (config->memtagStack || config->memtagHeap) + error("When using --memtag-stack or --memtag-heap, a --memtag-mode value " +"is required."); lld uses the diagnostic format s

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added a comment. In D84225#3305140 , @rnk wrote: > In D84225#3304189 , @pengfei wrote: > >> It's not a workaround. We do need to avoid the merging sometime. For >> example, given we have 2 branches begin wi

[clang] 4db88a5 - [OpenMP][Clang] Move partial support of reverse offload to a future version

Author: Saiyedul Islam Date: 2022-02-09T07:11:41Z New Revision: 4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e URL: https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e DIFF: https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e.diff LOG

[PATCH] D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4db88a54b6d4: [OpenMP][Clang] Move partial support of reverse offload to a future version (authored by saiislam). Repository: rG LLVM Github Monor

[PATCH] D118439: [scan-build] Fix deadlock at failures in libears/ear.c

steakhal added a comment. We missed the release, let's backport it to 14.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118439/new/ https://reviews.llvm.org/D118439 ___ cfe-commits mailing list cfe-c

<    1   2   3