MaskRay added a comment.

In D118948#3295589 <https://reviews.llvm.org/D118948#3295589>, @hctim wrote:

> In D118948#3295321 <https://reviews.llvm.org/D118948#3295321>, @MaskRay wrote:
>
>> I haven't investigated the use case yet, just commented a few things. Please 
>> split the patch into 3:
>>
>> - BinaryFormat/ELF.h (see an inline comment)
>> - lld/ELF
>> - clang
>
> Can you clarify what you'd like (from D107949 
> <https://reviews.llvm.org/D107949>) in patch #1?

For patch #1, make yaml2obj support the `NT_*` tags (`grep NT_ 
llvm-readobj/ELF/note-*.test`) and obj2yaml able to dump the tag. Add 
llvm-readobj support.

llvm-objdump support may be unneeded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118948/new/

https://reviews.llvm.org/D118948

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to