MaskRay added a comment.

Thanks for working on such tools but the patch order is not right.
You should implement the functionality first, and in the last, add the driver 
option.
The driver option is user-facing and the availability makes users think the 
functionality is ready when it actually isn't.

I am also a bit unsure whether the option name should use the single-dash `-e*` 
since `-e` is a short option taking a value, so a typo in `-extract-api` cannot 
be detected.
By convention a two-dash option should be used.
(Yes, I know `-emit-llvm` is a violation.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117809/new/

https://reviews.llvm.org/D117809

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D117809: [clang] Add ... Fangrui Song via Phabricator via cfe-commits

Reply via email to