[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

Szelethus created this revision. Szelethus added reviewers: NoQ, steakhal, xazax.hun, martong, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Szelethus requested review of this revision. Herald added

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405985. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. move error to code gen and add missing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://rev

[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:146 +// derived from X. (Known as FIRST sets in grammar-based parsers). +std::vector> firstSets(cons

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 ___

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. In D93298#3296515 , @luismarques wrote: > Assuming this will be merged soon, do you want to submit a backport request > for the 14.0 branch? Yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D119008: Add Cortex-X1C to Clang LLVM 14 release notes

stuij created this revision. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119008 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ==

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

steakhal added a comment. I strongly belive that this should be an overload to the existing 'matches' API. Maybe add a comment that prefer the other overload if can. But having an overload for that alread implies this anyway. That being said, digging out a callexpr from a CallEvent and calling

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 405989. achieveartificialintelligence marked 3 inline comments as done. achieveartificialintelligence added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774

[PATCH] D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

Szelethus updated this revision to Diff 405979. Szelethus edited the summary of this revision. Szelethus added a comment. Move `CallDescription` specific changes to D119004 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118880/new/ https://reviews.llv

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117306/new/ https://reviews.llvm.org/D117306 _

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

Szelethus added a comment. In D119004#3297025 , @steakhal wrote: > I strongly belive that this should be an overload to the existing 'matches' > API. Maybe add a comment that prefer the other overload if can. But having an > overload for that alread imp

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

LegalizeAdulthood added a comment. Do you have commit access or do you need someone to push this change for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97625/new/ https://reviews.llvm.org/D97625 _

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 405997. achieveartificialintelligence added a comment. Amend tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/boost/UseRangeBasedForLoopCheck.h:28 + bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { +return LangOpts.CPlusPlus11; + } LegalizeAdulthood wrote:

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks created this revision. Herald added subscribers: Naghasan, ldrumm, Anastasia, yaxunl. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we call CGOpenCLRuntime::convertOpenCLSpecificType() multiple times we should get the

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a project: Flang. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoe

[clang] 679c77e - [Driver][Android] Removed obsoleted --warn-shared-textrel

Author: Fangrui Song Date: 2022-02-04T09:30:11-08:00 New Revision: 679c77ede35aee6f6a5d1feee28a057e3705f58b URL: https://github.com/llvm/llvm-project/commit/679c77ede35aee6f6a5d1feee28a057e3705f58b DIFF: https://github.com/llvm/llvm-project/commit/679c77ede35aee6f6a5d1feee28a057e3705f58b.diff

[PATCH] D118942: [Driver][Android] Removed obsoleted --warn-shared-textrel

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG679c77ede35a: [Driver][Android] Removed obsoleted --warn-shared-textrel (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406005. awarzynski added a comment. Add missing CMake dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td f

[clang] b35be6f - [Clang][Sema][OpenMP] Sema support for `atomic compare`

Author: Shilei Tian Date: 2022-02-04T12:30:56-05:00 New Revision: b35be6fe98e30b2373e8fdf024ef8c13a32121d7 URL: https://github.com/llvm/llvm-project/commit/b35be6fe98e30b2373e8fdf024ef8c13a32121d7 DIFF: https://github.com/llvm/llvm-project/commit/b35be6fe98e30b2373e8fdf024ef8c13a32121d7.diff L

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb35be6fe98e3: [Clang][Sema][OpenMP] Sema support for `atomic compare` (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406008. tianshilei1992 added a comment. rebase and make preparation for codegen in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files: clang/include

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. The core difference of behavior is this, in the logic for setting `canPassInRegisters`: // Clang <= 4 used the pre-C++11 rule, which ignores move operations. // The PS4 platform ABI follows the behavior of Clang 3.2. if (CCK == TargetInfo::CCK_ClangABI4OrP

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406012. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. remove leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

haowei added a comment. Hi, we are seeing clang Windows build breakages after this change was relanded error message: Assertion failed: isa(Val) && "cast() argument of incompatible type!", file C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\include\llvm/Support/Casting.h, line 262 PLEASE submit a

[PATCH] D119011: [clang] Cache OpenCL types

Anastasia added a comment. Just to understand the intent - is this a performance optimization or functionality fix? Also is there any way to test this? Comment at: clang/lib/CodeGen/CGOpenCLRuntime.h:42 llvm::PointerType *SamplerTy; + llvm::StringMap Tys; --

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

LegalizeAdulthood added a comment. In D118104#3296467 , @salman-javed-nz wrote: > Anyway, I don't want what was a drive-by comment by me baloon into a lot of > extra work for the author, so I will not push for it, unless others really > want it. I thi

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia added a comment. In D118999#3296899 , @azabaznov wrote: > It seems hard to find a direct mention in the spec, but in the API spec: > > //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device > supports independent forward

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

devin.jeanpierre created this revision. devin.jeanpierre added a reviewer: gribozavr2. Herald added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. devin.jeanpierre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reve

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

LegalizeAdulthood added a comment. In D118104#3295876 , @JesApp wrote: > In D118104#3294883 , > @LegalizeAdulthood wrote: > >> What is the feasibility of Python unit tests Instead of a heavy-weight `lit` >> orie

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the '-Bsymbolic

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 updated this revision to Diff 406022. jhuber6 added a comment. Clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang/lib/Driver/

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Approving the delta for the PS4 fix (relying or @rsmith 's approval for the actual patch -- https://reviews.llvm.org/D114732). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks updated this revision to Diff 406024. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119011/new/ https://reviews.llvm.org/D119011 Files: clang/lib/CodeGen/CGOpenCLRuntime.cpp clang/lib/CodeGen

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks added a comment. In D119011#3297305 , @Anastasia wrote: > Just to understand the intent - is this a performance optimization or > functionality fix? This is a functionality fix. > Also is there any way to test this? I came across this while w

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

cmtice added a comment. This commit is causing some of our builds to fail with these errors: clang/lib/Sema/SemaOpenMP.cpp:11372:9: error: unused variable 'D' [-Werror,-Wunused-variable] Expr *D = nullptr; ^ clang/lib/Sema/SemaOpenMP.cpp:11373:9: error: unused variable 'CE' [-Werror

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

JonChesterfield added a comment. Can we drop an xfail in an existing test as part of this patch? Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:581 + + // If we are linking for the device all symbols should be bound locally. + if (JA.isDeviceOffloading(Action::OFK_OpenMP)) -

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:251 + if (InsertPos.isValid()) +InvalidFix |= InsertPos.isMacroID(); + else I'm not a fan of using

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 added a comment. In D119018#3297391 , @JonChesterfield wrote: > Can we drop an xfail in an existing test as part of this patch? We can drop an XFAIL for AMDGPU, but that's not related to the problem this fixes, we don't have any XFAIL lines for

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118927/new/ https://reviews.llvm.org/D118927

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 updated this revision to Diff 406027. jhuber6 added a comment. More informative error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index:

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018 __

[PATCH] D118922: [ASTMatchers] The `isInline` matcher now accepts inline variables

Izaron abandoned this revision. Izaron added a comment. In D118922#3296542 , @njames93 wrote: > I had the same idea in D118900 Wow! That's a curious coincidence. I'm closing my PR =) Let it be your version as the earli

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

Izaron added a comment. Thanks for the matcher! I'm planning to reuse it in my checker (D118743 ). Looking forward to seeing this commit merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118900/new/ https://r

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

tra added a comment. > They all require PTX 7.0, SM_80. According to https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#half-precision-floating-point-instructions-fma only `fma.relu` and `bf16*` variants require ptx70/sm80: PTX ISA Notes Introduced in PTX ISA version 4.2.

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

Izaron added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:5736 +MatcherVarDecl>isInline +Matches function and namespace declarations that are marked with +the inline keyword. >

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

Izaron added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:5736 +MatcherVarDecl>isInline +Matches function and namespace declarations that are marked with +the inline keyword. Iz

[clang] 012c811 - [Clang][Sema][OpenMP] Remove unused variables. NFC.

Author: Benjamin Kramer Date: 2022-02-04T19:27:59+01:00 New Revision: 012c811fed44da85f9870df9accf4477e626a012 URL: https://github.com/llvm/llvm-project/commit/012c811fed44da85f9870df9accf4477e626a012 DIFF: https://github.com/llvm/llvm-project/commit/012c811fed44da85f9870df9accf4477e626a012.dif

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297387 , @cmtice wrote: > This commit is causing some of our builds to fail with these errors: > > clang/lib/Sema/SemaOpenMP.cpp:11372:9: error: unused variable 'D' > [-Werror,-Wunused-variable] > > Expr *D =

[clang] 9385ece - [HeaderSearch] Track framework name in LookupFile

Author: David Goldman Date: 2022-02-04T13:32:39-05:00 New Revision: 9385ece95a4a342ca4f4c46ea747f79d4ede9783 URL: https://github.com/llvm/llvm-project/commit/9385ece95a4a342ca4f4c46ea747f79d4ede9783 DIFF: https://github.com/llvm/llvm-project/commit/9385ece95a4a342ca4f4c46ea747f79d4ede9783.diff

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG9385ece95a4a: [HeaderSearch] Track framework name in LookupFile (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D117830?vs=403340&id=

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:41 +bool isInNoNamespace(const FunctionDecl *FD) { + const DeclContext *DC = FD->getDeclContext(); `isInGlobalNamespace` might be a better name?

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 15 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3130-3136 + /// \brief The position of the ``requires`` clause for class templates. + /// \version 14 + RequiresClausePositionStyle R

[PATCH] D113319: [clang-format] Improve require and concept handling

Mordante added a comment. Thanks for working on this! I love to see better `requires` support in clang-format. I didn't do a real review, just some drive-by comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3399 +**RequiresClausePositionForClasses** (``RequiresCla

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56d46b36fc23: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially… (authored by devin.jeanpierre, committed by gribozavr). Reposit

[clang] 56d46b3 - [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Author: Devin Jeanpierre Date: 2022-02-04T20:17:34+01:00 New Revision: 56d46b36fc231a0beb518602503035bba92043e0 URL: https://github.com/llvm/llvm-project/commit/56d46b36fc231a0beb518602503035bba92043e0 DIFF: https://github.com/llvm/llvm-project/commit/56d46b36fc231a0beb518602503035bba92043e0.di

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406048. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. This took a lot of work and debugging. I tried to minimize the refactoring on related code (I've

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: dang, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. code object version determines ABI, therefore should not be mixed. Th

[clang] 35f7dd6 - [clang-format][NFC] Fix a bug in setting type FunctionLBrace

Author: Owen Pan Date: 2022-02-04T11:36:30-08:00 New Revision: 35f7dd601d33219fafa2c0d308e187df3e36847a URL: https://github.com/llvm/llvm-project/commit/35f7dd601d33219fafa2c0d308e187df3e36847a DIFF: https://github.com/llvm/llvm-project/commit/35f7dd601d33219fafa2c0d308e187df3e36847a.diff LOG:

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35f7dd601d33: [clang-format][NFC] Fix a bug in setting type FunctionLBrace (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added a comment. Format notes updated on local commit. Comment at: clang/docs/ClangFormatStyleOptions.rst:3399 +**RequiresClausePositionForClasses** (``RequiresClausePositionStyle``) :versionbadge:`clang

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

HazardyKnusperkeks added a comment. LGTM, since when can't I post an empty comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 ___ cfe-commits mailing list

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

HazardyKnusperkeks added a comment. Ah because of a race condition, I couldn't accept anymore. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 ___ cfe-commit

[clang] b8ec430 - [Clang][Sema][OpenMP] Fix uninitialized variable Op

Author: Shilei Tian Date: 2022-02-04T15:00:43-05:00 New Revision: b8ec430de71766d9a35a6b737c8a789c0c7cf812 URL: https://github.com/llvm/llvm-project/commit/b8ec430de71766d9a35a6b737c8a789c0c7cf812 DIFF: https://github.com/llvm/llvm-project/commit/b8ec430de71766d9a35a6b737c8a789c0c7cf812.diff L

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

owenpan added a comment. In D118969#3297699 , @HazardyKnusperkeks wrote: > Ah because of a race condition, I couldn't accept anymore. :) Sorry! I should have waited a little longer. :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:575 +// times 100. +if (getTarget().getTargetOpts().CodeObjectVersion != "none") { + unsigned CodeObjVer; When will it ever be set to `none`? Does the new option parser enforc

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

This revision was automatically updated to reflect the committed changes. Closed by commit rGeeb29c8477d9: [OpenMP] Add -Bsymbolic to arguments for GNU linker (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://r

[clang] eeb29c8 - [OpenMP] Add -Bsymbolic to arguments for GNU linker

Author: Joseph Huber Date: 2022-02-04T15:13:32-05:00 New Revision: eeb29c8477d96ad821b3283dad8ed060a3426118 URL: https://github.com/llvm/llvm-project/commit/eeb29c8477d96ad821b3283dad8ed060a3426118 DIFF: https://github.com/llvm/llvm-project/commit/eeb29c8477d96ad821b3283dad8ed060a3426118.diff

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

kda added a comment. This still seems to be breaking sanitizers fast: https://lab.llvm.org/buildbot/#/builders/5/builds/18563 To reproduce these results: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297785 , @kda wrote: > This still seems to be breaking sanitizers fast: > https://lab.llvm.org/buildbot/#/builders/5/builds/18563 > > To reproduce these results: > https://github.com/google/sanitizers/wiki/Sani

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

jdoerfert added a comment. In D116637#3297790 , @tianshilei1992 wrote: > In D116637#3297785 , @kda wrote: > >> This still seems to be breaking sanitizers fast: >> https://lab.llvm.org/buildbot/#/builders/5/build

[clang] 0d54457 - [IntrospectionTest] Replace "return" with "GTEST_SKIP"

Author: Paul Robinson Date: 2022-02-04T12:35:44-08:00 New Revision: 0d54457f8aed169dff8a668059979a2646afc3fc URL: https://github.com/llvm/llvm-project/commit/0d54457f8aed169dff8a668059979a2646afc3fc DIFF: https://github.com/llvm/llvm-project/commit/0d54457f8aed169dff8a668059979a2646afc3fc.diff

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297833 , @jdoerfert wrote: > In D116637#3297790 , > @tianshilei1992 wrote: > >> In D116637#3297785 , @kda wrote: >> >>> This s

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks updated this revision to Diff 406077. aeubanks added a comment. fix more issues, ready to review I've split the OpenCL change out into D119011 , will rebase once that's submitted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 406081. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang-tools-ex

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406086. ZarkoCA added a comment. - Moved AIX check to its own function to hopefully avoid Arg and ArgTy getting out of sync - Rebased and removed LIT test cases workaround Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] be3d811 - Rename this file to fix the typo in its name; NFC

Author: Aaron Ballman Date: 2022-02-04T15:59:59-05:00 New Revision: be3d811e2c21c864694ce73cb5c2878c3ea0bd68 URL: https://github.com/llvm/llvm-project/commit/be3d811e2c21c864694ce73cb5c2878c3ea0bd68 DIFF: https://github.com/llvm/llvm-project/commit/be3d811e2c21c864694ce73cb5c2878c3ea0bd68.diff

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef ParamName,

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. > @pkasting Note, this patch makes the outcome non-deterministic when the > auto-detection kicks in. We are stamping the command-line the .PDB file, see > https://github.com/llvm/llvm-project/blob/main/lld/COFF/PDB.cpp#L1402 - and > some live-code-patching tools rely on

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. In D117616#3295859 , @Bhramar.vatsa wrote: > @dblaikie > The condition `FieldClass->isPOD()` returns false for the following case > (when considering field 'struct foo t' of 'struct foo1') : > > class foo { > foo() = de

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 406094. steffenlarsen added a comment. Added missing `isVariadicExprArgument` function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basi

[clang-tools-extra] 4dfd113 - [clangd] Properly compute framework-style include spelling

Author: David Goldman Date: 2022-02-04T16:40:56-05:00 New Revision: 4dfd11324eb05d167392958c0f0f273cae6386c6 URL: https://github.com/llvm/llvm-project/commit/4dfd11324eb05d167392958c0f0f273cae6386c6 DIFF: https://github.com/llvm/llvm-project/commit/4dfd11324eb05d167392958c0f0f273cae6386c6.diff

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dfd11324eb0: [clangd] Properly compute framework-style include spelling (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ h

[clang] 5966c2e - [OpenMP] Fix mismatched device runtime name

Author: Joseph Huber Date: 2022-02-04T16:54:31-05:00 New Revision: 5966c2ec026c7953a86dd849b13a98589ed10e9c URL: https://github.com/llvm/llvm-project/commit/5966c2ec026c7953a86dd849b13a98589ed10e9c DIFF: https://github.com/llvm/llvm-project/commit/5966c2ec026c7953a86dd849b13a98589ed10e9c.diff

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 406099. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/reduction_i

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

ldionne added a comment. @rsmith Thanks a bunch! And thanks @sepavloff for trying out this approach too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103395/new/ https://reviews.llvm.org/D103395 ___ cf

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting marked an inline comment as done. pkasting added a comment. In D118070#3289222 , @ychen wrote: > Thanks for doing this! Update the release note? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. In D118070#3297956 , @thakis wrote: > I think the setup matches what we have in clang, right? Yes, I think so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://r

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406101. Herald added a reviewer: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt clang/lib/Driver/ToolCh

[PATCH] D113319: [clang-format] Improve require and concept handling

curdeius added a comment. Woow, that's a mountain of work! All my comments are non-blocking. Comment at: clang/docs/ClangFormatStyleOptions.rst:1992 +**BreakBeforeConceptDeclarations** (``BreakBeforeConceptDeclarationsStyle``) :versionbadge:`clang-format 13` + The style wethe

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

schweitz accepted this revision. schweitz added a comment. This revision is now accepted and ready to land. LGTM Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class CodeGenAction

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson created this revision. probinson added a reviewer: ioeric. probinson requested review of this revision. The preceding EXPECT_EQ was never executed; modifying the test input made that happen. Found by the Rotten Green Tests project. https://reviews.llvm.org/D119040 Files: clang/unit

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a comment. By "the EXPECT_EQ was never executed" I mean, replacing it with `assert(false);` does not crash the test. The string `"a::b::Foo"` was never seen by the Visitor. Maybe this indicates some much more subtle, deeper problem; I don't know. This change does cause the EX

[clang-tools-extra] 6abb70c - Attempt forward fix after 4dfd113

Author: David Goldman Date: 2022-02-04T17:47:38-05:00 New Revision: 6abb70c2d00812350153f4299a2491fdc3810ac3 URL: https://github.com/llvm/llvm-project/commit/6abb70c2d00812350153f4299a2491fdc3810ac3 DIFF: https://github.com/llvm/llvm-project/commit/6abb70c2d00812350153f4299a2491fdc3810ac3.diff

[PATCH] D59254: [RFC] Implementation of Clang randstruct

void added subscribers: kees, void. void added a comment. Herald added a subscriber: dang. In D59254#1792134 , @connorkuehl wrote: > In D59254#1792068 , @xbolva00 wrote: > >> Re-ping > > Still under development here

[clang-tools-extra] fb7ddd0 - Revert "[clangd] Properly compute framework-style include spelling"

Author: David Goldman Date: 2022-02-04T18:02:32-05:00 New Revision: fb7ddd0628f4894f9d14a2d1f84830607c5f946e URL: https://github.com/llvm/llvm-project/commit/fb7ddd0628f4894f9d14a2d1f84830607c5f946e DIFF: https://github.com/llvm/llvm-project/commit/fb7ddd0628f4894f9d14a2d1f84830607c5f946e.diff

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

probinson added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:654 + while (!L.LexFromRawLexer(T)) { +ASSERT_TRUE(!ToksView.empty()); +EXPECT_EQ(T.getKind(), ToksView.front().getKind()); @kadircet @sammccall It turns out this while loop

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:575 +// times 100. +if (getTarget().getTargetOpts().CodeObjectVersion != "none") { + unsigned CodeObjVer; tra wrote: > When will it ever be set to `none`? Does the new opti

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

yaxunl added a subscriber: tstellar. yaxunl added a comment. In D118876#3295958 , @linjamaki wrote: > Thanks for the review, @yaxunl. Could you push this to the LLVM? And to the > LLVM 14 release branch too, if possible? Sure. @tstellar What is the curr

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

tstellar added a comment. @yaxunl This looks good to me, you can go ahead and cherry-pick it directly to release/14.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876

<    1   2   3   >