thakis added a comment.

> @pkasting Note, this patch makes the outcome non-deterministic when the 
> auto-detection kicks in. We are stamping the command-line the .PDB file, see  
> https://github.com/llvm/llvm-project/blob/main/lld/COFF/PDB.cpp#L1402 - and 
> some live-code-patching tools rely on that to reproduce the link. It'd be 
> nice if the detected paths are queued to `config->argv`, to ensure that we 
> can emit a self-standing LLD cmd-line, a bit like what `clang -cc1` does.

You mean "non-deterministic" in "cmd.exe / local-computer dependent", yes? If 
so: There are enough flags that you can pass in to make the output 
deterministic if this is something you care about. (We care about determinism a 
lot over in chromium land!) I think the setup matches what we have in clang, 
right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118070/new/

https://reviews.llvm.org/D118070

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to