JonChesterfield added a comment.

Can we drop an xfail in an existing test as part of this patch?



================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:581
+
+  // If we are linking for the device all symbols should be bound locally.
+  if (JA.isDeviceOffloading(Action::OFK_OpenMP))
----------------
Perhaps a comment to the effect that the symbols are protected which makes 
Bsymbolic redundant, except in that it works around an issue in bfd?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119018/new/

https://reviews.llvm.org/D119018

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to