[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 373497. linjamaki edited the summary of this revision. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/T

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge added a comment. I will note that I considered handling this in a way specific to explicit template instantiations. However, while I do not have a reduced testcase for it, I've also run into duplicate hints in the context of macros. So, it seemed easier to deduplicate in general; there

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added a comment. we prefer verifyFormat because it does some additional checks to ensure if the code is altered it still goes to how you expect. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/new/ https://reviews.llvm.org/D108299 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] ca3bebd - [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-20T10:07:38+01:00 New Revision: ca3bebd8440f9f88f1457dad9c12933b73d9590f URL: https://github.com/llvm/llvm-project/commit/ca3bebd8440f9f88f1457dad9c12933b73d9590f DIFF: https://github.com/llvm/llvm-project/commit/ca3bebd8440f9f88f1457dad9c12933b73d9590f.dif

[PATCH] D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca3bebd8440f: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki created this revision. Herald added subscribers: Anastasia, yaxunl. linjamaki updated this revision to Diff 372671. linjamaki added a comment. Herald added subscribers: dexonsmith, hiraditya. linjamaki updated this revision to Diff 373494. linjamaki edited the summary of this revision. li

[PATCH] D109925: [AST] add warnings for out-of-bounds FP values when using relaxed FP math compile flags

sepavloff added a comment. I don't think the constant evaluator is a right place for such warnings. The option `-ffast-math` is a hint to the compiler, which, in particular, tells that no operation on Nans/Infs take place. It allows a compiler to generate better code. None is pertinent for the

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

balazske updated this revision to Diff 373525. balazske marked 9 inline comments as done. balazske added a comment. Fixed review issues. Added code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109608/new/ https://reviews.llvm.org/D109608

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8425 + + const T &value() { return To; } +}; steakhal wrote: > So, the `value()` sometimes returns const ref, and other times it returns a > mutable raw pointer... > > I suspect, attribu

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6414 +// Verify that dump does not crash because invalid data. +ToD->dump(); + steakhal wrote: > Should we dump to the `stderr`? It would be good to have a "sink stream" t

[clang] 15feaaa - Add myself as a code owner for SYCL support

Author: Alexey Bader Date: 2021-09-20T09:32:25+03:00 New Revision: 15feaaa359c7245bb59ff0a2aa3b806682f44286 URL: https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286 DIFF: https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286.diff

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think I'm convinced. Thanks. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6414 +// Verify that dump does not crash because invalid data. +ToD->dump(); +

[PATCH] D109315: [clang] Check unsupported types in expressions

asavonic reopened this revision. asavonic added a comment. This revision is now accepted and ready to land. This is weird... Buildbot reported that `lock/omp_init_lock.c` test crashed with SIGSEGV, but I cannot reproduce this on my machine. I added a check for a null QualType; not sure if it fixe

[PATCH] D109315: [clang] Check unsupported types in expressions

asavonic updated this revision to Diff 373531. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109315/new/ https://reviews.llvm.org/D109315 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/Se

[clang] eb3af1e - [clang][NFC] Remove dead code

Author: Andy Wingo Date: 2021-09-20T11:33:34+02:00 New Revision: eb3af1e77341e82249993a5a8a50779c48e1cb61 URL: https://github.com/llvm/llvm-project/commit/eb3af1e77341e82249993a5a8a50779c48e1cb61 DIFF: https://github.com/llvm/llvm-project/commit/eb3af1e77341e82249993a5a8a50779c48e1cb61.diff LO

[PATCH] D108360: [clang][NFC] Remove dead code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3af1e77341: [clang][NFC] Remove dead code (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hello everyone! Ping :), need more approves for this patch. @rsmith Thank you for your helpful tips. Can you please review the latest change? I fixed some tests and applied clang format suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

wingo added a reviewer: Anastasia. wingo added a comment. Just a little thing I saw while reading code -- if no response in a couple weeks I will just abandon the rev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108359/new/ https://reviews.llvm.o

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avx-builtins.c:182 // CHECK-LABEL: test_mm256_castsi128_si256 - // CHECK: shufflevector <2 x i64> %{{.*}}, <2 x i64> %{{.*}}, <4 x i32> + // CHECK: shufflevector <2 x i64> %{{.*}}, <2 x i64> %{{.*}}, <4 x i32

[PATCH] D91944: OpenMP 5.0 metadirective

uweigand added a comment. Looks like this was committed again, breaking the SystemZ build bots once again: https://lab.llvm.org/buildbot/#/builders/94/builds/5661 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. Thanks for the suggestions/details, @dexonsmith - I've posted to llvm-dev here: https://groups.google.com/g/llvm-dev/c/m9UVRhzJvh4/m/qdd_SyPuCQAJ and will wait for some follow-up (or dead silence) before starting along probably your latter suggestion. Repository:

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

labrinea created this revision. labrinea added reviewers: ostannard, miyuki, cfe-commits, llvm-commits. Herald added subscribers: hiraditya, kristof.beyls. labrinea requested review of this revision. Herald added projects: clang, LLVM. The patch introduces subtarget features to predicate certain i

[PATCH] D106715: Thread safety analysis: Drop special block handling

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Marking this explicitly as accepted, I'd say you're fine to land and we can handle any concerns from @delesley post commit. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaron.ballman added a comment. In D106713#3007878 , @aaronpuchert wrote: > @aaron.ballman, since this is reintroducing some warnings after the > relaxation in D102026 , should we bring > this to Clang 13? I think that

[clang] 6d7b3d6 - Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

Author: Alex Richardson Date: 2021-09-20T12:55:56+01:00 New Revision: 6d7b3d6b3a8dbd62650b6c3dae1fe904a8ae9048 URL: https://github.com/llvm/llvm-project/commit/6d7b3d6b3a8dbd62650b6c3dae1fe904a8ae9048 DIFF: https://github.com/llvm/llvm-project/commit/6d7b3d6b3a8dbd62650b6c3dae1fe904a8ae9048.dif

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7b3d6b3a8d: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D109611?vs=371944&id=373554#toc Repository:

[PATCH] D109979: [Clang] [Fix] Clang build fails when build directory contains space character

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109979/new/ https://reviews.llvm.org/D109979

[clang] fae57a6 - [Clang] [Fix] Clang build fails when build directory contains space character

Author: Brain Swift Date: 2021-09-20T18:19:08+05:30 New Revision: fae57a6a9795eccfa349270b110c09524e341abd URL: https://github.com/llvm/llvm-project/commit/fae57a6a9795eccfa349270b110c09524e341abd DIFF: https://github.com/llvm/llvm-project/commit/fae57a6a9795eccfa349270b110c09524e341abd.diff L

[PATCH] D109979: [Clang] [Fix] Clang build fails when build directory contains space character

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae57a6a9795: [Clang] [Fix] Clang build fails when build directory contains space character (authored by Brain Swift , committed by xgupta). Repository: rG LLVM Github Monorepo

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, this passed the usual tests and I didn't see any leftover allocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https:/

[PATCH] D110044: Print nullptr_t namespace qualified within std::

aaron.ballman added a comment. > This improves diagnostic (& important to me, DWARF) accuracy FWIW, I don't think the diagnostic particularly needs more accuracy here -- I think users know what `nullptr_t` type is being referred to without the full qualification because of other contextual clue

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: ahatanak. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no reason to have this here, (since all tests pass) and it isn't even a specifier anyway. We

[clang] 6de19ea - Thread safety analysis: Drop special block handling

Author: Aaron Puchert Date: 2021-09-20T15:20:15+02:00 New Revision: 6de19ea4b6264e64cea145e00ab66fe1530fc0a0 URL: https://github.com/llvm/llvm-project/commit/6de19ea4b6264e64cea145e00ab66fe1530fc0a0 DIFF: https://github.com/llvm/llvm-project/commit/6de19ea4b6264e64cea145e00ab66fe1530fc0a0.diff

[PATCH] D106715: Thread safety analysis: Drop special block handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6de19ea4b626: Thread safety analysis: Drop special block handling (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D103938#3007708 , @ychen wrote: > In D103938#3006540 , @aaron.ballman > wrote: > >> There w

[clang] f988f68 - [Analysis] Add support for vscale in computeKnownBitsFromOperator

Author: David Sherwood Date: 2021-09-20T15:01:59+01:00 New Revision: f988f680649ad38806897e7aa75e95e9fda88ffd URL: https://github.com/llvm/llvm-project/commit/f988f680649ad38806897e7aa75e95e9fda88ffd DIFF: https://github.com/llvm/llvm-project/commit/f988f680649ad38806897e7aa75e95e9fda88ffd.diff

[PATCH] D109883: [Analysis] Add support for vscale in computeKnownBitsFromOperator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf988f680649a: [Analysis] Add support for vscale in computeKnownBitsFromOperator (authored by david-arm). Herald added a project: clang. Herald added

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

pengfei updated this revision to Diff 373581. pengfei marked 2 inline comments as done. pengfei added a comment. Address review comments. Thanks Roman and Michael. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/va-arg-sse.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // RUN: %clang_cc1 %s -O2 -emit-llvm -o - -triple x86_64-unknown-unknown | FileCheck %s Meinersbur

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei added a comment. In D109607#3008486 , @Meinersbur wrote: > However, my other one that is connected to lab.llvm.org has failed as well > and should have sent an email: > https://lab.llvm.org/buildbot/#/builders/102/builds/2722. Unfortunately it

[PATCH] D110051: [clangd] Deduplicate inlay hints

kadircet added a comment. I am not aware of how the intersecting hints are handled in the implementation on the client side nor in the proposal today. After this patch we might still produce them if for whatever reason there are different kinds of hints for the same range. Is this OK? ==

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaronpuchert added a subscriber: tstellar. aaronpuchert added a comment. In D106713#3009130 , @aaron.ballman wrote: > In D106713#3007878 , @aaronpuchert > wrote: > >> @aaron.ballman, since this is reintroducing

[clang] 5dee501 - [analyzer] Move docs of SmartPtr to correct subcategory

Author: Deep Majumder Date: 2021-09-20T20:13:04+05:30 New Revision: 5dee50111c13bbc4480401e2eaa67f6bca1b480a URL: https://github.com/llvm/llvm-project/commit/5dee50111c13bbc4480401e2eaa67f6bca1b480a DIFF: https://github.com/llvm/llvm-project/commit/5dee50111c13bbc4480401e2eaa67f6bca1b480a.diff

[PATCH] D110032: [analyzer] Move docs of SmartPtr to correct subcategory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dee50111c13: [analyzer] Move docs of SmartPtr to correct subcategory (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. In D109607#3009377 , @pengfei wrote: > In D109607#3008486 , @Meinersbur > wrote: > >> However, my other one that is connected to lab.llvm.org has failed as well >> and should have sen

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 ___

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > If you add so many RUN lines at once, please use unittest

[PATCH] D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs

martong added a comment. Herald added a subscriber: manas. Nice work! Comment at: clang/docs/analyzer/developer-docs/ContainerModeling.rst:125 +The begin and end symbols are conjured and are completely unrelated to the region of +the container. For each region we store the onl

[clang-tools-extra] 444a5f3 - [clangd] Bail-out when an empty compile flag is encountered

Author: Kadir Cetinkaya Date: 2021-09-20T16:51:56+02:00 New Revision: 444a5f304f6c2c332f18392d2458d74664e98498 URL: https://github.com/llvm/llvm-project/commit/444a5f304f6c2c332f18392d2458d74664e98498 DIFF: https://github.com/llvm/llvm-project/commit/444a5f304f6c2c332f18392d2458d74664e98498.dif

[PATCH] D109894: [clangd] Bail-out when an empty compile flag is encountered

This revision was automatically updated to reflect the committed changes. Closed by commit rG444a5f304f6c: [clangd] Bail-out when an empty compile flag is encountered (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109894/new/

[clang] 228dd20 - [OpenCL] Supports atomics in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-20T16:24:30+01:00 New Revision: 228dd20c3f1e619193c68b288e0d5e8525c3a618 URL: https://github.com/llvm/llvm-project/commit/228dd20c3f1e619193c68b288e0d5e8525c3a618 DIFF: https://github.com/llvm/llvm-project/commit/228dd20c3f1e619193c68b288e0d5e8525c3a618.dif

[PATCH] D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG228dd20c3f1e: [OpenCL] Supports atomics in C++ for OpenCL 2021 (authored by Topotuna). Changed prior to commit: https://reviews.llvm.org/D109424?v

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei added a comment. In D109607#3009412 , @Meinersbur wrote: > In D109607#3009377 , @pengfei wrote: > >> In D109607#3008486 , @Meinersbur >> wrote: >> >>> However, m

[clang] 5b47256 - [X86] Add test to show the effect caused by D109607. NFC

Author: Wang, Pengfei Date: 2021-09-20T23:34:18+08:00 New Revision: 5b47256fa5402a5f7f06513b0d168746d4c46df2 URL: https://github.com/llvm/llvm-project/commit/5b47256fa5402a5f7f06513b0d168746d4c46df2 DIFF: https://github.com/llvm/llvm-project/commit/5b47256fa5402a5f7f06513b0d168746d4c46df2.diff

[clang] 2276733 - [X86] Always check the size of SourceTy before getting the next type

Author: Wang, Pengfei Date: 2021-09-20T23:34:19+08:00 New Revision: 227673398c2d93d9db02fe5fdb1af10a74251995 URL: https://github.com/llvm/llvm-project/commit/227673398c2d93d9db02fe5fdb1af10a74251995 DIFF: https://github.com/llvm/llvm-project/commit/227673398c2d93d9db02fe5fdb1af10a74251995.diff

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227673398c2d: [X86] Always check the size of SourceTy before getting the next type (authored by pengfei). Repository: rG LLVM Github Monorepo CHA

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

tstellar added a comment. @aaronpuchert Can you file a bug? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#3008426 , @dblaikie wrote: > Thanks for the suggestions/details, @dexonsmith - I've posted to llvm-dev > here: https://groups.google.com/g/llvm-dev/c/m9UVRhzJvh4/m/qdd_SyPuCQAJ and > will wait for some follow-up (

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added a comment. In D109632#3007615 , @vsapsai wrote: > I don't remember for sure but I don't think there is a consistent policy > about a module storing transitive data or only data it owns. I suspect we > might be using both approaches and

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1434-1436 +bool addMethod(ObjCMethodDecl *Method) { + return AddedMethods.insert(Method).second; +} rmaz wrote: > rmaz wrote: > > dexonsmith wrote: > > > Hmm, I was imagini

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaronpuchert added a comment. In D106713#3009542 , @tstellar wrote: > @aaronpuchert Can you file a bug? Done: https://bugs.llvm.org/show_bug.cgi?id=51913. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1067

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 373618. mizvekov added a comment. typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h clang/lib/AST/ExprConsta

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 __

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimensionalArray) { martong wrote: > aaron

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. In D91944#3009003 , @uweigand wrote: > Looks like this was committed again, breaking the SystemZ build bots once > again: > https://lab.llvm.org/buildbot/#/builders/94/builds/5661 I'm going to fix this issue now. Repository: rG

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

richkadel added a comment. I don't know if this is helpful or not, but we ran into a problem, recently, on Fuchsia when upgrading Clang (I believe to LLVM 14), and realized that the LLVM tools from Clang's version of LLVM were in compatible with the Rust profraw files. Since you're probably usi

[clang] 3679d20 - [NCF][OpenMP] Fix metadirective test on SystemZ

Author: cchen Date: 2021-09-20T12:22:54-05:00 New Revision: 3679d2001c87f37101e7f20c646b21e97d8a0867 URL: https://github.com/llvm/llvm-project/commit/3679d2001c87f37101e7f20c646b21e97d8a0867 DIFF: https://github.com/llvm/llvm-project/commit/3679d2001c87f37101e7f20c646b21e97d8a0867.diff LOG: [N

[clang] a077271 - Revert code change of D63497 & D74399 for riscv64-*-linux GCC detection

Author: Fangrui Song Date: 2021-09-20T10:28:32-07:00 New Revision: a07727199db0525e9d2df41e466a2a1611b3c8e1 URL: https://github.com/llvm/llvm-project/commit/a07727199db0525e9d2df41e466a2a1611b3c8e1 DIFF: https://github.com/llvm/llvm-project/commit/a07727199db0525e9d2df41e466a2a1611b3c8e1.diff

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. The SystemZ issue is due to the fact that we assumed that `device(cpu)` should be evaluated to true and `device(gpu)` should be evaluated to false in the test so the test should be fixed by specifying the triple. (https://github.com/llvm/llvm-project/commit/3679d2001c87f3

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

saiislam created this revision. saiislam added reviewers: yaxunl, jdoerfert, grokos. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add documentation of unbundling of heterogeneous device archives to create device specific archive

[PATCH] D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai. Conanap added projects: PowerPC, clang, LLVM. Herald added a subscriber: kbarton. Conanap requested review of this revision. This patch implements support for the type `vector bool int128` for arguments on vector co

[clang] 63e0d03 - Diagnose -Wunused-value based on CFG reachability

Author: Yuanfang Chen Date: 2021-09-20T10:43:34-07:00 New Revision: 63e0d038fc20c894a3d541effa1bc2b1fdea37b9 URL: https://github.com/llvm/llvm-project/commit/63e0d038fc20c894a3d541effa1bc2b1fdea37b9 DIFF: https://github.com/llvm/llvm-project/commit/63e0d038fc20c894a3d541effa1bc2b1fdea37b9.diff

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63e0d038fc20: Diagnose -Wunused-value based on CFG reachability (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109652/new/ https://reviews.llvm.org/D109652 _

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373656. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. - Resolve the final issue I had regarding overlapping replacements (was adding double spaces between keywords), - Add ability to add a warning into the documentati

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373657. MyDeveloperDay added a comment. Missed dump_format_style.py update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

Conanap accepted this revision as: Conanap. Conanap added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109996/new/ https://reviews.llvm.org/D109996 _

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109780/new/ https://reviews.llvm.org/D109780 _

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra created this revision. tra added reviewers: jlebar, yaxunl, hliao. Herald added subscribers: bixia, mgorny. Herald added a reviewer: a.sidorin. tra requested review of this revision. Herald added a project: clang. The patch Implements support for testure lookups (mostly) in a header file. The

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:566-569 + if (llvm::find(FeaturesVec, "+pcrel") != FeaturesVec.end()) { +Diags.Report(diag::err_opt_not_valid_without_opt) << "-mpcrel" + <

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

lei accepted this revision as: lei. lei added a comment. LTGM Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109996/new/ https://reviews.llvm.org/D109996 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

lei accepted this revision. lei added a comment. LGTM. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109780/new/ https://reviews.llvm.org/D109780 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D110092: [clang][NFC] encapsulate global method list in GlobalMethodPool

rmaz created this revision. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change moves the `addMethodToGlobalList` function to be a private member function of the `GlobalMethodPool` class. This is a preparatory step to allow for

[PATCH] D110092: [clang][NFC] encapsulate global method list in GlobalMethodPool

rmaz updated this revision to Diff 373675. rmaz added a comment. remove unnecessary empty check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110092/new/ https://reviews.llvm.org/D110092 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Se

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373681. MyDeveloperDay added a comment. Remove debug code Tidy a few comments Remove Qualifier Order defaults (must be specified for Custom) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: cl

[PATCH] D91944: OpenMP 5.0 metadirective

uweigand added a comment. In D91944#3009868 , @cchen wrote: > The SystemZ issue is due to the fact that we assumed that `device(cpu)` > should be evaluated to true and `device(gpu)` should be evaluated to false in > the test so the test should be fixed b

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

yaxunl added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:296 + * Their target triple are the same + * Their GPUArch are the same This does not match our final view of compatibility. Is this intentional? Thanks. Repository: rG LLVM Githu

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN_ma

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:296 + * Their target triple are the same + * Their GPUArch are the same yaxunl wrote: > This does not match our final view of compatibility

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. Really nice! No attributes in there, do you think it would be difficult to add them? We can definitely do that in another change to move this one forward. Comment at: clang/include/clang/Format/Format.h:1863-1864 + /// \warning + /// ``Q

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110083/new/ https://reviews.llvm.org/D110083 __

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

tianshilei1992 updated this revision to Diff 373696. tianshilei1992 added a comment. Herald added a subscriber: mgorny. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 Files: clang/lib/Code

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

thakis added a comment. This breaks the build for us: Running cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON '-DLLVM_ENABLE_PROJECTS=clang;compiler-rt;lld;chrometools;clang-tools-extra' -DLLVM_CHECK_ENABLED_PROJECTS=OFF '-DLLVM_TARGETS_TO_BUILD=AArch64;ARM;Mips;PowerPC;

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson added a comment. In D109611#3010353 , @thakis wrote: > This breaks the build for us: > > Running cmake -GNinja -DCMAKE_BUILD_TYPE=Release > -DLLVM_ENABLE_ASSERTIONS=ON > '-DLLVM_ENABLE_PROJECTS=clang;compiler-rt;lld;chrometools;clang-tools

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110041/new/ https://reviews.llvm.org/D110041 ___

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS anirudhp wrote: > MaskRay wrote: > > If you add so many RUN lines at once,

[clang] 9197834 - Revert "Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source"

Author: Nico Weber Date: 2021-09-20T16:18:03-04:00 New Revision: 9197834535364efff505580ef940ad41cd293275 URL: https://github.com/llvm/llvm-project/commit/9197834535364efff505580ef940ad41cd293275 DIFF: https://github.com/llvm/llvm-project/commit/9197834535364efff505580ef940ad41cd293275.diff LO

  1   2   >