pengfei added inline comments.
================ Comment at: clang/test/CodeGen/X86/va-arg-sse.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // RUN: %clang_cc1 %s -O2 -emit-llvm -o - -triple x86_64-unknown-unknown | FileCheck %s ---------------- Meinersbur wrote: > lebedev.ri wrote: > > Please don't use `-O*` in clang irgen tests. > > This should *only* test what IR is produced by clang itself. > I agree here, testing `-O*` output will break easily with any unrelated > change in LLVM. You are right. The test case looks more clear now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
