MaskRay added inline comments.
================ Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS ---------------- anirudhp wrote: > MaskRay wrote: > > If you add so many RUN lines at once, please use unittests instead. This > > would cost some test execution time > We're essentially matching what was available for the systemz elf target > (above lines) for the z/OS target. Is there a real concern for the execution > time here for moving it to a separate unit test. If we did, it would seem to > "stand out" for just the z/OS target. This is a real concern. Perhaps you can also move the SYstemZ ELF tests to a unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
