steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land.
I think I'm convinced. Thanks. ================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:6414 + // Verify that dump does not crash because invalid data. + ToD->dump(); + ---------------- balazske wrote: > steakhal wrote: > > Should we dump to the `stderr`? > It would be good to have a "sink stream" that just discards the input. In > this case it is not needed to allocate memory buffer, the text output of the > dump is not used. `ASTImporterTest` has already many unneeded output. `llvm::nulls()` returns such a stream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109608/new/ https://reviews.llvm.org/D109608 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
