[clang] 07e8582 - [OpenMP][AMDGCN] Enable complex functions

Author: Pushpinder Singh Date: 2021-08-24T12:40:41+05:30 New Revision: 07e85823aa75293888bba98868165f5acc3b2554 URL: https://github.com/llvm/llvm-project/commit/07e85823aa75293888bba98868165f5acc3b2554 DIFF: https://github.com/llvm/llvm-project/commit/07e85823aa75293888bba98868165f5acc3b2554.di

[PATCH] D108552: [OpenMP][AMDGCN] Enable complex functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07e85823aa75: [OpenMP][AMDGCN] Enable complex functions (authored by Pushpinder Singh ). Repository: rG LLVM Githu

[PATCH] D108609: [clang] NFC: remove superfluous braces

zhouyizhou added a comment. Thanks for reviewing I don't have the write access to LLVM, could you please commit this patch for me? Signed-off-by: Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108609/new/ https://reviews.llvm.org/D1086

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:19 +/// Such an archive is then passed to this tool to extract cubin files before +/// passing to nvlink. +/// ye-luo wr

[clang] 1f8602e - [clang] NFC: remove superfluous braces

Author: Zhouyi Zhou Date: 2021-08-24T15:42:50+08:00 New Revision: 1f8602e16eac3f116249c07303c68e479db1507a URL: https://github.com/llvm/llvm-project/commit/1f8602e16eac3f116249c07303c68e479db1507a DIFF: https://github.com/llvm/llvm-project/commit/1f8602e16eac3f116249c07303c68e479db1507a.diff L

[PATCH] D108609: [clang] NFC: remove superfluous braces

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8602e16eac: [clang] NFC: remove superfluous braces (authored by zhouyizhou, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108609/new

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___ cfe-commits mailing list cfe-

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. Thanks for the update! Looks pretty good, just a few minor comments from me. Will leave approval to Sam. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470 std::vector Tokens; + std::map> ExtraModifiers; const HeuristicResolver *Re

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

kadircet added a comment. thanks, mostly looks good. any reason for not doing it centrally though ? Comment at: clang-tools-extra/clangd/Hover.cpp:1024 HI->SymRange = halfOpenToRange(SM, HighlightRange); return HI; can we set it once around here instead

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a subscriber: sbc100. wingo added a comment. Thanks again John & Thomas for your thoughts. In D108464#2961595 , @rjmccall wrote: > In D108464#2960791 , @tlively wrote: > >> I don't think it makes sens

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro created this revision. djtodoro added a reviewer: rjmccall. djtodoro added projects: clang, LLVM. djtodoro requested review of this revision. The `CodeGen` is missing to add the `NoInline` attribute to the target of a call, even the declaration has the __attribute__ presented. This fixes

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

kadircet added a comment. thanks, it looks good as a contained fix. but it feels like we probably don't want these to be treated as decls in other places too (e.g. can we really provide any useful goto/hover on those `id` or `instancetype` decls?) maybe we should update ASTVisitors in FindTarge

[PATCH] D108360: [clang][NFC] Remove dead code

wingo added a comment. @Anastasia is this good to go for you or does this need closer attention? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108360 ___ cfe-commits

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a follow-up from https://reviews.llvm.org/D108538, ensure TypeScript argument decorators are kept in line with the argument. Repository: rG LLVM

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108620/new/ https://reviews.llvm.org/D108620 ___

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:497 if (Style.Language == FormatStyle::LK_JavaScript && - Previous.is(tok::r_paren) && Previous.is(TT_JavaAnnotation)) { + Current.TokenText == "get" && Previous.is(tok::r_par

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

krasimir updated this revision to Diff 368311. krasimir added a comment. - consider also functions and setters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108620/new/ https://reviews.llvm.org/D108620 Files: clang/lib/Format/ContinuationIndente

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:497 if (Style.Language == FormatStyle::LK_JavaScript && - Previous.is(tok::r_paren) && Previous.is(TT_JavaAnnotation)) { + Current.TokenTe

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki created this revision. Herald added a subscriber: yaxunl. linjamaki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add mapping for CUDA address spaces for HIP to SPIR-V translation. This change allows HIP device code to be emitte

[clang] befb9dc - [clang-format] keep TypeScript argument decorators in line

Author: Krasimir Georgiev Date: 2021-08-24T12:37:08+02:00 New Revision: befb9dc3694e95355f21650de7acb058ac89f993 URL: https://github.com/llvm/llvm-project/commit/befb9dc3694e95355f21650de7acb058ac89f993 DIFF: https://github.com/llvm/llvm-project/commit/befb9dc3694e95355f21650de7acb058ac89f993.d

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbefb9dc3694e: [clang-format] keep TypeScript argument decorators in line (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 98339f1 - Avoid nullptr dereferencing of 'Constraint'; NFC

Author: Sindhu Chittireddy Date: 2021-08-24T07:08:18-04:00 New Revision: 98339f14a0420cdfbe4215d8d1bc0a01165e0495 URL: https://github.com/llvm/llvm-project/commit/98339f14a0420cdfbe4215d8d1bc0a01165e0495 DIFF: https://github.com/llvm/llvm-project/commit/98339f14a0420cdfbe4215d8d1bc0a01165e0495.

[PATCH] D108421: Mark openmp internal global dso_local

lebedev.ri added a comment. In D108421#2961611 , @kamleshbhalui wrote: > updated test and make changes local to auto generated global vars for lock. I do not understand why the most original diff here was wrong. Is is the wrong default for `getOrCreateI

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

aaron.ballman closed this revision. aaron.ballman added a comment. In D108481#2960883 , @schittir wrote: > In D108481#2960875 , @aaron.ballman > wrote: > >> LGTM, thanks for the cleanup! Do you need someone to co

[clang] f717060 - Fix documentation and snippets for the handle attributes; NFC

Author: Paul Herman Date: 2021-08-24T07:11:38-04:00 New Revision: f71706046144bd49af397fbed10fbe130433b969 URL: https://github.com/llvm/llvm-project/commit/f71706046144bd49af397fbed10fbe130433b969 DIFF: https://github.com/llvm/llvm-project/commit/f71706046144bd49af397fbed10fbe130433b969.diff L

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman closed this revision. aaron.ballman added a comment. In D108525#2960903 , @paulherman wrote: > In D108525#2960877 , @aaron.ballman > wrote: > >> In D108525#2960765

[PATCH] D108421: Mark openmp internal global dso_local

ABataev added a comment. In D108421#2962151 , @lebedev.ri wrote: > In D108421#2961611 , @kamleshbhalui > wrote: > >> updated test and make changes local to auto generated global vars for lock. > > I do not under

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Mon, 23 Aug 2021 at 18:56, James Y Knight wrote: > If phabricator/phorge do turn out to be non-viable in the future, I think > we may want to reopen the option of moving to Gerrit for the primary > code-review platform. > > I'll note that the Golang folks are using Gerrit as their review platf

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, Aug 24, 2021 at 7:33 AM Renato Golin via cfe-commits wrote: > > On Mon, 23 Aug 2021 at 18:56, James Y Knight wrote: >> >> If phabricator/phorge do turn out to be non-viable in the future, I think we >> may want to reopen the option of moving to Gerrit for the primary >> code-review plat

[PATCH] D108421: Mark openmp internal global dso_local

lebedev.ri added a comment. In D108421#2962160 , @ABataev wrote: > In D108421#2962151 , @lebedev.ri > wrote: > >> In D108421#2961611 , >> @kamleshbhalui wrote: >> >>> up

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

guopeilin added a comment. Hi, @sammccall thanks for the patch. The precommit checks suggest that some test cases failing, could you please fix them. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108451/new/ https://reviews.llvm.org/D108451

[PATCH] D108421: Mark openmp internal global dso_local

ABataev added a comment. In D108421#2962199 , @lebedev.ri wrote: > In D108421#2962160 , @ABataev wrote: > >> In D108421#2962151 , @lebedev.ri >> wrote: >> >>> In D108421

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

aaron.ballman added inline comments. Comment at: clang/test/Sema/enum.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s + hokein wrote: > I'd put the test case in `clang/test/SemaCXX/recovery-expr-type.cpp` +1 -- Sema is for Cish things and SemaCXX is for C++ish

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

luismarques created this revision. luismarques added reviewers: asb, thopre. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote: > > A minor issue is that the messages Gerrit sends to Github are a bit > pointless "Message from PersonA: (1 comment)". It would be better if the > integration either works (like adding comments to a specific line or > updating the commits) or n

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

luismarques updated this revision to Diff 368323. luismarques added a comment. Nit: remove nop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108624/new/ https://reviews.llvm.org/D108624 Files: clang/lib/Basic/Targets/RISCV.h clang/test/Sema/i

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, Aug 24, 2021 at 8:18 AM Renato Golin wrote: > > On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote: >> >> > A minor issue is that the messages Gerrit sends to Github are a bit >> > pointless "Message from PersonA: (1 comment)". It would be better if the >> > integration either works (lik

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

luismarques added inline comments. Comment at: clang/test/Sema/inline-asm-validate-riscv.c:27-28 + register long x10 asm("x10"); + asm volatile("" :: "r"(x10) : "x10"); // expected-error {{conflicts with asm clobber list}} + asm volatile("" :: "r"(x10) : "a0"); // expected-er

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

sammccall added a comment. > Likely will send a follow up diff to include more context in the Objective-C > decl printing so they highlight properly. This might make sense if it provides useful context to human readers without too much syntactic weight. However if the issue is that particular e

[PATCH] D108625: [Test][Time profiler] Fix test time checking

anton-afanasyev created this revision. anton-afanasyev added reviewers: broadwaylamb, russell.gallop. anton-afanasyev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test sometimes triggers failures during build testing. For instance,

[clang] 9a5f388 - [AST] Pick last tentative definition as the acting definition

Author: Benson Chu Date: 2021-08-24T08:51:50-05:00 New Revision: 9a5f3888505630cea88f8372d3068b2d63cfb381 URL: https://github.com/llvm/llvm-project/commit/9a5f3888505630cea88f8372d3068b2d63cfb381 DIFF: https://github.com/llvm/llvm-project/commit/9a5f3888505630cea88f8372d3068b2d63cfb381.diff LO

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a5f38885056: [AST] Pick last tentative definition as the acting definition (authored by pestctrl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/

[clang-tools-extra] 8d50a84 - [clang-tidy] Hotfix default parameter value in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-08-24T16:10:19+02:00 New Revision: 8d50a847d410295a9fca466d38a261cca4c2302b URL: https://github.com/llvm/llvm-project/commit/8d50a847d410295a9fca466d38a261cca4c2302b DIFF: https://github.com/llvm/llvm-project/commit/8d50a847d410295a9fca466d38a261cca4c2302b.diff LO

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked 3 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:57 + "Const_Reverse_Iterator", + "const_reverse

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

ldionne added subscribers: mstorsjo, ldionne. ldionne added a comment. Herald added a subscriber: libcxx-commits. @pcc @mstorsjo Are we aware of anyone using these extensions? I would like to suggest that we either remove this extension if it's not useful, or make it unconditional (not only on W

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/16663/step_7.txt Please to a look. Just adding a -triple flag is probably sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D9

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. In D108584#2962271 , @sammccall wrote: >> Likely will send a follow up diff to include more context in the Objective-C >> decl printing so they highlight properly. > > This might make sense if it provides useful context to human

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368346. kstoimenov added a comment. Attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrumenta

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368347. kstoimenov added a comment. Attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman added a comment. In D108556#2962008 , @kadircet wrote: > thanks, it looks good as a contained fix. but it feels like we probably don't > want these to be treated as decls in other places too (e.g. can we really > provide any useful goto/hover o

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov added a comment. Tests are still WIP. This is not ready for review yet. I will ping you when it it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 368348. jozefl added a comment. Here's an updated patch that fixes some minor nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files: clang/include/clang/Basic/

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108456/new/ https://reviews.llvm.org/D108456 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368352. kstoimenov added a comment. Second attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Int

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. What do you think? @aaron.ballman @bkramer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke added a comment. Which do you prefer? @Quuxplusone Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:262-263 + int a = 10; + forwardToShowInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::move of the variable '

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368367. kstoimenov marked an inline comment as done. kstoimenov added a comment. Fixed a crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/inclu

[PATCH] D108615: [Coroutines] [libcxx] Move coroutine component out of experimental namespace

lxfind added a comment. I am not familiar with the process of when to move something out of experimental, but I do wonder how this is normally done so that people who uses coroutines can have a smooth migration? I assume that this is going to be a breaking change that existing code using corout

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added inline comments. Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1426 + OutStreamer->emitInstruction(MCInstBuilder(X86::AND32ri8) + .addReg(X86::ECX) + .addReg(X86::ECX) vita

[clang] f387a36 - [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

Author: Andrei Elovikov Date: 2021-08-24T09:16:31-07:00 New Revision: f387a361786081f8aadf079aa32e73ed05386242 URL: https://github.com/llvm/llvm-project/commit/f387a361786081f8aadf079aa32e73ed05386242 DIFF: https://github.com/llvm/llvm-project/commit/f387a361786081f8aadf079aa32e73ed05386242.dif

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf387a3617860: [NFC][clang] Move remaining part of X86Target.def to… (authored by a.elovikov). Repository: rG LLVM Github Monorepo CHANGES SINCE L

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, Aug 24, 2021 at 7:33 AM Renato Golin wrote: > The main problem with that (Go) solution is that the Gerrit install > doesn't single-sign-on with Github accounts, it asked me for my Google > account. We shouldn't ask people to create more accounts if we want > integration with Github. I gue

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, 24 Aug 2021 at 17:30, James Y Knight wrote: > Yes, the Gerrit hosting which Go uses ("googlesource.com") only permits a > google-account login as a matter of policy. But that's not a restriction of > Gerrit itself -- it can perfectly well be configured to use a github login. > Ah, awesom

[clang] 1b19f90 - Revert "[AST] Pick last tentative definition as the acting definition"

Author: Benson Chu Date: 2021-08-24T11:41:50-05:00 New Revision: 1b19f90a2390b60852c0ff5e1671c76dd82dac83 URL: https://github.com/llvm/llvm-project/commit/1b19f90a2390b60852c0ff5e1671c76dd82dac83 DIFF: https://github.com/llvm/llvm-project/commit/1b19f90a2390b60852c0ff5e1671c76dd82dac83.diff LO

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2797-2824 + enum DataPositionTy : size_t { +POS_X = 0, +POS_V, +POS_D, +POS_E, +POS_UpdateExpr, +POS_CondExpr, It is worth it to pre-commit these and related

[clang] 4c418c1 - Try to fix build with modules enabled after D108422

Author: Andrei Elovikov Date: 2021-08-24T10:18:15-07:00 New Revision: 4c418c1bfbc544e24b9614efc3926fe2c6218b0c URL: https://github.com/llvm/llvm-project/commit/4c418c1bfbc544e24b9614efc3926fe2c6218b0c DIFF: https://github.com/llvm/llvm-project/commit/4c418c1bfbc544e24b9614efc3926fe2c6218b0c.dif

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5775-5802 +static void emitOMPAtomicCompareExpr(CodeGenFunction &CGF, + llvm::AtomicOrdering AO, const Expr *X

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman removed subscribers: aheejin, MaskRay, jholewinski, dschuff, sdardis, nemanjai, jvesely, nhaehnle, sbc100, jgravelle-google, kbarton, fedor.sergeev, kosarev, asb, rbar, johnrusso, simoncook, sabuasal, niosHD, martong, jrtc27, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

a.elovikov updated this revision to Diff 368390. a.elovikov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108423/new/ https://reviews.llvm.org/D108423 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/CodeGen/CGBuiltin.c

[PATCH] D108603: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction

xur accepted this revision. xur added a comment. This revision is now accepted and ready to land. Thanks for fix this! I like this fix and the patch looks good to me. -Rong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108603/new/ https://reviews.

[PATCH] D107021: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and pointers to structs

ahatanak updated this revision to Diff 368391. ahatanak added a comment. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107021/new/ https://reviews.llvm.org/D107021 Files: clang/lib/Sema/SemaExprObjC.cpp clang/test/SemaObjC/arc

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:107 +- Clang now supports the _BitInt(N) family of bit-precise integer types from + C23. This type was previously exposed as _ExtInt(N), which is still supported This section should prob

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 368393. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D108647: [clang][deps] Use top-level modules as precompiled dependencies

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ASTReader` populates `Module::PresumedModuleMapFile` only for top-level mo

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 368395. dgoldman added a comment. Simplify setting the definition language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cp

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. I created D108647 to more directly address the issues I'm seeing at the moment in explicit builds. I think dealing with the possibility of empty `PresumedModuleMapFile` is still valua

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1489 + InGroup>; +def warn_prec2x_compat_bit_int : Warning< + "'_BitInt' is incompatible with C standards before C2x">, erichkeane wrote: > should this be warn_cp

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 368405. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. Please feel free to wordsmith my ABI change comment. I don't feel strongly other than trying to make it clear that `_ExtInt` is no longer a type/types. A question for other reviewers: Do we feel strongly enough to try to keep the old mangling around via the `clang-

[PATCH] D108648: [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monor

[PATCH] D108648: [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108648/new/ https://reviews.llvm.org/D108648 ___

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:145 +- The mangling of the ``_ExtInt(N)`` datatype has changed in both the Microsoft + ABI and Itanium ABI. erichkeane wrote: > Hrm... not a huge fan that this still claims that ``_Ex

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

pcc added subscribers: thomasanderson, thakis. pcc added a comment. I believe that Chromium uses it (or at least it did at the time that I added this, and Chromium has since switched to using libc++ on Windows). I don't work on Chromium much anymore but perhaps @thakis or @thomasanderson can co

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. LGTM, pending some level of Itanium ABI blessing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108643/new/ https://reviews.llvm.org/D108643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D108592: [WIP][clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

leonardchan updated this revision to Diff 368423. leonardchan edited the summary of this revision. Herald added subscribers: dexonsmith, dang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 ___

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added a comment. In D108377#2962445 , @kstoimenov wrote: > Tests are still WIP. This is not ready for review yet. I will ping you when > it it. There is also "Add Acction..."-> "Plan changes", which will remove it from reviewers dashboards.

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 368426. ABataev added a comment. Herald added a subscriber: jfb. Rebase + update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRu

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov planned changes to this revision. kstoimenov added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 ___ cfe-commits mailing list cf

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 368427. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

mstorsjo added a comment. In D42225#2962348 , @ldionne wrote: > @pcc @mstorsjo Are we aware of anyone using these extensions? > > I would like to suggest that we either remove this extension if it's not > useful, or make it unconditional (not only on Wind

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9588b685c6b2: [asan] Implemented intrinsic for the custom calling convention similar used by… (authored by kstoimenov). Repository: rG LLVM Github

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368432. kstoimenov added a comment. Updating after pushing D107850 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llv

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

ldionne added a subscriber: CaseyCarter. ldionne added a comment. In D42225#2963190 , @mstorsjo wrote: > In D42225#2962348 , @ldionne wrote: > >> @pcc @mstorsjo Are we aware of anyone using these extensions? >> >> I

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

dschuff accepted this revision. dschuff added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449 + // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires + // Emscripten libraries and processed together in LowerEmscrip

[clang] 148bc25 - [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

Author: Shilei Tian Date: 2021-08-24T16:00:24-04:00 New Revision: 148bc251f48ee68af9b7c7eb725d4ed888629b5c URL: https://github.com/llvm/llvm-project/commit/148bc251f48ee68af9b7c7eb725d4ed888629b5c DIFF: https://github.com/llvm/llvm-project/commit/148bc251f48ee68af9b7c7eb725d4ed888629b5c.diff L

[PATCH] D108648: [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rG148bc251f48e: [Clang][OpenMP] Use enum to dereference children data array in… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri created this revision. lebedev.ri added reviewers: jdoerfert, efriedma, aaron.ballman, nikic, MaskRay. lebedev.ri added a project: LLVM. Herald added subscribers: dexonsmith, okura, kuter, pengfei, jfb. lebedev.ri requested review of this revision. Herald added a reviewer: sstefan1. Hera

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. In D108003#2956332 , @xbolva00 wrote: >>> and it would be more of an optimization than correctness issue as far as I >>> understand > > Yeah, this is right, indeed. > > Maybe @rpbeltran has some idea or motivating cases for OR

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

craig.topper added a comment. Wild speculation. This may be a historical artifact of LoadInst and StoreInst having their getAlignment() function written like this when this limit was created unsigned getAlignment() const { return (1 << (getSubclassDataFromInstruction() >> 1)) >> 1; } B

  1   2   >