kadircet added a comment. thanks, mostly looks good. any reason for not doing it centrally though ?
================ Comment at: clang-tools-extra/clangd/Hover.cpp:1024 HI->SymRange = halfOpenToRange(SM, HighlightRange); return HI; ---------------- can we set it once around here instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits