[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 366558. RedDocMD added a comment. Connecting to MallocChecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrMode

[PATCH] D107900: [clang-tidy] Add a new clang-tidy check for trivially copyable types passed by const reference

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/PodConstRefToValueCheck.h:18-25 +/// The check detects when trivially_copyable types are passed by +/// const-reference to a function and changes that to by value +// +// RestrictToBuiltInTypes: if t

[clang] b8d451d - Add support of the future Debian (Debian 12 - Bookworm)

Author: Sylvestre Ledru Date: 2021-08-16T09:11:31+02:00 New Revision: b8d451da8610f0dd3ab55289606d7f2973e708d6 URL: https://github.com/llvm/llvm-project/commit/b8d451da8610f0dd3ab55289606d7f2973e708d6 DIFF: https://github.com/llvm/llvm-project/commit/b8d451da8610f0dd3ab55289606d7f2973e708d6.dif

[PATCH] D107873: [clang-tidy] adds a const-qualified parameter check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.cpp:73 + + const QualType &T = Param.getType(); + QualType is small (AFAIK it's just 2 pointers), no need for a reference on this, it can live on th

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

c-rhodes added a comment. In D107719#2945656 , @gAlfonso-bit wrote: > Not sure about the timing of base patch, but maybe this patch is also > candidate for llvm 13 (backport)? What's the value in backporting it to 13? It's NFC CHANGES SINCE LAST ACTI

[PATCH] D107961: [clang-format] Distinguish K&R C function definition and attribute

MyDeveloperDay added a comment. Nit: There is something niggling in the back of my mind that this is too much logic here to be in parseStructuralElement that sort of suggests to me that this isn't the correct place to handle this. I don't really see any other structural element being handled li

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K&R C

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1025 if (!isC78Type(*Tok) && !Tok->isOneOf(tok::kw_register, tok::kw_struct, tok::kw_union)) return false; should we have test cases showing these examples?

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke added a comment. Thank Craig for the clarification! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

LuoYuanke added a comment. Could you add the linkage of ABI in the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://reviews.llvm.org/D105331 ___ cfe-commits mailing list

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K&R C

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1025 if (!isC78Type(*Tok) && !Tok->isOneOf(tok::kw_register, tok::kw_struct, tok::kw_union)) return false; MyDeveloperDay wrote: > should we have test cases showing

[PATCH] D105331: [CFE][X86] Enable complex _Float16 support

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but wait 1 or 2 days to see if there is any comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://

[PATCH] D108029: [clang][Codegen] Introduce the no_sanitizer_instrumentation attribute

glider updated this revision to Diff 366570. glider added a comment. Renamed no_sanitizer_instrumentation to disable_sanitizer_instrumentation Added bitcode attribute declaration and missing handling of the new attribute in switches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D107961: [clang-format] Distinguish K&R C function definition and attribute

owenpan added a comment. In D107961#2946183 , @MyDeveloperDay wrote: > Nit: There is something niggling in the back of my mind that this is too much > logic here to be in parseStructuralElement that sort of suggests to me that > this isn't the correct

[PATCH] D108029: [clang][Codegen] Introduce the no_sanitizer_instrumentation attribute

glider marked 2 inline comments as done. glider added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602 + +This is not the same as ``__attribute__((no_sanitize(...)))``, which depending +on the tool may still insert instrumentation to prevent false posi

[PATCH] D108029: [clang][Codegen] Introduce the no_sanitizer_instrumentation attribute

glider added a subscriber: krytarowski. glider marked 2 inline comments as done. glider added a comment. +krytarowski FYI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 __

[PATCH] D108109: [CodeCompletion] Provide placeholders for known attribute arguments

sammccall created this revision. sammccall added a reviewer: aaron.ballman. Herald added a subscriber: krytarowski. sammccall requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Completion now looks

[PATCH] D108110: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

arichardson created this revision. arichardson added reviewers: aaron.ballman, rsmith. Herald added a subscriber: dexonsmith. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We should be using #if instead of #ifdef here since LL

[clang] 7313a6d - [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

Author: Kazushi (Jam) Marukawa Date: 2021-08-16T18:34:29+09:00 New Revision: 7313a6d87c04c33f0bc67297241e33f2d82a0d5d URL: https://github.com/llvm/llvm-project/commit/7313a6d87c04c33f0bc67297241e33f2d82a0d5d DIFF: https://github.com/llvm/llvm-project/commit/7313a6d87c04c33f0bc67297241e33f2d82a0

[PATCH] D108069: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was automatically updated to reflect the committed changes. Closed by commit rG7313a6d87c04: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108

[PATCH] D108111: [CodeComplete] Only complete attributes that match the current LangOpts

sammccall created this revision. sammccall added a reviewer: aaron.ballman. sammccall requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, dang, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allows `clc++21` and `CLC++21` to be used as possible

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

RKSimon added a comment. @gAlfonso-bit Do you have commit access? I don't think there's any reason to merge this - it fixes no bug or regression - it's just a cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 __

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

nikic added a comment. In D106891#2945342 , @arsenm wrote: > I don’t think constructing in the pass is the solution. Why exactly is this > introducing such a big slowdown? The reason are the additional DominatorTree and LoopInfo calculations. These hav

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366497. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/Compile

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. Okay, sorry about that. Thanks for reverting my commit. I will use a unique_ptr and wait for another approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366504. gandhi21299 added a comment. reverting type of ORE from `OptimizationRemarkEmitter * ` back to `std::unique_ptr ` and constructing it in AtomicExpand to avoid DTC and LI overhead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

nikic added a comment. You also need to drop the `getAnalysisUsage()` change, otherwise the pass manager will still create the ORE itself. PS: This revision still has incorrectly configured permissions, which prevents me from leaving line comments. Revisions on this Phabricator instance should

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366507. gandhi21299 added a reviewer: nikic. gandhi21299 added a comment. - removing analysis requirement as requested + nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366514. gandhi21299 added a comment. - fixing breaking tests by eliminating passes that are no longer in the pass pipelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.or

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

xbolva00 added a comment. Please drop a change in PowerPC/O3 -pipeline.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366517. gandhi21299 added a comment. - eliminated changes in PowerPC/O3 -pipeline.ll, as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ http

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. Any ideas on what could be causing the failure in windows pre-merge checks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

xbolva00 added a comment. Not related to your patch, feel free to ignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commit

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. Alright, please let me know if this patch is good for merge at your convenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 __

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added a comment. ping - any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107347/new/ https://reviews.llvm.org/D107347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D108119: wired up standard library indexing

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Only plumbing code to enable standard library inde

[PATCH] D108029: [clang][Codegen] Introduce the no_sanitizer_instrumentation attribute

glider updated this revision to Diff 366591. glider added a comment. Updated patch description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2945 + let Spellings = [Clang<"disable_sanitizer_instrumentation">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [DisableSanitizerInstrumentationDocs]; Do we

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc019142a89b4: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract… (authored by Szelethus). Repository: rG LLVM Github Monor

[clang] c019142 - [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

Author: Kristóf Umann Date: 2021-08-16T15:03:22+02:00 New Revision: c019142a89b477cd247434c1d8f571662d26e19d URL: https://github.com/llvm/llvm-project/commit/c019142a89b477cd247434c1d8f571662d26e19d DIFF: https://github.com/llvm/llvm-project/commit/c019142a89b477cd247434c1d8f571662d26e19d.diff

[PATCH] D108110: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! > Since the other branch has never been used I wonder if we should just remove > it instead? I don't think removing the other branch entirely is a good approach because t

[PATCH] D104975: Implement P1949

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1622-1623 + + const bool isIDStart = isAllowedInitiallyIDChar(CodePoint, LangOpts); + const bool isIDContinue = isIDStart || isAllowedIDChar(CodePoint, LangOpts); + Com

[clang] 2d3668c - [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Author: Kristóf Umann Date: 2021-08-16T16:19:00+02:00 New Revision: 2d3668c997faac1f64cd3b8eb336af989069d135 URL: https://github.com/llvm/llvm-project/commit/2d3668c997faac1f64cd3b8eb336af989069d135 DIFF: https://github.com/llvm/llvm-project/commit/2d3668c997faac1f64cd3b8eb336af989069d135.diff

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added a comment. @mizvekov Thanks for the help! I recently got commit access, so I think I can commit this myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 _

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. A new rule is added in 5.0: If a list item appears in a reduction, lastprivate or linear clause on a combined

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei updated this revision to Diff 366630. pengfei added a comment. 1. Address Yuanke's comments. 2. Add missed strict FP handling. 3. Refactor the repeated declarations for strict FP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ ht

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1996 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v16f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v16i16, Legal); + setOperationAction(ISD::STRICT_SINT_TO_F

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Why it can not be performed in codegen? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Also, would be good to see a runtime test, which reveals the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mai

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. OK then we can just merge this in main only then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. The code looks great, I don't see any major problems. We still need tests, I can't stress this enough. All the real-world cornercases you've covered here as you updated the patch deserve a test case. Some of these changes should probably be separated into other patches, eg.

[PATCH] D107873: [clang-tidy] Add 'performance-const-parameter-value-or-ref' for checking const-qualified parameters

aaron.ballman added a comment. It seems like there may be some considerable overlap between this check and the one proposed in https://reviews.llvm.org/D54943. I know the other check is more about C++ Core Guidelines so it's not perfect overlap. But I do wonder if it'd make sense to combine the

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. @RKSimon could you commit for me please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

kmclaughlin created this revision. kmclaughlin added reviewers: david-arm, fhahn, dmgreen, craig.topper, lebedev.ri. Herald added subscribers: ctetreau, ormris, wenlei, steven_wu, hiraditya, kristof.beyls. kmclaughlin requested review of this revision. Herald added projects: clang, LLVM. Herald a

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I think this is incremental progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107933/new/ https://reviews.llvm.org/D10

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. Hi ABataev, Thanks for reviedw. In D108132#2946927 , @ABataev wrote: > Why it can not be performed in codegen? I am not sure I can do that. Do you mean when generate map adding coding code to look though reduction clause and gen

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947053 , @jyu2 wrote: > Hi ABataev, > Thanks for reviedw. > > In D108132#2946927 , @ABataev wrote: > >> Why it can not be performed in codegen? > > I am not sure I can do that

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. >> I am not sure I can do that. Do you mean when generate map adding coding >> code to look though reduction clause and generate map for it? > Yes, exactly. We are missing mappable checking for example: #pragma omp target parallel for reduction(task, +: b[0:2][2:4][1])

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947080 , @jyu2 wrote: >>> I am not sure I can do that. Do you mean when generate map adding coding >>> code to look though reduction clause and generate map for it? > > > >> Yes, exactly. > > We are missing mappable c

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. In D107719#2946159 , @c-rhodes wrote: > In D107719#2945656 , @gAlfonso-bit > wrote: > >> Not sure about the timing of base patch, but maybe this patch is also >> candidate for llvm

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can we land this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note {{co

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

lebedev.ri added a comment. I'm not sure i'm sold on this, even though i'm aware that selects hurt vectorization. How does this Simplify the CFG? I think it would be best to teach LV selects, or at worst do this in LV itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. In D104285#2943449 , @aaron.ballman wrote: > One thing I think is worth asking in this thread is whether what you're > analyzing is undefined behavior? Technically you are right. Every exit out of an array extent is UB ac

[PATCH] D107296: Treat inttypes.h as a built-in header

markrowe added a comment. @dexonsmith Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107296/new/ https://reviews.llvm.org/D107296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 39. gAlfonso-bit added a comment. Rearranged if statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrint

[clang] b7425e9 - [NFC] Fix typos

Author: Rong Xu Date: 2021-08-16T10:15:30-07:00 New Revision: b7425e956be60a73004d7ae5bb37da85872c29fb URL: https://github.com/llvm/llvm-project/commit/b7425e956be60a73004d7ae5bb37da85872c29fb DIFF: https://github.com/llvm/llvm-project/commit/b7425e956be60a73004d7ae5bb37da85872c29fb.diff LOG:

[clang] 8bc72de - [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

Author: Alfsonso Gregory Date: 2021-08-16T19:07:50+01:00 New Revision: 8bc72dede68ccbbf828c0421276d962d369ba70f URL: https://github.com/llvm/llvm-project/commit/8bc72dede68ccbbf828c0421276d962d369ba70f DIFF: https://github.com/llvm/llvm-project/commit/8bc72dede68ccbbf828c0421276d962d369ba70f.di

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc72dede68c: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from… (authored by gAlfonso-bit, committed by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 80ed75e - Revert "[NFC] Fix typos"

Author: Kostya Kortchinsky Date: 2021-08-16T11:13:05-07:00 New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384 URL: https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384 DIFF: https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384.

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(&F); auto &TM = TPC->getTM(); Is there a reason to construct it upfront and not just use a local variable only when needed? Like in StackProtecto

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(&F); auto &TM = TPC->getTM(); rampitec wrote: > Is there a reason to construct it upfront and not just use a local variable > only when needed

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366671. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(&F); auto &TM = TPC->getTM(); rampitec wrote: > gandhi21299 wrote: > > rampitec wrote: > > > Is there a reason to construct it upfront and not

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175 + ORE = std::make_unique(&F); auto &TM = TPC->getTM(); gandhi21299 wrote: > rampitec wrote: > > Is there a reason to construct it upfront and not just use a local variable

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note {{

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

kile added a comment. Hi Petr, This looks to be the change that most likely broke a test on Windows Debug - would you mind taking a look? Here's the relevant test and stack trace: FAIL: LLVM :: Instrumentation/InstrProfiling/linkage.ll (56524 of 77140) - TEST 'LLVM :: Instrumentation/InstrProf

[PATCH] D108083: add sanitizer support to hexagon

sidneym added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { bcain wrote: > @sidneym Can you confirm that this implementatio

[clang] 0a03144 - [PassBuilder] Don't use MemorySSA for standalone LoopRotate passes

Author: Nikita Popov Date: 2021-08-16T20:34:18+02:00 New Revision: 0a031449b2c757400090b23bd6ddf4d896d32643 URL: https://github.com/llvm/llvm-project/commit/0a031449b2c757400090b23bd6ddf4d896d32643 DIFF: https://github.com/llvm/llvm-project/commit/0a031449b2c757400090b23bd6ddf4d896d32643.diff

[PATCH] D108073: [PassBuilder] Don't use MemorySSA for standalone LoopRotate passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a031449b2c7: [PassBuilder] Don't use MemorySSA for standalone LoopRotate passes (authored by nikic). Herald added a project: clang. Herald added a s

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

aeubanks added a comment. In D108003#2944714 , @xbolva00 wrote: > In D108003#2944178 , @aeubanks > wrote: > >> I ran this over Chrome and ran into a use case that looks legitimate. It >> seems like the pattern i

[clang] 570c9be - [MemorySSA] Remove unnecessary MSSA dependencies

Author: Nikita Popov Date: 2021-08-16T20:40:55+02:00 New Revision: 570c9beb8ebb4bdcc807101518cc36ad5e20797c URL: https://github.com/llvm/llvm-project/commit/570c9beb8ebb4bdcc807101518cc36ad5e20797c DIFF: https://github.com/llvm/llvm-project/commit/570c9beb8ebb4bdcc807101518cc36ad5e20797c.diff

[PATCH] D108074: [MemorySSA] Remove unnecessary MSSA dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG570c9beb8ebb: [MemorySSA] Remove unnecessary MSSA dependencies (authored by nikic). Herald added subscribers: cfe-commits, ormris, steven_wu. Herald

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366683. gandhi21299 added a comment. - ORE does not need to be a pointer anymore, it is constructed as local variable with this patch as requested by reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec accepted this revision. rampitec added a comment. LGTM, but please wait for others too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. Will do, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D108150: [Remarks] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 created this revision. gandhi21299 added reviewers: rampitec, arsenm, b-sumner. Herald added subscribers: foad, kerbowa, jfb, hiraditya, Anastasia, nhaehnle, jvesely. gandhi21299 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added a subscriber: pengfei. a.elovikov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...instead of redeclaring them in clang's own X86Target.d

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added a comment. Are these in the same order in X86TargetParser.Def? Can we make some comment in that file to make sure that we keep them in the order (see comment in original x86Target.def)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note {{co

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2944625 , @phosek wrote: > In D96033#298 , @leonardchan > wrote: > >> We're still hitting the OOMs when building clang-repl with LTO even with >> `-DLLVM_PARALLEL_LINK_J

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2947255 , @ASDenysPetrov wrote: > In D104285#2943449 , @aaron.ballman > wrote: > >> One thing I think is worth asking in this thread is whether what you're >> analyzing

[PATCH] D108150: [Remarks] Emit optimization remarks for atomics generating hardware instructions

rampitec added a comment. - Add [AMDGPU] to the title. - Rebase on top of D106891 . - Add tests to atomics-remarks-gfx90a.ll as well, including LDS with matching and non-matching rounding mode. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 366717. nickdesaulniers added a comment. - reorder diag vs note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://reviews.llvm.org/D106030 Files: clang/docs/ReleaseNotes.rst clang/i

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

dblaikie added a comment. Patch description probably needs an update - looks like it's out of date ("Add -Wimplicit-fallthrough-unreachable, which is default enabled with -Wimplicit-fallthrough" should read, I guess "Add -Wunreachable-code-fallthrough, which is default enabled with -Wunreachab

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

arsenm accepted this revision. arsenm added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] 93d08ac - [clang-offload-wrapper] Add standard notes for ELF offload images

Author: Vyacheslav Zakharin Date: 2021-08-16T13:09:01-07:00 New Revision: 93d08acaacec951dbb302f77eeae51974985b6b2 URL: https://github.com/llvm/llvm-project/commit/93d08acaacec951dbb302f77eeae51974985b6b2 DIFF: https://github.com/llvm/llvm-project/commit/93d08acaacec951dbb302f77eeae51974985b6b2

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93d08acaacec: [clang-offload-wrapper] Add standard notes for ELF offload images (authored by vzakhari). Repository: rG LLVM Github Monorepo CHANG

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Please include in the commit message a reason for a revert. On Mon, Aug 16, 2021 at 11:14 AM Kostya Kortchinsky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kostya Kortchinsky > Date: 2021-08-16T11:13:05-07:00 > New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384 > > URL: >

  1   2   >