NoQ added a comment. The code looks great, I don't see any major problems.
We still need tests, I can't stress this enough. All the real-world cornercases you've covered here as you updated the patch deserve a test case. Some of these changes should probably be separated into other patches, eg. invalidation and pointer escape for non-destructor operations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
