aaron.ballman added inline comments.
================
Comment at: clang/test/Sema/attr-error.c:31-32
+
+__attribute__((error("foo"))) int bad5(void); // expected-error {{'error'
and 'warning' attributes are not compatible}}
+__attribute__((warning("foo"))) int bad5(void); // expected-note {{conflicting
attribute is here}}
+
----------------
I think the diagnostic order is backwards here. The first declaration is where
I'd expect the note and the second declaration is where I'd expect the error.
(The idea is: the first declaration adds an attribute to the decl, so the
redeclaration is what introduces the conflict and so that's where the error
should live.) As an example: https://godbolt.org/z/bjGTWxYvh
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106030/new/
https://reviews.llvm.org/D106030
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
