rampitec added inline comments.

================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175
 
+  ORE = std::make_unique<OptimizationRemarkEmitter>(&F);
   auto &TM = TPC->getTM<TargetMachine>();
----------------
Is there a reason to construct it upfront and not just use a local variable 
only when needed? Like in StackProtector.cpp for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to