[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:680 foreach type = TypeList in { -foreach eew_list = EEWList in { +foreach eew_list = Xlen32EEWList in { defvar eew = eew_list[0]; HsiangKai

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106285/new/ https://reviews.llvm.org/D106285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim marked 8 inline comments as done. Jim added inline comments. Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:442 + +if (STI.getFeatureBits()[RISCV::FeatureExtZpsfoperand] && +!STI.getFeatureBits()[RISCV::Feature64Bit]) { jrtc2

[clang-tools-extra] 8b0cc4a - [clang-tidy] Improve "common type" diagnostic output in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-07-23T10:26:22+02:00 New Revision: 8b0cc4a65dd435096bf64651693f5c9c3e2fee3b URL: https://github.com/llvm/llvm-project/commit/8b0cc4a65dd435096bf64651693f5c9c3e2fee3b DIFF: https://github.com/llvm/llvm-project/commit/8b0cc4a65dd435096bf64651693f5c9c3e2fee3b.diff LO

[PATCH] D106442: [clang-tidy] Improve "common type" diagnostic output in 'bugprone-easily-swappable-parameters'

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b0cc4a65dd4: [clang-tidy] Improve "common type" diagnostic output in 'bugprone-easily… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 91bc85b - [MS] Preserve base register %esi around movs[bwl]

Author: namazso Date: 2021-07-23T16:28:32+08:00 New Revision: 91bc85b1ebaaa4e61058c24b556d6f0569a9b091 URL: https://github.com/llvm/llvm-project/commit/91bc85b1ebaaa4e61058c24b556d6f0569a9b091 DIFF: https://github.com/llvm/llvm-project/commit/91bc85b1ebaaa4e61058c24b556d6f0569a9b091.diff LOG:

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91bc85b1ebaa: [MS] Preserve base register %esi around movs[bwl] (authored by namazso, committed by pengfei). Repository: rG LLVM Github Monorepo

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

pengfei added a comment. Happened to see it. I thought Craig might miss it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106210/new/ https://reviews.llvm.org/D106210 ___ cfe-commits mailing list cfe-com

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko added a comment. @erichkeane, could you look at the added LIT test. Is it suitable or require additional modifications? BTW: There are several failed tests but they seems to be a known issue (see bug 51117 ). Repository: rG LLVM Gith

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, mgrang. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Depends on D106527

[PATCH] D106434: [OpenCL] Add cl_khr_integer_dot_product

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG989bedec7a6a: [OpenCL] Add cl_khr_integer_dot_product (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 989bede - [OpenCL] Add cl_khr_integer_dot_product

Author: Sven van Haastregt Date: 2021-07-23T10:10:16+01:00 New Revision: 989bedec7a6ae95a0db865f23677047f78dc9257 URL: https://github.com/llvm/llvm-project/commit/989bedec7a6ae95a0db865f23677047f78dc9257 DIFF: https://github.com/llvm/llvm-project/commit/989bedec7a6ae95a0db865f23677047f78dc9257.

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet updated this revision to Diff 361132. kadircet added a comment. - Also get rid of the insertion adjuster Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106562/new/ https://reviews.llvm.org/D106562 Files: clang-tools-extra/clangd/CompileC

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet updated this revision to Diff 361133. kadircet marked 3 inline comments as done. kadircet added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ https://reviews.llvm.org/D106527 Files: clang

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210 + if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) { +// In theory there might be more than one input, but clangd can't deal wi

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko updated this revision to Diff 361134. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/ContinuationIndenter.cpp clang/l

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

kadircet updated this revision to Diff 361135. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106639/new/ https://reviews.llvm.org/D106639 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/

[PATCH] D106640: [clangd] Make dex iterator peek() and reachedEnd() nonvirtual

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is not polishe

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 361137. kito-cheng added a comment. Changes: - New function RISCVISAInfo::isSupportedExtensionFeature - Remove parameter CheckExperimental from RISCVISAInfo::isSupportedExtension - Clean up obvious comments - Address @jrtc27's and @craig.topper's comments

[PATCH] D106640: [clangd] Make dex iterator peek() and reachedEnd() nonvirtual

sammccall updated this revision to Diff 361138. sammccall added a comment. const fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106640/new/ https://reviews.llvm.org/D106640 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng marked 8 inline comments as done. kito-cheng added inline comments. Comment at: clang/test/Driver/riscv-arch.c:198-201 -// RUN: %clang -target riscv32-unknown-elf -march=rv32e -### %s \ -// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32E %s -// RV32E: error: in

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 361141. kito-cheng marked an inline comment as done. kito-cheng added a comment. Changes: - Rename RISCVISAInfo::parse to RISCVISAInfo::parseFeatures/RISCVISAInfo::parseArchString Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng marked an inline comment as done. kito-cheng added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:45 + + // Parse RISCV ISA info from arch string. + Error parse(StringRef Arch, bool EnableExperimentalExtension, jrtc27 wrote: >

[PATCH] D106642: [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

martong created this revision. martong added reviewers: NoQ, vsavchenko, steakhal, Szelethus. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Oh, I didn't accept it? Sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106285/new/ https://reviews.llvm.org/D106285

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2898967 , @hubert.reinterpretcast wrote: > In D106577#2897588 , @aaron.ballman > wrote: > >> In D106577#2897522 , @jyknight >> wrot

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

balazske created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of this revisio

[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Calling sync() *aft

[clang] 5c63bf3 - [OpenCL] Add NULL to standards prior to v2.0.

Author: Anastasia Stulova Date: 2021-07-23T11:54:36+01:00 New Revision: 5c63bf3abdc74b02c58c21cb0571eb4ba12b5235 URL: https://github.com/llvm/llvm-project/commit/5c63bf3abdc74b02c58c21cb0571eb4ba12b5235 DIFF: https://github.com/llvm/llvm-project/commit/5c63bf3abdc74b02c58c21cb0571eb4ba12b5235.d

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c63bf3abdc7: [OpenCL] Add NULL to standards prior to v2.0. (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/D105988?vs=

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov updated this revision to Diff 361155. azabaznov added a comment. Unify with `err_opencl_requires_extension`. Infrastructure for getting aliased extensions seems to messy and doesn't seem worth it yet since there are only two cases of such functionality (fp64 and 3d image writes) :( R

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

joerg added a comment. This patch is certainly wrong for NetBSD as the wchar_t encoding is up to the specific locale charset and *not* UCS-2 or UCS-4 for certain legacy encodings like the various shift encodings in East Asia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D106577#2899574 , @cor3ntin wrote: > In D106577#2898967 , > @hubert.reinterpretca

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#2899711 , @joerg wrote: > This patch is certainly wrong for NetBSD as the wchar_t encoding is up to the > specific locale charset and *not* UCS-2 or UCS-4 for certain legacy encodings > like the various shift en

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

aaron.ballman accepted this revision. aaron.ballman added a comment. In D104601#2898095 , @Meinersbur wrote: > Because of how large the switch construct would have been, I created a new > function `types::isDerivedFromC` together with the other function

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

martong added a comment. In D106285#2899545 , @vsavchenko wrote: > Oh, I didn't accept it? Sorry! No problem, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106285/new/ https://rev

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:304 + +def pp_pragma_include_instead_not_sysheader : Error< + "'#pragma clang include_instead' cannot be used outside of system headers">, Can you prefix the diagnos

[clang] 44fa31f - [Analyzer][solver] Fix inconsistent equivalence class data

Author: Gabor Marton Date: 2021-07-23T14:25:32+02:00 New Revision: 44fa31fa6da0c573ed972ec1d932c4ca3fb52f8f URL: https://github.com/llvm/llvm-project/commit/44fa31fa6da0c573ed972ec1d932c4ca3fb52f8f DIFF: https://github.com/llvm/llvm-project/commit/44fa31fa6da0c573ed972ec1d932c4ca3fb52f8f.diff

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44fa31fa6da0: [Analyzer][solver] Fix inconsistent equivalence class data (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106654: [clangd] Avoid range-loop init-list lifetime subtleties.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The original code appears to

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

sammccall accepted this revision. sammccall added a comment. Still LG Comment at: clang-tools-extra/clangd/CompileCommands.cpp:250 auto It = llvm::find(Cmd, "--"); for (std::string &Arg : ToAppend) Cmd.insert(It++, std::move(Arg)); hmm, why isn

[PATCH] D106375: Thread safety analysis: Mock getter for private mutexes can be undefined

aaronpuchert added a comment. In D106375#2896484 , @aaron.ballman wrote: > LGTM! It took me a minute to convince myself it wasn't really an ODR use (the > argument goes through the usual expression evaluation parsing and sema bits), > but because the a

[clang] 0e64a52 - Thread safety analysis: Mock getter for private mutexes can be undefined

Author: Aaron Puchert Date: 2021-07-23T14:46:02+02:00 New Revision: 0e64a525c12a0822683d3bdc51b6294b5265f860 URL: https://github.com/llvm/llvm-project/commit/0e64a525c12a0822683d3bdc51b6294b5265f860 DIFF: https://github.com/llvm/llvm-project/commit/0e64a525c12a0822683d3bdc51b6294b5265f860.diff

[PATCH] D106375: Thread safety analysis: Mock getter for private mutexes can be undefined

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e64a525c12a: Thread safety analysis: Mock getter for private mutexes can be undefined (authored by aaronpuchert). Repository: rG LLVM Github Mono

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:23 + bool IsGroup = false; + // "-\s+" or "" after an initial trim. The former is + // considered a group, the latter just a mark. We need to include a name Int

[PATCH] D106375: Thread safety analysis: Mock getter for private mutexes can be undefined

aaron.ballman added a comment. In D106375#2899827 , @aaronpuchert wrote: > In D106375#2896484 , @aaron.ballman > wrote: > >> LGTM! It took me a minute to convince myself it wasn't really an ODR use >> (the argu

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:215-236 +const VarDecl *findStdStreamDecl(StringRef StdName, CheckerContext &C) { + ASTContext &ACtx = C.getASTContext(); + + IdentifierInfo &II = ACtx.Idents.get(StdName); + auto Lo

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

erichkeane accepted this revision. erichkeane added a subscriber: rjmccall. erichkeane added a comment. This revision is now accepted and ready to land. That test is fine, though the errors are quite jarring! I'm surprised how confused we get! This looks acceptable to me, but I'm not sufficient

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This raises the question "is it safe to move functionality from CommandMangler to buildCompilerInvocation for convenience, are they always called on the same codepaths?" I think from ou

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

yaxunl added a comment. In D106315#2898536 , @tra wrote: > LGTM in general. > > One question -- does it have to be a function calling other functions just > for the sake of preserving them? > Can it be a flat array of pointers to the functions you need t

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:216 +for (auto *Input : ArgList.filtered(driver::options::OPT_INPUT)) { + // Driver name is also c

[PATCH] D106654: [clangd] Avoid range-loop init-list lifetime subtleties.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! it is unfortunate that history won't remember what an adventure it was to figure out the issue :D Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.

[clang-tools-extra] a0987e3 - [clangd] Improve performance of dex by 45-60%

Author: Kirill Bobyrev Date: 2021-07-23T15:28:35+02:00 New Revision: a0987e350ccce4fb9c3cbaf56732be1def5f810f URL: https://github.com/llvm/llvm-project/commit/a0987e350ccce4fb9c3cbaf56732be1def5f810f DIFF: https://github.com/llvm/llvm-project/commit/a0987e350ccce4fb9c3cbaf56732be1def5f810f.diff

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0987e350ccc: [clangd] Improve performance of dex by 45-60% (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://review

[PATCH] D106654: [clangd] Avoid range-loop init-list lifetime subtleties.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:288 }; - for (const auto &Entry : {CDBFile{&CompileCommandsJson, parseJSON}, -CDBFile{&BuildCompileCommandsJson, parseJSON}, -

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. @bnbarham I think you mean a patch like this, is it right? I'd like to fix the test in a pre-commit and then re-push my patch git diff diff --git a/clang/test/Index/preamble-reparse-changed-module.m b/clang/test/Index/preamble-reparse-changed-module.m index 1c6

[clang-tools-extra] 253b814 - [clangd] Avoid range-loop init-list lifetime subtleties.

Author: Sam McCall Date: 2021-07-23T15:33:04+02:00 New Revision: 253b8145dedbe8d10792f44b4af7f52dbecd527f URL: https://github.com/llvm/llvm-project/commit/253b8145dedbe8d10792f44b4af7f52dbecd527f DIFF: https://github.com/llvm/llvm-project/commit/253b8145dedbe8d10792f44b4af7f52dbecd527f.diff LO

[PATCH] D106654: [clangd] Avoid range-loop init-list lifetime subtleties.

This revision was automatically updated to reflect the committed changes. Closed by commit rG253b8145dedb: [clangd] Avoid range-loop init-list lifetime subtleties. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D106654?vs=361165&id=361177#toc Repository: rG LLVM G

[PATCH] D106654: [clangd] Avoid range-loop init-list lifetime subtleties.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:288 }; - for (const auto &Entry : {CDBFile{&CompileCommandsJson, parseJSON}, -CDBFile{&BuildCompileComma

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. Whoops, shouldn't mess with the mkdir line diff --git a/clang/test/Index/preamble-reparse-changed-module.m b/clang/test/Index/preamble-reparse-changed-module.m index 1c63e802ce0c..349ed0db27d0 100644 - a/clang/test/Index/preamble-reparse-changed-module.m +++ b/clang/te

[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

kbobyrev added a comment. I am extremely confused, but this is actually 4.5% slower than the updated (improved performance with D106528 ) baseline. Now, this actually works (2.2-2.5% faster): ❯ git diff diff --git a/clang-tools-extra/clangd/index/dex/Iterat

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet updated this revision to Diff 361182. kadircet marked an inline comment as done. kadircet added a comment. Use move_iterator instead of inserting in a loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106562/new/ https://reviews.llvm.org

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:225 +auto It = llvm::find(Cmd, "--"); +for (std::string &Arg : ToAppend) + Cmd.insert(It++, std::move(Arg)); sammccall wrote: > oops, might have left this commen

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet updated this revision to Diff 361183. kadircet marked 2 inline comments as done. kadircet added a comment. Change occurence of ArgList usage for canonical prefixes to `Has` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ https://

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361186. sriharikrishna added a comment. OMPIRBuilder for Interop directive. Squashed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/

[clang] 9a977da - Fix __hip_fabin visibility

Author: Yaxun (Sam) Liu Date: 2021-07-23T10:14:29-04:00 New Revision: 9a977daaf6b19c6ff7a53afbe8ece2cb7011dd9e URL: https://github.com/llvm/llvm-project/commit/9a977daaf6b19c6ff7a53afbe8ece2cb7011dd9e DIFF: https://github.com/llvm/llvm-project/commit/9a977daaf6b19c6ff7a53afbe8ece2cb7011dd9e.dif

[PATCH] D106571: [HIP] Fix visibility of __hip_fatbin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a977daaf6b1: Fix __hip_fabin visibility (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

kadircet updated this revision to Diff 361193. kadircet marked 2 inline comments as done. kadircet added a comment. - push_back instead of insert - don't parse argv[0] rather than skipping it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106639/new/

[PATCH] D106664: [clang][docs] Fix typos in Options.td and regen ClangCommandLineReference.rst.

fcambus created this revision. Herald added a subscriber: dang. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a couple of typos in Options.td and regenerate ClangCommandLineReference.rst. Repository: rG LLVM Github Monore

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet updated this revision to Diff 361195. kadircet added a comment. - Add FIXME for using CommandMangler and buildCompilerInvocation in clangd-indexer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106562/new/ https://reviews.llvm.org/D106562

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6330-6331 + if (const auto *C = S.getSingleClause()) { +llvm::Value *InteropvarPtr = +EmitLValue(C->getInteropVar()).getPointer(*this); +llvm::omp::OMPInteropType InteropType = llvm::om

[clang] 44dbbe6 - [HIP] Preserve ASAN bitcode library functions

Author: Yaxun (Sam) Liu Date: 2021-07-23T10:35:52-04:00 New Revision: 44dbbe61060acac4d0991a15decac4c909e26844 URL: https://github.com/llvm/llvm-project/commit/44dbbe61060acac4d0991a15decac4c909e26844 DIFF: https://github.com/llvm/llvm-project/commit/44dbbe61060acac4d0991a15decac4c909e26844.dif

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44dbbe61060a: [HIP] Preserve ASAN bitcode library functions (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361208. dgoldman marked 3 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-ex

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:106 +struct PragmaMark { + SourceLocation Loc; + std::string Text; sammccall wrote: > Line number is enough, right? > Column is not interesting, and pragma marks expanded from

[PATCH] D106669: [clangd] Unify compiler invocation creation

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Background-indexing is fine, be

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 361216. khchen added a comment. address arichardson's comment, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/lib/Basic/Targets/RISCV.cpp cla

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

khchen marked an inline comment as done. khchen added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:235 +bool Is64Bit = getTriple().getArch() == llvm::Triple::riscv64; +ABI = llvm::RISCV::computeDefaultABIFromArch(ISAInfo, Is64Bit).str(); + } The ISAInfo includes XLen ===

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:233 + // Use the explicitly target-feature to compute default ABI. + if (getABI().empty()) { +bool Is64Bit = getTriple().getArch() == llvm::Triple::riscv64; I don't think using the

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2a6ec8eae75: [clangd] Use CommandMangler in TestTU (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] d2a6ec8 - [clangd] Use CommandMangler in TestTU

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:05+02:00 New Revision: d2a6ec8eae75b60081e081eeb37022839f4f2d04 URL: https://github.com/llvm/llvm-project/commit/d2a6ec8eae75b60081e081eeb37022839f4f2d04 DIFF: https://github.com/llvm/llvm-project/commit/d2a6ec8eae75b60081e081eeb37022839f4f2d04.dif

[clang-tools-extra] 1c0d008 - [clangd] Get rid of arg adjusters in CommandMangler

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:06+02:00 New Revision: 1c0d0085bcaaf27cc8d9492eb3c5c05058e54b8e URL: https://github.com/llvm/llvm-project/commit/1c0d0085bcaaf27cc8d9492eb3c5c05058e54b8e DIFF: https://github.com/llvm/llvm-project/commit/1c0d0085bcaaf27cc8d9492eb3c5c05058e54b8e.dif

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c0d0085bcaa: [clangd] Get rid of arg adjusters in CommandMangler (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 7cc8a8e - [clangd] Canonicalize compile flags before applying edits

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:06+02:00 New Revision: 7cc8a8e3849dc4044cc799e2c1f6cc241b851b70 URL: https://github.com/llvm/llvm-project/commit/7cc8a8e3849dc4044cc799e2c1f6cc241b851b70 DIFF: https://github.com/llvm/llvm-project/commit/7cc8a8e3849dc4044cc799e2c1f6cc241b851b70.dif

[clang-tools-extra] ba5dd94 - [clangd] Adjust compile flags to contain only the requested file as input

Author: Kadir Cetinkaya Date: 2021-07-23T17:15:06+02:00 New Revision: ba5dd945ad9124f24452987be64040a6ea6cd25e URL: https://github.com/llvm/llvm-project/commit/ba5dd945ad9124f24452987be64040a6ea6cd25e DIFF: https://github.com/llvm/llvm-project/commit/ba5dd945ad9124f24452987be64040a6ea6cd25e.dif

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cc8a8e3849d: [clangd] Canonicalize compile flags before applying edits (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ ht

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba5dd945ad91: [clangd] Adjust compile flags to contain only the requested file as input (authored by kadircet). Repository: rG LLVM Github Monorep

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

baramin added a comment. We have a regression after the fix: CPP-25899 CLion formatting does not match what clang-format produces if AlignConsecutiveAssignments: Consecutive Additional two spaces before `=` were added to indentation while form

[PATCH] D106642: [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! You got me thinking whether two symbols can have the same dump. We definitely don't want this to happen but there's also no reason to believe it doesn't, given that this wouldn't affect any

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:236-242 + const BugMessageMap BugMessages = { + {&BT_FileNull, "Assuming opening the stream fails here"}, + {&BT_UseAfterClose, "Stream closed here"}, + {&BT_UseAfterO

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

thakis added a comment. One of your 4 commits in https://github.com/llvm/llvm-project/compare/f86570cd5241...ba5dd945ad91 broke check-clangd on arm macs: http://45.33.8.238/macm1/14648/step_9.txt Please take a look, and revert for now if it takes a while to fix. (And consider spreading out co

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361246. dgoldman added a comment. Add in suggested algorithm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp cl

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, dgoldman wrote: > sammccall wrote: > > FWIW the f

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361247. dgoldman added a comment. minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tools

[clang-tools-extra] 04e21fb - Revert "[clangd] Adjust compile flags to contain only the requested file as input"

Author: Kadir Cetinkaya Date: 2021-07-23T17:58:11+02:00 New Revision: 04e21fbc44c145d5599ef8db9aaf66b159107f33 URL: https://github.com/llvm/llvm-project/commit/04e21fbc44c145d5599ef8db9aaf66b159107f33 DIFF: https://github.com/llvm/llvm-project/commit/04e21fbc44c145d5599ef8db9aaf66b159107f33.dif

[clang-tools-extra] e7590d7 - Revert "[clangd] Canonicalize compile flags before applying edits"

Author: Kadir Cetinkaya Date: 2021-07-23T18:20:52+02:00 New Revision: e7590d748adfa6afb67c4fb4f72c6f7eeb812734 URL: https://github.com/llvm/llvm-project/commit/e7590d748adfa6afb67c4fb4f72c6f7eeb812734 DIFF: https://github.com/llvm/llvm-project/commit/e7590d748adfa6afb67c4fb4f72c6f7eeb812734.dif

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-features'.

khchen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:835 +llvm::RISCVISAInfo::filterISAStrings(Features); +std::vector Ops; +if (Features.empty()) { jrtc27 wrote: > Why is this building a list? Just use a string so it's in the

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated aaron.ballman wrote: > cor3ntin wrote: > > cor3ntin wrote: > > > aaron.ballman wrote: > > > > Here's an interestin

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2899715 , @aaron.ballman wrote: > In D106577#2899711 , @joerg wrote: > >> This patch is certainly wrong for NetBSD as the wchar_t encoding is up to >> the specific locale cha

  1   2   >