This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e64a525c12a: Thread safety analysis: Mock getter for private mutexes can be undefined (authored by aaronpuchert).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106375/new/ https://reviews.llvm.org/D106375 Files: clang/docs/ThreadSafetyAnalysis.rst Index: clang/docs/ThreadSafetyAnalysis.rst =================================================================== --- clang/docs/ThreadSafetyAnalysis.rst +++ clang/docs/ThreadSafetyAnalysis.rst @@ -640,8 +640,8 @@ Mutex mu; public: - // For thread safety analysis only. Does not actually return mu. - Mutex* getMu() RETURN_CAPABILITY(mu) { return 0; } + // For thread safety analysis only. Does not need to be defined. + Mutex* getMu() RETURN_CAPABILITY(mu); void doSomething() REQUIRES(mu); };
Index: clang/docs/ThreadSafetyAnalysis.rst =================================================================== --- clang/docs/ThreadSafetyAnalysis.rst +++ clang/docs/ThreadSafetyAnalysis.rst @@ -640,8 +640,8 @@ Mutex mu; public: - // For thread safety analysis only. Does not actually return mu. - Mutex* getMu() RETURN_CAPABILITY(mu) { return 0; } + // For thread safety analysis only. Does not need to be defined. + Mutex* getMu() RETURN_CAPABILITY(mu); void doSomething() REQUIRES(mu); };
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits