ABataev added inline comments.
================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6330-6331
+ if (const auto *C = S.getSingleClause<OMPInitClause>()) {
+ llvm::Value *InteropvarPtr =
+ EmitLValue(C->getInteropVar()).getPointer(*this);
+ llvm::omp::OMPInteropType InteropType = llvm::omp::OMPInteropType::Unknown;
----------------
This code is common for all `if-else` braches, move out of the conditional
blocks?
================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6335-6336
+ InteropType = llvm::omp::OMPInteropType::Target;
+ else if (C->getIsTargetSync())
+ InteropType = llvm::omp::OMPInteropType::TargetSync;
+ OMPBuilder.createOMPInteropInit(Builder, InteropvarPtr, InteropType,
Device,
----------------
Can we have anything else rather than `C->getIsTargetSync()` here? If no, then
it should look like this:
```
if (C->getIsTarget()) {
InteropType = llvm::omp::OMPInteropType::Target;
} else {
assert(C->getIsTargetSync() && "Expected ...");
InteropType = llvm::omp::OMPInteropType::TargetSync;
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105876/new/
https://reviews.llvm.org/D105876
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
