[PATCH] D105354: [clang][AST] Add support for DecompositionDecl to ASTImporter.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2305-2309 + BindingDecl *ToD; + if (GetImportedOrCreateDecl(ToD, D, Importer.getToContext(), DC, Loc, + Name.getAsIdentifierInfo())) +return ToD; + shafik

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357422. RedDocMD added a comment. Tests implemented Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

sammccall created this revision. sammccall added reviewers: kadircet, nridge. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This reduces t

[PATCH] D105681: [clangd] Add platform triple (host & target) to version info

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, mstorsjo, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Useful in logs to u

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

vsavchenko added a comment. Great, thanks for addressing my comments! I still have a couple of minor suggestions though. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:99-100 + +const SmallVector StdPtrNames = {"shared_ptr", "unique_ptr", +

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. @vsavchenko any update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:280 +#if CLANGD_TIDY_CHECKS TEST_F(ConfigCompileTests, Tidy) { why do we need to disable this test? it doesn't really build an ast or assert on the diagnosti

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Great! Thanks for addressing all of the comments! Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType();

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

hokein added a comment. In D105533#2865803 , @dgoldman wrote: > Thanks! Just to confirm, the non-simplified example is also fixed, right? > > struct a { > int xxx; > }; > > int g_107; > int g_108; > int g_109; > > struct a g_999; >

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

hokein updated this revision to Diff 357460. hokein added a comment. add the non-simplified sample. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105533/new/ https://reviews.llvm.org/D105533 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/Sem

[clang] f4877c7 - [clang] Improve `-Wnull-dereference` diag to be more in-line with reality

Author: Roman Lebedev Date: 2021-07-09T12:51:12+03:00 New Revision: f4877c78c0fc98be47b926439bbfe33d5e1d1b6d URL: https://github.com/llvm/llvm-project/commit/f4877c78c0fc98be47b926439bbfe33d5e1d1b6d DIFF: https://github.com/llvm/llvm-project/commit/f4877c78c0fc98be47b926439bbfe33d5e1d1b6d.diff

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

nemanjai added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1533 + def int_ppc_lwarx : GCCBuiltin<"__builtin_ppc_lwarx">, + Intrinsic<[llvm_i32_ty], [llvm_ptr_ty], [IntrNoMem]>; + def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 357463. ASDenysPetrov added a comment. Added more descriptive comments. Fixed `RangeConstraintManager::updateExistingConstraints` function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: c

[clang] 47653db - [clang] Fix an infinite loop during typo-correction

Author: Haojian Wu Date: 2021-07-09T12:03:57+02:00 New Revision: 47653db6d2a3964c14cca5ffa73e79aeee292e8b URL: https://github.com/llvm/llvm-project/commit/47653db6d2a3964c14cca5ffa73e79aeee292e8b DIFF: https://github.com/llvm/llvm-project/commit/47653db6d2a3964c14cca5ffa73e79aeee292e8b.diff LO

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47653db6d2a3: [clang] Fix an infinite loop during typo-correction (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. Can you please explain why you do the same thing in two different ways? Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2797-2799 +ProgramStateRef +RangeConstraintManager::updateExistingConstraints(ProgramStateRef State, + SymbolRef Sym,

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2866704 , @ASDenysPetrov wrote: > @vsavchenko That's not the question I'm asking. Why do you need to set constraints for other symbolic expressions, when `SymbolicInferrer` can look them up on its own? Which ca

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 357471. iii added a comment. - Reserve the address space "tail" in the "[TSan] Define C/C++ address ranges for SystemZ" patch. - Drop the "[TSan] Simulate OOM in mmap_interceptor()" patch. - Group "[TSan] Use zeroext for function parameters" with the common code

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. To be more sure of not breaking something we'd likely have to reduce the cases where tok::identifier was checked, it depends if "not catching every case" is caught is more acceptable. I certainly see that elsewhere in clang (like identifying where override is mis

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. In D102273#2866532 , @vsavchenko wrote: > Great! Thanks for addressing all of the comments! Thank you for the review! Can you take care of merging it? I don't have the required permission. Repository: rG LLVM Github Mon

[clang] 329f819 - [NFC][Clang][CodegenOpenCL] Fix test not to rely on volatile store not being removed

Author: Roman Lebedev Date: 2021-07-09T14:16:54+03:00 New Revision: 329f8197ef59f9bd23328b52d623ba768b51dbb2 URL: https://github.com/llvm/llvm-project/commit/329f8197ef59f9bd23328b52d623ba768b51dbb2 DIFF: https://github.com/llvm/llvm-project/commit/329f8197ef59f9bd23328b52d623ba768b51dbb2.diff

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWit

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357479. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Change `annot_pragma_openmp_from_attr` into `annot_attr_openmp` based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https:/

[PATCH] D92777: [clang-tidy] Add bugprone-strlen-in-array-index checker

whisperity added a comment. The tests are a bit slim. We definitely need more cases... what if the array isn't allocated locally, but received as a parameter? I take that we need both an `fgets` and a `strlen` call in the same function(?) to emit diagnostics. Are we sure it will work if the arr

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an *att

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked 8 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWit

[PATCH] D105693: [analyzer][solver][NFC] Refactor how we detect (dis)equalities

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D105695: [clang][tooling] Accept Clang invocations with "-fno-integrated-as"

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, bmahjour. jansvoboda11 added a project: clang. jansvoboda11 requested review of this revision. When "-fno-integrated-as" is passed to the Clang driver (or set by default by a specific toolchain), it will cons

[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

jansvoboda11 added a comment. In D103461#2862067 , @jansvoboda11 wrote: > In D103461#2841918 , @bmahjour > wrote: > >> @jansvoboda11 This change is causing the following LIT tests to fail on AIX: >> >> Clang :

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357487. aaron.ballman added a comment. Enable attribute support as an extension (with the usual diagnostics). Note that this adds some new diagnostic groups for OpenMP as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https:/

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but wait for others' comments/suggestions/etc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 __

[PATCH] D103465: [OpaquePtr] Track pointee types in Clang

erichkeane added inline comments. Comment at: clang/lib/CodeGen/Address.h:26 llvm::Value *Pointer; + llvm::Type *PointeeType; CharUnits Alignment; I think this will still end up being a problem when we try to look into the type for multi-dimension pointer

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added a comment. In D105648#2866893 , @ABataev wrote: > LG, but wait for others' comments/suggestions/etc. Thank you for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105479/new/ https://reviews.llvm.org/D105479 ___

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

cor3ntin accepted this revision. cor3ntin added a comment. Thanks for changing the name. It looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL co

[PATCH] D105127: Implement P1401R5

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to bool">; def err_static_assert_failed

[PATCH] D105127: Implement P1401R5

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Making it clear that there are still some minor changes left to be made. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 357501. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Improve diagnostic message, fix comments, use isInvalid instead of isUsable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/

[PATCH] D105127: Implement P1401R5

cor3ntin marked 5 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. In D103096#2866730 , @vsavchenko wrote: > In D103096#2866704 , @ASDenysPetrov > wrote: > >> @vsavchenko > > That's not the question I'm asking. Why do you need to set constraints

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. The change made me think we should add the negative test with -mlong-double-128, but then I thought we should probably make that an error until we've sorted through the AIX binar

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867021 , @ASDenysPetrov wrote: > In D103096#2866730 , @vsavchenko > wrote: > >> In D103096#2866704 , >> @ASDenysPetrov wrote: >>

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. Generally, with this patch we kinda have several constraints for each cast of a single symbol. And we shall care for all of that constraints and timely update them (if possible). For instance, we have `int x` and met casts of this symbol in code: int x; (char)

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2863648 , @owenpan wrote: > Has this been tested against a large code base? It also needs an unqualified > LGTM before it can be merged. D105701: [clang-format] test revision (NOT FOR COMMIT) to demonstrate east/

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 357511. adamcz added a comment. Fix a more generic case of invalid static initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Parse/ParseDec

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added a comment. OK, I think we've got it now :-) I kept the original crash test in the change, but I'm not sure if it's appropriate anymore. Let me know if you think I should remove it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko > I still want to hear a good explanation why is it done this way. Here `c` is > mapped to `(char)x`, and we have `[-10, 10]` directly associated with it, but > we also have `(short)x` associated with `[8, 8]`. Why can't > `VisitSymbolCast` look up

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867104 , @ASDenysPetrov wrote: > Generally, with this patch we kinda have several constraints for each cast of > a single symbol. And we shall care for all of that constraints and timely > update them (if possibl

[PATCH] D105127: Implement P1401R5

aaron.ballman added a comment. This LGTM aside from a small nit, but you should wait a bit to land in case other reviewers have comments. Comment at: clang/test/CXX/stmt.stmt/stmt.select/stmt.if/p2.cpp:42-43 + +struct S { +} s; void f() { This looks like it

[PATCH] D105127: Implement P1401R5

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oops, I chanted the magic incantation but forgot to press the button. LGTM again. ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867136 , @ASDenysPetrov wrote: > @vsavchenko > >> I still want to hear a good explanation why is it done this way. Here `c` >> is mapped to `(char)x`, and we have `[-10, 10]` directly associated with it, >> but

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 357516. quinnp added a comment. Adressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def cl

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea added a comment. In D94098#2865372 , @efriedma wrote: > I'm confused what your goal here is, exactly. The point of allowing 512-bit > inline asm operands is presumably to allow writing efficient code involving > inline asm... but you're intenti

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Generally it looks okay to me. However, I have a question: In `SimpleSValBuilder::evalBinOpNN` we do infer values to symbols. E.g. if we have an expression `y / x` and `y` is known to be `0`

[PATCH] D105693: [analyzer][solver][NFC] Refactor how we detect (dis)equalities

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:687 /// A small helper structure representing symbolic equality. /// This is

[clang] 97c675d - Revert "Revert "Temporarily do not drop volatile stores before unreachable""

Author: Nico Weber Date: 2021-07-09T11:44:34-04:00 New Revision: 97c675d3d43fe02a0ff0a8350d79344c845758af URL: https://github.com/llvm/llvm-project/commit/97c675d3d43fe02a0ff0a8350d79344c845758af DIFF: https://github.com/llvm/llvm-project/commit/97c675d3d43fe02a0ff0a8350d79344c845758af.diff LO

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

ABataev updated this revision to Diff 357532. ABataev added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Rebase + added runtime test intended to be fixed by the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D105708: [analyzer][NFC] Display the correct function name even in crash dumps

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, Szelethus, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision. He

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1388 +//===--===// +//New constraint handler +//===--

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 357536. cor3ntin added a comment. Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D104975: Implement P1949

cor3ntin added a comment. In D104975#2842425 , @jfb wrote: > It would be more user-friendly to say which character is not allowed in the > diagnostic. Agreed, done! > Do we need to have a backward-compatible flag to preserve the old behavior, > or do

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#2832740 , @ABataev wrote: > In D102107#2832286 , @jdoerfert > wrote: > >> In D102107#2824581 , @ABataev >> wrote: >> >>> In D102107

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

ldionne added a comment. In D104500#2865917 , @mizvekov wrote: > Well I thought that meant exactly that libc++ does not support C++98, it only > works on clang because it provides so much of C++11 as an extension. > > I did not remove this just on my own

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2867382 , @jdoerfert wrote: > In D102107#2832740 , @ABataev wrote: > >> In D102107#2832286 , @jdoerfert >> wrote: >> >>> In D102107#28

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko > Why did you write it this way!? I want the map contains only valid constraints at any time, so we can easely get them without traversing with all variants intersecting with each other. I'm gonna move `updateExistingConstraints ` logic to `VisitSymbo

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. Doesn't seem like anything changed on the mailing list side, should we land this now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 __

[PATCH] D105708: [analyzer][NFC] Display the correct function name even in crash dumps

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105708/new/ https://reviews.llvm.org/D105708 ___

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105049/new/ https://reviews.llvm.org/D105049

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

grokos added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1689 + : "lib" + libname + "-" + archname + "-" + gpuname, + "a"); + "a" --> ".a" (add a dot) Comment at: clang/lib/Driver/ToolC

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang/test/Analysis/smart-ptr.cpp:472-474 + // We are testing the fact that in our modelling of + // operator<<(basic_ostream &, const unique_ptr &) +

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s kito-cheng wrote: > MaskRay

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. In D105637#2864684 , @balazske wrote: > Could not make a simple test for the change. This file F17831281: > BugReportInterestingnessTest.cpp is what > I could do, but it prints the needed text to

[PATCH] D105695: [clang][tooling] Accept Clang invocations with "-fno-integrated-as"

dexonsmith added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:119-122 + if (isa(A)) { +ExternalAssembler = true; +break; + } Seems like this could (unexpectedly?) let through a command with multiple `-cc1`s (if I'm reading

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1241 + // Find the first constraint and exit the loop. + RSPtr = getConstraint(State, S); +} vsavchenko wrote: > Why do you get associated cons

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM but I have a strong preference that `clang/test/Layout/aix-packed-bitfields.c` be committed separately if my understanding is right. Comment at: clang/test/Layout/ai

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867441 , @ASDenysPetrov wrote: > @vsavchenko > >> Why did you write it this way!? > > I want the map contains only valid constraints at any time, so we can easely > get them without traversing with all variants in

[PATCH] D103465: [OpaquePtr] Track pointee types in Clang

jyknight added inline comments. Comment at: clang/lib/CodeGen/Address.h:26 llvm::Value *Pointer; + llvm::Type *PointeeType; CharUnits Alignment; erichkeane wrote: > I think this will still end up being a problem when we try to look into the > type for mul

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

josemonsalve2 added a comment. In D102107#2867417 , @ABataev wrote: > In D102107#2867382 , @jdoerfert > wrote: > >> In D102107#2832740 , @ABataev >> wrote: >> >>> In D10

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 357578. shafik added reviewers: jingham, jasonmolenda. shafik added a comment. Changing approach based on Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://reviews.llvm.org/D105564 Files: lldb/source/Plugins/Expr

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added a comment. @aprantl after your comments and discussion offline I changed my approach to do this lookup using the symbol table and it worked out. The main issue with the first approach was that gcc would also have to be updated in order for them to change their approach to generatin

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2867670 , @josemonsalve2 wrote: > In D102107#2867417 , @ABataev wrote: > >> In D102107#2867382 , @jdoerfert >> wrote: >> >>> In D1021

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

probinson added a comment. > Currently when we have a member function that has an auto return type and the > definition is out of line we generate two DWARF DIE. > One for the declaration and a second one for the definition, the definition > holds the deduced type but does not contain a DW_AT_na

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added a comment. In D105564#2867717 , @probinson wrote: >> Currently when we have a member function that has an auto return type and >> the definition is out of line we generate two DWARF DIE. >> One for the declaration and a second one for the de

[clang] 92dcb1d - [Clang] Introduce Swift async calling convention.

Author: Varun Gandhi Date: 2021-07-09T11:50:10-07:00 New Revision: 92dcb1d2db8c4de48df0af806dca631523cd4169 URL: https://github.com/llvm/llvm-project/commit/92dcb1d2db8c4de48df0af806dca631523cd4169 DIFF: https://github.com/llvm/llvm-project/commit/92dcb1d2db8c4de48df0af806dca631523cd4169.diff

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92dcb1d2db8c: [Clang] Introduce Swift async calling convention. (authored by varungandhi-apple). Changed prior to commit: https://reviews.llvm.org

[clang] ff8b1b1 - Reapply [IR] Don't mark mustprogress as type attribute

Author: Nikita Popov Date: 2021-07-09T20:57:44+02:00 New Revision: ff8b1b1b9caef57046bda1ca36c95f0e03527c6e URL: https://github.com/llvm/llvm-project/commit/ff8b1b1b9caef57046bda1ca36c95f0e03527c6e DIFF: https://github.com/llvm/llvm-project/commit/ff8b1b1b9caef57046bda1ca36c95f0e03527c6e.diff

[PATCH] D105681: [clangd] Add platform triple (host & target) to version info

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! only printing the target when they differ makes a lot of sense! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105681/new/ https

[clang] 768e3af - PR51034: Debug Info: Remove 'prototyped' from K&R function declarations

Author: David Blaikie Date: 2021-07-09T12:07:36-07:00 New Revision: 768e3af6345a532d383205049679aaaccca26628 URL: https://github.com/llvm/llvm-project/commit/768e3af6345a532d383205049679aaaccca26628 DIFF: https://github.com/llvm/llvm-project/commit/768e3af6345a532d383205049679aaaccca26628.diff

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

estewart08 added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif JonChesterfield wrote: > jdoerfert wrote: > > That seems to be fundamentally broken then, but let's see, ma

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks perfectly sensible to me. In the mailing list I seem to have made a mistake about how this works: we don't explicitly scan the AST for potential statements that could cause a state chang

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. In D105637#2867602 , @NoQ wrote: > You could define your own diagnostic consumer in the unittest and intercept > all the notes. (you can find an example of this in D94476 ) (I can't believe I haven'

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov created this revision. kstoimenov added reviewers: kda, vitalybuka. Herald added a subscriber: dang. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Summary This option can be used to reduce the size of the binary. The

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

abhinavgaba accepted this revision. abhinavgaba added a comment. Thanks for the fix, Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105562/new/ https://reviews.llvm.org/D105562 ___ cfe-commits mai

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 357604. quinnp added a comment. Feature is now working correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSemaKind

[clang] ab8989a - [OPENMP]Fix overlapped mapping for dereferenced pointer members.

Author: Alexey Bataev Date: 2021-07-09T12:51:26-07:00 New Revision: ab8989ab8710c693e83edbccf221746c897c835f URL: https://github.com/llvm/llvm-project/commit/ab8989ab8710c693e83edbccf221746c897c835f DIFF: https://github.com/llvm/llvm-project/commit/ab8989ab8710c693e83edbccf221746c897c835f.diff

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab8989ab8710: [OPENMP]Fix overlapped mapping for dereferenced pointer members. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2867109 , @MyDeveloperDay wrote: > In D69764#2863648 , @owenpan wrote: > >> Has this been tested against a large code base? It also needs an unqualified >> LGTM before it can be

  1   2   >