grokos added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1689
+ : "lib" + libname + "-" + archname + "-" + gpuname,
+ "a");
+
----------------
"a" --> ".a" (add a dot)
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1796-1798
+ if (SDL_Name != "omp" && SDL_Name != "cudart" && SDL_Name != "m" &&
+ SDL_Name != "gcc" && SDL_Name != "gcc_s" && SDL_Name != "pthread" &&
+ SDL_Name != "hip_hcc") {
----------------
I'm with @jdoerfert here, you can use a set of library names which are known to
not have device-specific SDLs and check whether that set contains `SDL_Name`.
Also, `SDL_Names` can be a set of unique entries, this way even if you try to
add the same library twice it won't be added. This quadratic-complexity loop
looks ugly...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105191/new/
https://reviews.llvm.org/D105191
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
