cor3ntin added a comment.

In D104975#2842425 <https://reviews.llvm.org/D104975#2842425>, @jfb wrote:

> It would be more user-friendly to say which character is not allowed in the 
> diagnostic.

Agreed, done!

> Do we need to have a backward-compatible flag to preserve the old behavior, 
> or do we believe that nobody will be affected by the change? We should make 
> this choice explicitly and state it in the patch description.

I have been wondering about that.
I came to the conclusion it would probably not be worth it. Until fairly 
recently Unicode identifiers in GCC were not really usable and therefore not 
used afaik.
I haven't seen people use emojis or other interesting symbols in non-toy code.

I tried to make that clearer in the commit message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104975/new/

https://reviews.llvm.org/D104975

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D104975: Implement ... Corentin Jabot via Phabricator via cfe-commits

Reply via email to